Change in vdsm[master]: API: Provide a working getAllTasks API
Adam Litke has posted comments on this change. Change subject: API: Provide a working getAllTasks API .. Patch Set 4: Hi Dan. In your overall comment for the previous patch I read: Adam, your suggested API is great. However, I feel that the current mess that is task.tag is not ready for API exposure. -and- I would very much like not to expose this kind of tags property of a task. Taken together I read this to mean, don't expose the task tag in the API... -- To view, visit http://gerrit.ovirt.org/3613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Shireesh Anjal san...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
Dan Kenigsberg has submitted this change and it was merged. Change subject: API: Provide a working getAllTasks API .. API: Provide a working getAllTasks API Changes since last iteration: - Dropped 'tags' filtering from the API. Users can do client-side filtering as they see fit. The current APIs for retrieving all task information do not actually return all task information. I would like to introduce a new API that corrects this and other issues with the current API while preserving backwards compatibility with ovirt-engine for as long as is necessary. The current APIs: getAllTasksInfo(spUUID=None, options = None): - Returns a dictionary that maps a task UUID to a task verb. - Despite having 'all' in the name, this API only returns tasks that have an 'spm' tag. - This call returns only one piece of information for each task. - The spUUID parameter is deprecated and ignored. getAllTasksStatuses(spUUID=None, options = None): - Returns a dictionary of task status information. - Despite having 'all' in the name, this API only returns tasks that have an 'spm' tag. - The spUUID parameter is deprecated and ignored. I propose the following new API: getAllTasks(options=None): - Returns a dictionary of task information. The info from both of the above functions would be merged into a single result set. - The spUUID parameter is dropped. options is for future extension and is currently not used. This new API includes all functionality that is available in the old calls. In the future, ovirt-engine could switch to this API and preserve the current semantics by ignoring tasks where task['tag'] != 'spm'. Meanwhile, API users that really want all tasks (gluster and the REST API) can get what they need. Signed-off-by: Adam Litke a...@us.ibm.com Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44 --- M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/storage/hsm.py M vdsm/storage/task.py M vdsm/storage/taskManager.py M vdsm_api/vdsmapi-schema.json M vdsm_cli/vdsClient.py 7 files changed, 106 insertions(+), 3 deletions(-) Approvals: Adam Litke: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Shireesh Anjal san...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
Dan Kenigsberg has posted comments on this change. Change subject: API: Provide a working getAllTasks API .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Shireesh Anjal san...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
Adam Litke has posted comments on this change. Change subject: API: Provide a working getAllTasks API .. Patch Set 4: Verified In this version, I dropped the tags filtering from the API in favor of letting clients manipulate the task list as they see fit. This was suggested by Dan. -- To view, visit http://gerrit.ovirt.org/3613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Shireesh Anjal san...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: Provide a working getAllTasks API .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/599/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/3613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Shireesh Anjal san...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
Dan Kenigsberg has posted comments on this change. Change subject: API: Provide a working getAllTasks API .. Patch Set 4: Have I really suggested this? Would it be possible to add server-side filtering semantics to this verb, sometime in the future? -- To view, visit http://gerrit.ovirt.org/3613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Shireesh Anjal san...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
Dan Kenigsberg has posted comments on this change.
Change subject: API: Provide a working getAllTasks API
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Adam, your suggested API is great. However, I feel that the current mess that
is task.tag is not ready for API exposure.
If someone creates a task and tags it aspmushmush, it would be considered an
spm task, since spm is a substring of it. I find the string search logic of
if not tag or tag in task.getTags():
really messy and unintentional. Currently, a task may have only one string tag.
The multiple form of Task.getTags() serves only as a distraction. I would very
much like not to expose this kind of tags property of a task.
Again, this is NOT your fault.
File vdsm/storage/taskManager.py
Line 119:
Line 120: self.log.debug(Entry.)
Line 121: subRes = {}
Line 122: for taskID, task in self._tasks.items():
Line 123: if not tags or set(tags) set([task.getTags()]):
I'd prefer to calculate set(tags) only once
also, I found the code misleading - all it does is
if not tags or task.getTags() in tags
yes, I know that the original code is not any better.
Line 124: try:
Line 125: subRes[taskID] = task.getDetails()
Line 126: except se.UnknownTask:
Line 127: # Return info for existing tasks only.
--
To view, visit http://gerrit.ovirt.org/3613
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Shireesh Anjal san...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
Bala.FA has posted comments on this change.
Change subject: API: Provide a working getAllTasks API
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
File vdsm_cli/vdsClient.py
Line 1176: keys = [x.strip() for x in args[0].split(',')]
In that case, I would like to have list of keys as less of params eg. keys =
args[1:]
--
To view, visit http://gerrit.ovirt.org/3613
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Shireesh Anjal san...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
Adam Litke has posted comments on this change. Change subject: API: Provide a working getAllTasks API .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/3613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Shireesh Anjal san...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
Bala.FA has posted comments on this change.
Change subject: API: Provide a working getAllTasks API
..
Patch Set 3: (1 inline comment)
File vdsm_cli/vdsClient.py
Line 1176: keys = [x.strip() for x in args[0].split(',')]
As args is a list, why not passing it as keys?
--
To view, visit http://gerrit.ovirt.org/3613
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Shireesh Anjal san...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
Adam Litke has posted comments on this change.
Change subject: API: Provide a working getAllTasks API
..
Patch Set 3: (1 inline comment)
File vdsm_cli/vdsClient.py
Line 1176: keys = [x.strip() for x in args[0].split(',')]
Because we might want to add additional parameters someday so args[1] might be
some flags or something.
--
To view, visit http://gerrit.ovirt.org/3613
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Shireesh Anjal san...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
Adam Litke has posted comments on this change. Change subject: API: Provide a working getAllTasks API .. Patch Set 2: Igor, thanks for your review. In looking at getAllTasksInfo() and getAllTasksStatuses() I don't see how task info could be more expensive to get than task status. Today getTaskInfo() simply returns task.name and getTaskStatus returns a dict of values: self.id, self.state, self.code, self.message. Aside from the data they return, these two functions seem to behave identically. If anything, this will improve performance in some cases by eliminating the need for a second API call when you also want to task verb. Am I missing something? -- To view, visit http://gerrit.ovirt.org/3613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Shireesh Anjal san...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
Igor Lvovsky has posted comments on this change. Change subject: API: Provide a working getAllTasks API .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment) Only minor comment inside. In generally as I remember the previous behaviour was: 1. poll the tasks statuses with getAllTaskStatuses because it's cheap 2. only if task finished/failed call getAllTaskInlfo Now you will call a new getAllTasks every time that is pretty expensive File vdsm/storage/task.py Line 1282: what about task id? -- To view, visit http://gerrit.ovirt.org/3613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Shireesh Anjal san...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
Bala.FA has posted comments on this change. Change subject: API: Provide a working getAllTasks API .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Shireesh Anjal san...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
Adam Litke has posted comments on this change. Change subject: API: Provide a working getAllTasks API .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Shireesh Anjal san...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Provide a working getAllTasks API
Adam Litke has posted comments on this change. Change subject: API: Provide a working getAllTasks API .. Patch Set 2: Any chance I could get some review on this? -- To view, visit http://gerrit.ovirt.org/3613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
