Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-17 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 1:

(1 comment)


File vdsm/storage/sp.py
Line 1548: activeDomains = tuple(sdUUID for sdUUID in poolDoms
Line 1549:   if poolDoms[sdUUID] == 
sd.DOM_ACTIVE_STATUS)
Line 1550: monitoredDomains = self.domainMonitor.monitoredDomains
Line 1551: 
Line 1552: for sdUUID in poolDoms:
When we invoke destroyStoragePool, it detaches master storage domain and 
updateMonitoringThreads. After detaching, master storage domain is not in 
poolDoms but it's in monitoredDomains. However in updateMonitoringThreads it 
traverses through poolDoms to seek potential monitored domains to stop, so it 
never finds master domain in poolDoms. The monitoring thread on master domain 
is not stopped, the host id lease is not released. The monitoring thread on 
master domain becomes orphan.

Attempting to detach a non-master storage domain from the pool results the 
same. After detaching, it is removed from poolDoms, but it is still in 
monitoredDomains, so updateMonitoringThreads never finds it and never stops it. 
The worst thing is it succeeds silently in this case.

I find this problem when running functional tests, this problem prevents the 
test from formatting detached storage domains and master domains.
Line 1553: if sdUUID not in activeDomains:
Line 1554: try:
Line 1555: self.domainMonitor.stopMonitoring(sdUUID)
Line 1556: self.log.debug(Storage Pool `%s` stopped 
monitoring 


-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-17 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 4:

Hi Eduardo. I find a problem in patch. Maybe we need to fix it.

-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-17 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 1:

(1 comment)


File vdsm/storage/sp.py
Line 1033: 
Line 1034: # If the domain that we are detaching is the master domain
Line 1035: # we attempt to stop the SPM before releasing the host id
Line 1036: if self.masterDomain.sdUUID == sdUUID:
Line 1037: self.stopSpm()
I add

 self.domainMonitor.stopMonitoring(sdUUID)

to this line, then the problem mentioned on line 1551 is fixed, is this OK?
Line 1038: 
Line 1039: self.updateMonitoringThreads()
Line 1040: self.log.debug(Force detach for domain `%s` is done, 
sdUUID)
Line 1041: 


-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-14 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: Adding [start|stop]MonitoringDomain().
..


Adding [start|stop]MonitoringDomain().

startMonitoringDomain() is added for monitoring a storage domain
without being connected to the pool and geting and ID for such
SD lockspace.

stopMonitoringDomain() stops the monitoring and releases the ID.

Monitoring results are gathered with repoStats().

Caveat Emptor:
SDs added to the monitor using startMonitoringDomain() should not
be part of the pool! i.e. the pool domain set and the added SDs set
should be disjoint.

Making repoStats pool independent.

Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Signed-off-by: Eduardo Warszawski ewars...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/19762
Tested-by: Sandro Bonazzola sbona...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
M vdsm_api/Bridge.py
M vdsm_api/vdsmapi-schema.json
7 files changed, 123 insertions(+), 32 deletions(-)

Approvals:
  Sandro Bonazzola: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-14 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-12 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 3:

Thanks Sandro for fixing this patch. I still cannot take it since it depends on 
a faulty patch.

-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-11 Thread sbonazzo 
Sandro Bonazzola has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 2: Verified+1

Verified with both:
 - http://gerrit.ovirt.org/20099
 - http://gerrit.ovirt.org/19867

See my previous comments about vdsClient module

-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-11 Thread sbonazzo 
Sandro Bonazzola has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 3: Verified+1

Addressed my comments as per Dan Kenigsberg request.

Verified with both:
- http://gerrit.ovirt.org/20099
- http://gerrit.ovirt.org/19867

and this patchset dependencies, rebased on master.

-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-11 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 3: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4935/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4049/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4859/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-10 Thread abaron 
Ayal Baron has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-10 Thread laravot 
Liron Ar has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-10 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 2: Code-Review-1

(1 comment)


File client/vdsClient.py
Line 1693: return 0, ''
Line 1694: 
Line 1695: def startMonitoringDomain(self, args):
Line 1696: sdUUID, hostID = args
Line 1697: self.s.startMonitoringDomain(sdUUID, hostID)
Sandro's comment has not been addressed.
Line 1698: return 0, ''
Line 1699: 
Line 1700: def stopMonitoringDomain(self, args):
Line 1701: sdUUID, = args


-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Liron Ar lara...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-07 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4750/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4826/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3941/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-07 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 1:

(1 comment)


File vdsm/storage/sp.py
Line 1545: # {sdUUID1: status1, sdUUID2: status2, ...}
Line 1546: self.invalidateMetadata()
Line 1547: poolDoms = self.getDomains()
Line 1548: activeDomains = tuple(sdUUID for sdUUID in poolDoms
Line 1549:   if poolDoms[sdUUID] == 
sd.DOM_ACTIVE_STATUS)
I think that Eduardo is saying that we must not iterate over all 
monitoredDomains, but only on those connected to the pool. Hence

  poolDoms = self.getDomains()

is required, and to avoid races (and added metadata reads), a repeated call 
with 

  activeOnly=True

should not be used.
Line 1550: monitoredDomains = self.domainMonitor.monitoredDomains
Line 1551: 
Line 1552: for sdUUID in poolDoms:
Line 1553: if sdUUID not in activeDomains:


-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-04 Thread sbonazzo 
Sandro Bonazzola has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 1:

(2 comments)


File client/vdsClient.py
Line 1694: 
Line 1695: def startMonitoringDomain(self, args):
Line 1696: sdUUID, hostID = args
Line 1697: self.s.startMonitoringDomain(sdUUID, hostID)
Line 1698: return 0, ''
Always return 0? doesn't self.s.startMonitoringDomain(sdUUID, hostID) return 
the usual dict with ['status']['code'] ?
Line 1699: 
Line 1700: def stopMonitoringDomain(self, args):
Line 1701: sdUUID, = args
Line 1702: self.s.stopMonitoringDomain(sdUUID)


Line 1698: return 0, ''
Line 1699: 
Line 1700: def stopMonitoringDomain(self, args):
Line 1701: sdUUID, = args
Line 1702: self.s.stopMonitoringDomain(sdUUID)
same here
Line 1703: return 0, ''
Line 1704: 
Line 1705: def snapshot(self, args):
Line 1706: vmUUID, sdUUID, imgUUID, baseVolUUID, volUUID = args


-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-04 Thread sbonazzo 
Sandro Bonazzola has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 1: Verified-1

Fails starting the VM for hosted engine setup after disconnecting the pool and 
calling startMonitoringDomain (http://gerrit.ovirt.org/19867)

-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-04 Thread ewarszaw 
Eduardo has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 1:

(1 comment)


File client/vdsClient.py
Line 1694: 
Line 1695: def startMonitoringDomain(self, args):
Line 1696: sdUUID, hostID = args
Line 1697: self.s.startMonitoringDomain(sdUUID, hostID)
Line 1698: return 0, ''
This is equivalent, code, msg as in other functions.
Line 1699: 
Line 1700: def stopMonitoringDomain(self, args):
Line 1701: sdUUID, = args
Line 1702: self.s.stopMonitoringDomain(sdUUID)


-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-04 Thread sbonazzo 
Sandro Bonazzola has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 1:

(1 comment)


File client/vdsClient.py
Line 1694: 
Line 1695: def startMonitoringDomain(self, args):
Line 1696: sdUUID, hostID = args
Line 1697: self.s.startMonitoringDomain(sdUUID, hostID)
Line 1698: return 0, ''
I would have expected something like:
 status = self.s.startMonitoringDomain(sdUUID, hostID)
 return status['status']['code'], status['status']['message']

with the above return 0, '' vdsClient will exit with status 0 also if the call 
fails, no?
Line 1699: 
Line 1700: def stopMonitoringDomain(self, args):
Line 1701: sdUUID, = args
Line 1702: self.s.stopMonitoringDomain(sdUUID)


-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-02 Thread abaron 
Ayal Baron has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 1:

(1 comment)


File vdsm/storage/sp.py
Line 1545: # {sdUUID1: status1, sdUUID2: status2, ...}
Line 1546: self.invalidateMetadata()
Line 1547: poolDoms = self.getDomains()
Line 1548: activeDomains = tuple(sdUUID for sdUUID in poolDoms
Line 1549:   if poolDoms[sdUUID] == 
sd.DOM_ACTIVE_STATUS)
this change does not belong here.
Line 1550: monitoredDomains = self.domainMonitor.monitoredDomains
Line 1551: 
Line 1552: for sdUUID in poolDoms:
Line 1553: if sdUUID not in activeDomains:


-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-02 Thread sgotliv 
Sergey Gotliv has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 1:

(1 comment)


File vdsm_api/vdsmapi-schema.json
Line 1723:  'returns': 'StorageDomainVitalsMap'}
Line 1724: 
Line 1725: ##
Line 1726: # @Host.startMonitorDomain:
Line 1727: #
1.It probably should be startMonitoringDomain.

2.Is stopMonitoringDomain should be documented here?
Line 1728: # Start SD monitoring with hostID
Line 1729: #
Line 1730: # @SdUUID:The Storage Domain UUID
Line 1731: #


-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-02 Thread ewarszaw 
Eduardo has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 1:

(1 comment)


File vdsm/storage/sp.py
Line 1545: # {sdUUID1: status1, sdUUID2: status2, ...}
Line 1546: self.invalidateMetadata()
Line 1547: poolDoms = self.getDomains()
Line 1548: activeDomains = tuple(sdUUID for sdUUID in poolDoms
Line 1549:   if poolDoms[sdUUID] == 
sd.DOM_ACTIVE_STATUS)
This change is required since being StoragePool.domainMonitor a pointer to a 
unique hsm instance. monitoredDomains member includes the extra-pool SDs, added 
with startMonitoringDomain. Therefore these extra pool SDs will be removed from 
the monitor with the old code, due to  the iteration over monitoredDomains.
Line 1550: monitoredDomains = self.domainMonitor.monitoredDomains
Line 1551: 
Line 1552: for sdUUID in poolDoms:
Line 1553: if sdUUID not in activeDomains:


-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-01 Thread ewarszaw 
Eduardo has uploaded a new change for review.

Change subject: Adding [start|stop]MonitoringDomain().
..

Adding [start|stop]MonitoringDomain().

startMonitoringDomain() is added for monitoring a storage domain
without being connected to the pool and geting and ID for such
SD lockspace.

stopMonitoringDomain() stops the monitoring and releases the ID.

Monitoring results are gathered with repoStats().

Caveat Emptor:
SDs added to the monitor using startMonitoringDomain() should not
be part of the pool! i.e. the pool domain set and the added SDs set
should be disjoint.

Making repoStats pool independent.

Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Signed-off-by: Eduardo ewars...@redhat.com
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
M vdsm_api/vdsmapi-schema.json
6 files changed, 105 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/19762/1

diff --git a/client/vdsClient.py b/client/vdsClient.py
index 590b1e7..6aba25e 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1692,6 +1692,16 @@
 print 'Domain %s %s' % (d, str(stats[d]))
 return 0, ''
 
+def startMonitoringDomain(self, args):
+sdUUID, hostID = args
+self.s.startMonitoringDomain(sdUUID, hostID)
+return 0, ''
+
+def stopMonitoringDomain(self, args):
+sdUUID, = args
+self.s.stopMonitoringDomain(sdUUID)
+return 0, ''
+
 def snapshot(self, args):
 vmUUID, sdUUID, imgUUID, baseVolUUID, volUUID = args
 
@@ -2466,8 +2476,16 @@
   )),
 'repoStats': (serv.repoStats,
   ('',
-   'Get the the health status of the active domains'
+   'Get the health status of the monitored domains'
)),
+'startMonitoringDomain': (serv.startMonitoringDomain,
+  ('sdUUID hostID',
+   'Start SD: sdUUID monitoring with hostID'
+   )),
+'stopMonitoringDomain': (serv.stopMonitoringDomain,
+ ('sdUUID',
+  'Stop monitoring SD: sdUUID'
+  )),
 'snapshot': (serv.snapshot,
  ('vmId sdUUID imgUUID baseVolUUID volUUID',
   'Take a live snapshot'
diff --git a/vdsm/API.py b/vdsm/API.py
index 37bb908..fa9a3ab 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1396,6 +1396,12 @@
 def getStorageRepoStats(self):
 return self._irs.repoStats()
 
+def startMonitoringDomain(self, sdUUID, hostID):
+return self._irs.startMonitoringDomain(sdUUID, hostID)
+
+def stopMonitoringDomain(self, sdUUID):
+return self._irs.stopMonitoringDomain(sdUUID)
+
 def getLVMVolumeGroups(self, storageType=None):
 return self._irs.getVGList(storageType)
 
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index fb65ad4..5dd747a 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -787,6 +787,14 @@
 api = API.Global()
 return api.getStorageRepoStats()
 
+def startMonitoringDomain(self, sdUUID, hostID, options=None):
+api = API.Global()
+return api.startMonitoringDomain(sdUUID, hostID)
+
+def stopMonitoringDomain(self, sdUUID, options=None):
+api = API.Global()
+return api.stopMonitoringDomain(sdUUID)
+
 def vgsGetList(self, storageType=None, options=None):
 api = API.Global()
 return api.getLVMVolumeGroups(storageType)
@@ -937,6 +945,8 @@
 (self.domainsGetList, 'getStorageDomainsList'),
 (self.poolsGetConnectedList, 'getConnectedStoragePoolsList'),
 (self.storageRepoGetStats, 'repoStats'),
+(self.startMonitoringDomain, 'startMonitoringDomain'),
+(self.stopMonitoringDomain, 'stopMonitoringDomain'),
 (self.vgsGetList, 'getVGList'),
 (self.devicesGetList, 'getDeviceList'),
 (self.devicesGetVisibility, 'getDevicesVisibility'),
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 4ea68ea..5f14468 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -40,6 +40,7 @@
 
 from vdsm.config import config
 import sp
+import domainMonitor
 import sd
 import blockSD
 import nfsSD
@@ -93,6 +94,8 @@
 STORAGE_CONNECTION_DIR = os.path.join(constants.P_VDSM_LIB, connections/)
 
 QEMU_READABLE_TIMEOUT = 30
+
+HSM_DOM_MON_LOCK = HsmDomainMonitorLock
 
 
 def public(f=None, **kwargs):
@@ -398,6 +401,9 @@
 name=storageRefresh)
 storageRefreshThread.daemon = True
 storageRefreshThread.start()
+
+monitorInterval = config.getint('irs', 'sd_health_check_delay')
+

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-01 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3848/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4733/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4657/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

2013-10-01 Thread ewarszaw 
Eduardo has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
..


Patch Set 1: Verified+1

More verification (with engine) is required!


[root@localhost ~]# vdsClient -s 0 getStorageDomainsList
9615bd0c-ed20-4d47-b8d9-61a06e634830
577c3957-ee57-4496-ac84-c35067e1913a
2a7fbb64-f64c-4139-ba79-aaf21547845f
eff02bb9-cea8-4f89-a077-47f36be46197

[root@localhost ~]# vdsClient -s 0 getStorageDomainInfo 
9615bd0c-ed20-4d47-b8d9-61a06e634830
uuid = 9615bd0c-ed20-4d47-b8d9-61a06e634830
vguuid = FScea1-AGv1-hwlM-dYHv-BZFb-Wit8-1ogEdM
lver = -1
state = OK
version = 3
role = Regular
pool = ['5849b030-626e-47cb-ad90-3ce782d831b3']
spm_id = -1
type = ISCSI
class = Data
master_ver = 0
name = iscsi1

[root@localhost ~]# vdsClient -s 0 getStorageDomainInfo 
2a7fbb64-f64c-4139-ba79-aaf21547845f
uuid = 2a7fbb64-f64c-4139-ba79-aaf21547845f
vguuid = fzjUA0-bfG5-UJIL-nya2-T6NI-yAOh-8w3FsC
lver = -1
state = OK
version = 3
role = Master
pool = ['0d1ef687-3b3f-4e27-89f2-69d38dc4dc22']
spm_id = -1
type = ISCSI
class = Data
master_ver = 0
name = edu1

[root@localhost ~]# vdsClient -s 0 getConnectedStoragePoolsList

[root@localhost ~]# vdsClient -s 0 repoStats

[root@localhost ~]# vdsClient -s 0 startMonitoringDomain 
9615bd0c-ed20-4d47-b8d9-61a06e634830 9

[root@localhost ~]# vdsClient -s 0 repoStats
Domain 9615bd0c-ed20-4d47-b8d9-61a06e634830 {'delay': '0.000697625', 
'lastCheck': '9.3', 'code': 0, 'valid': True, 'version': 3}

[root@localhost ~]# vdsClient -s 0 connectStoragePool 
0d1ef687-3b3f-4e27-89f2-69d38dc4dc22 4 0 2a7fbb64-f64c-4139-ba79-aaf21547845f 1

[root@localhost ~]# vdsClient -s 0 repoStats
Domain 9615bd0c-ed20-4d47-b8d9-61a06e634830 {'delay': '0.000580883', 
'lastCheck': '9.0', 'code': 0, 'valid': True, 'version': 3}
Domain 2a7fbb64-f64c-4139-ba79-aaf21547845f {'delay': '0.000485516', 
'lastCheck': '9.6', 'code': 0, 'valid': True, 'version': 3}

[root@localhost ~]# vdsClient -s 0 stopMonitoringDomain 
9615bd0c-ed20-4d47-b8d9-61a06e634830

[root@localhost ~]# vdsClient -s 0 repoStats

-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches