Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-16 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 15: Verified

Thanks, Vinzenz. I'd very much like to shed the whole cpopen code from our 
source tree. But this is stalling for long months. Having a separate sub rpm is 
a small step forward, I hope.

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-16 Thread danken
Dan Kenigsberg has submitted this change and it was merged.

Change subject: Adding cpopen as external python package to vdsm
..


Adding cpopen as external python package to vdsm

vdsm-python-cpopen is an external package for betterPopen code. This
provides as part of vdsm rpms until this package will be part of
fedora's official packages.

Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Signed-off-by: Yaniv Bronhaim 
---
M Makefile.am
M configure.ac
M lib/Makefile.am
D lib/betterPopen/setup.py
R lib/cpopen/.gitignore
R lib/cpopen/Makefile.am
R lib/cpopen/__init__.py
R lib/cpopen/cpopen.c
A lib/cpopen/setup.py
A lib/cpopen/tests.py
M lib/vdsm/utils.py
M tests/betterPopenTests.py
M tests/mountTests.py
M tests/zombieReaperTests.py
M vdsm.spec.in
M vdsm/storage/remoteFileHandler.py
16 files changed, 324 insertions(+), 52 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-16 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 15:

Well spec files aren't working on Debian based systems. They use dpkg/apt which 
means there needs to be separate packaging done.
For ubuntu you could probably use launchpad as a platform for distribution.

However so far we don't have debian packaging in our repository so there's 
little you can do for now. However when we install via autotools we can install 
cpopen even on a debian based system as needed.

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-16 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 15: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 15:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2299/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1460/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2364/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 15:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2364/ (2/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 15:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1460/ (3/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 15:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2299/ (1/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-16 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 14:

Ye, Thanks. I've just understood that. Just to clarify, when depending on this 
package (after accepting it to fedora packages) we brakes debian and other dest 
compatibilities.. Don't we?

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-16 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 14:

All packages including subpackages have to have the same version from my 
knowledge at least. If you need it to be different you'd probably have to do a 
new spec file.

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-16 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 14:

No it does not update the defines, you override the package version with 
Version: xyz

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-16 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 14:

It seems that when define the version and release attributes it changes the 
variables %{version} and %{release} to the entire spec file.  If I move the 
cpopen package definition to be the last package defined, it works well. Maybe 
its better to use vdsm version-release until we integrate with fedora packages?

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-15 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 14: Fails; No score

I cannot install vdsm-tests since it requires

 $ rpm -qpR vdsm-tests-4.10.3-0.398.git3b737d4.noarch.rpm |grep vdsm
 vdsm = 1.2.1-1

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 14: No score

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 14: Verified

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-13 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 14: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-13 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 14: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 14:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2248/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1409/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2312/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 14:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2312/ (3/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 14:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2248/ (1/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 14:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1409/ (2/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 13: Fails

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2247/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1408/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2311/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 13:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1408/ (3/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 13:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2311/ (2/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-13 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 13:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2247/ (1/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-12 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 12: (1 inline comment)


File vdsm.spec.in
Line 266: VDSM registration package. Used to register a Linux host to a 
Virtualization
Line 267: Manager.
Line 268: 
Line 269: %package python-cpopen
Line 270: Version: 1.2.1
oh, sorry. I have missed this version override. Wouldn't it make sense to 
override the release as well? Otherwise, when vdsm release is recycled, we 
theoretically can get into trouble.
Line 271: Summary: Creates a sub-process in simpler safer manner.
Line 272: 
Line 273: BuildRequires: python2-devel
Line 274: 


--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 12: (1 inline comment)


File vdsm.spec.in
Line 209: Summary:VDSM xmlrpc API
Line 210: BuildArch:  noarch
Line 211: 
Line 212: Requires: %{name}-python = %{version}-%{release}
Line 213: Requires: %{name}-python-cpopen >= 1.2.1
No.. we create vdsm-python-cpopen-1.2.1-0, as the package version in pypi. 
Older versions use different names and won't fit to vdsm calls. Although we 
still don't have vdsm-python-cpopen uploaded anywhere else, I prefer to signify 
version limitation
Line 214: 
Line 215: 
Line 216: %description xmlrpc
Line 217: An XMLRPC interface for interacting with vdsmd. Primary control 
interface for


--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-08 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 12: (1 inline comment)


File vdsm.spec.in
Line 209: Summary:VDSM xmlrpc API
Line 210: BuildArch:  noarch
Line 211: 
Line 212: Requires: %{name}-python = %{version}-%{release}
Line 213: Requires: %{name}-python-cpopen >= 1.2.1
why do you need a specific version number? and aren't we creating 
vdsm-python-cpopen-4.10.3?
Line 214: 
Line 215: 
Line 216: %description xmlrpc
Line 217: An XMLRPC interface for interacting with vdsmd. Primary control 
interface for


--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-08 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 12: Verified

No surprises :) rebase just for the rebase, and patchset 10  changed the 
requirements of cpopen in the spec file to specific version number

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-08 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 12: I would prefer that you didn't submit this

what is this surprise rebase? has anything changed here?

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-08 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 12:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1350/ (3/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-08 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 12:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2250/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2189/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1350/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-08 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 12:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2189/ (2/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-08 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 12:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2250/ (1/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-08 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 11:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2249/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2188/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1349/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-08 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 11: Verified

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-08 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 11:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2188/ (2/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-08 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 11:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2249/ (3/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-08 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 11:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1349/ (1/3)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-07 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 10: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-06 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 10:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2221/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2160/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-06 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 10:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2160/ (1/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-06 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 10:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2221/ (2/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-05 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 9:

Please notice that this requires a rebase now.

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 9: (1 inline comment)


File vdsm/storage/misc.py
Line 57: 
Line 58: from vdsm import constants
Line 59: from vdsm import utils
Line 60: import storage_exception as se
Line 61: from cpopen import CPopen as BetterPopen
after accepting this patch I'll replace all betterPopen to CPopen
Line 62: import fileUtils
Line 63: import logUtils
Line 64: 
Line 65: 


--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-05-02 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 9: I would prefer that you didn't submit this

(2 inline comments)


File lib/cpopen/Makefile.am
Line 21: cpopendir = $(pyexecdir)/cpopen
Line 22: 
Line 23: dist_cpopen_PYTHON = \
Line 24:__init__.py \
Line 25:cpopenCreateProcess.so \
cpopen.so seems a nicer name. What do you use in pipy?
Line 26:$(NULL)
Line 27: 
Line 28: cpopenCreateProcess.so: cpopenCreateProcess.c setup.py
Line 29:(cd $(srcdir); $(PYTHON) setup.py build \



File vdsm/storage/misc.py
Line 57: 
Line 58: from vdsm import constants
Line 59: from vdsm import utils
Line 60: import storage_exception as se
Line 61: from cpopen import CPopen as BetterPopen
this should follow Zhou's change to utils.py.

and I'd rather annihilate the arrogant BetterPopen name in a subsequent patch.
Line 62: import fileUtils
Line 63: import logUtils
Line 64: 
Line 65: 


--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-25 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 9: Verified

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-22 Thread smizrahi
Saggi Mizrahi has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 8: I would prefer that you didn't submit this

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-21 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 8: Verified

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 8:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2079/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2022/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 8:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2079/ (2/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 8:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2022/ (1/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 7: Fails

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2078/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2021/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 7:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2021/ (2/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 7:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2078/ (1/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 6: Fails

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2077/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2020/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2077/ (1/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2020/ (2/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 5: Fails

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2075/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2018/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2075/ (2/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2018/ (1/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-14 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 4: Fails

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2009/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1953/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-14 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2009/ (2/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-14 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1953/ (1/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 3: Fails

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1973/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1922/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1922/ (2/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1973/ (1/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 2: Fails

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1966/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1915/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1966/ (1/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Adding cpopen as external python package to vdsm

2013-04-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding cpopen as external python package to vdsm
..


Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1915/ (2/2)

--
To view, visit http://gerrit.ovirt.org/13685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic062a00d7dfc3efd8977596a04107e599ceb736a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches