Change in vdsm[master]: Allow moving of sparse images to a block domains
Dan Kenigsberg has submitted this change and it was merged. Change subject: Allow moving of sparse images to a block domains .. Allow moving of sparse images to a block domains When attempting to move a sparse image from a file domain to a block domain the destination image is created as sparse which is not supported on block domains. This patch allows to create the images preallocated on domains that do not support sparseness Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Signed-off-by: Tal Nisan Bug-Url: https://bugzilla.redhat.com/1063996 Reviewed-on: http://gerrit.ovirt.org/25778 Reviewed-by: Federico Simoncelli Reviewed-by: Allon Mureinik Reviewed-by: Dan Kenigsberg --- M vdsm/storage/image.py 1 file changed, 8 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Verified Federico Simoncelli: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, but someone else must approve Objections: Eduardo: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Dan Kenigsberg has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/25778/8/vdsm/storage/image.py File vdsm/storage/image.py: Line 357: # To avoid prezeroing preallocated volumes on NFS domains Line 358: # we create the target as a sparse volume (since it will be Line 359: # soon filled with the data coming from the copy) and then Line 360: # we change its metadata back to the original value. Line 361: if destDom.supportsSparseness: > Let me try to understand the alternative of implementing this within _creat Eduardo, I am afraid that I do not have a clear vision of the grander refactoring that you have in mind, and certainly not the manpower to implement it now. The suggested code, much like the current one, treats SD.createVolume's "preallocate=SPARSE" arg to mean "do not preallocate now". I do not see how the suggested code makes this worse. Line 362: tmpVolPreallocation = volume.SPARSE_VOL Line 363: else: Line 364: tmpVolPreallocation = volume.PREALLOCATED_VOL Line 365: -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Dan Kenigsberg has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 8: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/25778/8/vdsm/storage/image.py File vdsm/storage/image.py: Line 357: # To avoid prezeroing preallocated volumes on NFS domains Line 358: # we create the target as a sparse volume (since it will be Line 359: # soon filled with the data coming from the copy) and then Line 360: # we change its metadata back to the original value. Line 361: if destDom.supportsSparseness: > I agree about moving the logic, but I don't think it should block /this/ pa Let me try to understand the alternative of implementing this within _create(): it means having SD.createVolume() create a volume as PREALLOCATED, but not really preallocating it with zeros? Currently we have already have it as a temporary state on the image level (until content is copied during _finalizeDestinationImage(), but do we want to extend this lie to the volume level? Line 362: tmpVolPreallocation = volume.SPARSE_VOL Line 363: else: Line 364: tmpVolPreallocation = volume.PREALLOCATED_VOL Line 365: -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Allon Mureinik has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 8: Code-Review+1 (1 comment) This patch is not about canDoAction - the bug is about moving a sparse disk from file to block domain. First thing it should be supported by the underlying layer, and when that's done, the validation should be removed. http://gerrit.ovirt.org/#/c/25778/8/vdsm/storage/image.py File vdsm/storage/image.py: Line 357: # To avoid prezeroing preallocated volumes on NFS domains Line 358: # we create the target as a sparse volume (since it will be Line 359: # soon filled with the data coming from the copy) and then Line 360: # we change its metadata back to the original value. Line 361: if destDom.supportsSparseness: > This logic should be moved to .*Volume._create() functions, simplifiying t I agree about moving the logic, but I don't think it should block /this/ patch - this code has been here for a while. Let's get it to WORK, and then we can discuss how it should be refactored. Line 362: tmpVolPreallocation = volume.SPARSE_VOL Line 363: else: Line 364: tmpVolPreallocation = volume.PREALLOCATED_VOL Line 365: -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Eduardo has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 8: Code-Review-1 (2 comments) How this patch solves the canDoAction engine warning logged in the BZ? http://gerrit.ovirt.org/#/c/25778/8//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-03-24 19:21:30 +0200 Line 4: Commit: Tal Nisan Line 5: CommitDate: 2014-03-25 18:10:15 +0200 Line 6: Line 7: Allow moving of sparse images to a block domains Should be noted that this is valid for copy operations too. Line 8: Line 9: When attempting to move a sparse image from a file domain to a block domain Line 10: the destination image is created as sparse which is not supported on block Line 11: domains. http://gerrit.ovirt.org/#/c/25778/8/vdsm/storage/image.py File vdsm/storage/image.py: Line 357: # To avoid prezeroing preallocated volumes on NFS domains Line 358: # we create the target as a sparse volume (since it will be Line 359: # soon filled with the data coming from the copy) and then Line 360: # we change its metadata back to the original value. Line 361: if destDom.supportsSparseness: This logic should be moved to .*Volume._create() functions, simplifiying the logic and restore here and removing SD.createVolume() driver function. Additionally the misuse of "sparse" parameter for block volumes instead of "thin" can be clarified. Line 362: tmpVolPreallocation = volume.SPARSE_VOL Line 363: else: Line 364: tmpVolPreallocation = volume.PREALLOCATED_VOL Line 365: -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
oVirt Jenkins CI Server has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6846/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7636/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7746/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Tal Nisan has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 8: Verified+1 Verified moving all different options of format types and sparse/preallocated from file to block domain and vice versa -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Federico Simoncelli has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Tal Nisan has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/25778/7/vdsm/storage/image.py File vdsm/storage/image.py: Line 380: dstVol.extend((volParams['apparentsize'] + 511) / 512) Line 381: Line 382: # Change destination volume metadata back to the original Line 383: # type unless the domain does not supports sparseness, in Line 384: # that case leave it as preallocated > Probably you need to update the comment. Done Line 385: if volParams['prealloc'] == volume.PREALLOCATED_VOL \ Line 386: and tmpVolPreallocation != volume.PREALLOCATED_VOL: Line 387: dstVol.setType(volume.PREALLOCATED_VOL) Line 388: -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Tal Nisan has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 7: Verified+1 Verified moving all different options of format types and sparse/preallocated from file to block domain and vice versa -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Federico Simoncelli has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/25778/7/vdsm/storage/image.py File vdsm/storage/image.py: Line 380: dstVol.extend((volParams['apparentsize'] + 511) / 512) Line 381: Line 382: # Change destination volume metadata back to the original Line 383: # type unless the domain does not supports sparseness, in Line 384: # that case leave it as preallocated Probably you need to update the comment. Line 385: if volParams['prealloc'] == volume.PREALLOCATED_VOL \ Line 386: and tmpVolPreallocation != volume.PREALLOCATED_VOL: Line 387: dstVol.setType(volume.PREALLOCATED_VOL) Line 388: -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Federico Simoncelli has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Allon Mureinik has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
oVirt Jenkins CI Server has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6821/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7611/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7721/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
oVirt Jenkins CI Server has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 6: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6820/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7610/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7720/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Federico Simoncelli has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/25778/5/vdsm/storage/image.py File vdsm/storage/image.py: Line 357: # To avoid prezeroing preallocated volumes on NFS domains Line 358: # we create the target as a sparse volume (since it will be Line 359: # soon filled with the data coming from the copy) and then Line 360: # we change its metadata back to the original value. Line 361: if (destDom.supportsSparseness): No need for parentheses. Line 362: tmpVolPreallocation = volume.SPARSE_VOL Line 363: else: Line 364: tmpVolPreallocation = volume.PREALLOCATED_VOL Line 365: Line 382: # Change destination volume metadata back to the original Line 383: # type unless the domain does not supports sparseness, in Line 384: # that case leave it as preallocated Line 385: if tmpVolPreallocation != volParams['prealloc'] and \ Line 386: destDom.supportsSparseness: I think it should be: if (volParams['prealloc'] == volume.PREALLOCATED_VOL and tmpVolPreallocation != volume.PREALLOCATED_VOL): dstVol.setType(volume.PREALLOCATED_VOL) Line 387: dstVol.setType(volParams['prealloc']) Line 388: Line 389: dstChain.append(dstVol) Line 390: except se.StorageException: -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
oVirt Jenkins CI Server has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6815/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7605/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7715/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
oVirt Jenkins CI Server has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 4: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6814/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7604/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7714/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Federico Simoncelli has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 3: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/25778/3/vdsm/storage/image.py File vdsm/storage/image.py: Line 363: tmpVolPreallocation = volume.SPARSE_VOL Line 364: else: Line 365: tmpVolPreallocation = volParams['prealloc'] Line 366: else: Line 367: tmpVolPreallocation = volume.PREALLOCATED_VOL I have the feeling that the entire thing could be simplified to: if destDom.supportsSparseness: tmpVolPreallocation = volume.SPARSE_VOL else: tmpVolPreallocation = volume.PREALLOCATED_VOL Line 368: Line 369: destDom.createVolume(imgUUID=imgUUID, Line 370: size=volParams['size'], Line 371: volFormat=volParams['volFormat'], Line 383: dstVol.extend((volParams['apparentsize'] + 511) / 512) Line 384: Line 385: # Change destination volume metadata back to the original Line 386: # type. Line 387: if tmpVolPreallocation != volParams['prealloc']: You also have to handle this or we'll end up setting SPARSE_VOL on domains that doesn't support sparseness. We should probably also enforce this check in setType. Line 388: dstVol.setType(volParams['prealloc']) Line 389: Line 390: dstChain.append(dstVol) Line 391: except se.StorageException: -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
oVirt Jenkins CI Server has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7474/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6683/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7584/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Tal Nisan has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/25778/2//COMMIT_MSG Commit Message: Line 6: Line 7: Allow moving of sparse images to a block domains Line 8: Line 9: When attempting to move a sparse image from a file domain to a block domain Line 10: the destination image is created as sparse and is not supported on block > s/and is/which is/ Done Line 11: domains, this patch introduces a change that creates a the images as Line 12: preallocated on domains that do not support sparseness Line 13: Line 14: Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Line 7: Allow moving of sparse images to a block domains Line 8: Line 9: When attempting to move a sparse image from a file domain to a block domain Line 10: the destination image is created as sparse and is not supported on block Line 11: domains, this patch introduces a change that creates a the images as > s/, this patch introduces a change that creates/. This patch allows creatin Done Line 12: preallocated on domains that do not support sparseness Line 13: Line 14: Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Line 15: Signed-off-by: Tal Nisan -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Allon Mureinik has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 2: Code-Review+1 (2 comments) Seems reasonable to me. See comments on the commit message. http://gerrit.ovirt.org/#/c/25778/2//COMMIT_MSG Commit Message: Line 6: Line 7: Allow moving of sparse images to a block domains Line 8: Line 9: When attempting to move a sparse image from a file domain to a block domain Line 10: the destination image is created as sparse and is not supported on block s/and is/which is/ Line 11: domains, this patch introduces a change that creates a the images as Line 12: preallocated on domains that do not support sparseness Line 13: Line 14: Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Line 7: Allow moving of sparse images to a block domains Line 8: Line 9: When attempting to move a sparse image from a file domain to a block domain Line 10: the destination image is created as sparse and is not supported on block Line 11: domains, this patch introduces a change that creates a the images as s/, this patch introduces a change that creates/. This patch allows creating/ Line 12: preallocated on domains that do not support sparseness Line 13: Line 14: Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Line 15: Signed-off-by: Tal Nisan -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
oVirt Jenkins CI Server has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7463/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6672/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7573/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
oVirt Jenkins CI Server has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7462/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6671/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7572/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Tal Nisan has uploaded a new change for review. Change subject: Allow moving of sparse images to a block domains .. Allow moving of sparse images to a block domains When attempting to move a sparse image from a file domain to a block domain the destination image is created as sparse and is not supported on block domains, this patch introduces a change that creates a the images as preallocated on domains that do not support sparseness Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Signed-off-by: Tal Nisan Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063996 --- M vdsm/storage/image.py 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/25778/1 diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py index b08ecca..341c312 100644 --- a/vdsm/storage/image.py +++ b/vdsm/storage/image.py @@ -358,11 +358,13 @@ # we create the target as a sparse volume (since it will be # soon filled with the data coming from the copy) and then # we change its metadata back to the original value. -if (volParams['prealloc'] == volume.PREALLOCATED_VOL -and destDom.supportsSparseness): -tmpVolPreallocation = volume.SPARSE_VOL +if (destDom.supportsSparseness): +if (volParams['prealloc'] == volume.PREALLOCATED_VOL): +tmpVolPreallocation = volume.SPARSE_VOL +else: +tmpVolPreallocation = volParams['prealloc'] else: -tmpVolPreallocation = volParams['prealloc'] +tmpVolPreallocation = volume.PREALLOCATED_VOL destDom.createVolume(imgUUID=imgUUID, size=volParams['size'], -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
