Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
Dan Kenigsberg has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 4: Looks good to me, approved Copy Ayal's ack of patchset 3. -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. BZ#840407 - Create a fake template when moving to backup SD. This code is repeated twice because the copy in deprecated moveMultipleImages() will be removed when this image will be removed in the next version. All the related fake template code should be removed. Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Signed-off-by: Eduardo --- M vdsm/storage/hsm.py 1 file changed, 31 insertions(+), 3 deletions(-) Approvals: Daniel Paikov: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 4: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1190/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1225/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/336/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
Daniel Paikov has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/336/ (3/3) -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1225/ (2/3) -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1190/ (1/3) -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
Ayal Baron has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/992/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1027/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/138/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/138/ (1/3) -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1027/ (2/3) -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/992/ (3/3) -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 2: Fails; I would prefer that you didn't submit this Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/972/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1007/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/118/ : FAILURE -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/118/ (3/3) -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/972/ (2/3) -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1007/ (1/3) -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
Dan Kenigsberg has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 1: I would prefer that you didn't submit this it is not very surprising that a patch that has been idle for 5 months does not apply to master branch. -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
Ayal Baron has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
Eyal Edri has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 1: any update on pushing this patch? -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Moran Goldboim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
Daniel Paikov has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
Dan Kenigsberg has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 1: (1 inline comment) File vdsm/storage/hsm.py Line 1338: pool = self.getPool(spUUID) #Validates that the pool is connected. WHY? I would have found the code clearer if you would have created the fake template here, before calling validateImageMove? Are we sure that when we ignore ImageDoesNotExistInSD, the ImageMove is valid? -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
Dan Kenigsberg has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments) Commit Message Line 11: removed in the next version. I do not understand why this is a good excuse to writing the code twice now. It is hard to believe, but even your code has a chance of being buggy. Fixing it in two places does not seem very safe. File vdsm/storage/hsm.py Line 1316: e.absentTemplateUUID = tName python allows dynamic types, but I find it a bad practice. I'd prefer to have another exception type. Also, storage exceptions should fill in self.args like any sane Exception. Not sure if this should happen here and now. -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
Eduardo has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 1: (1 inline comment) File vdsm/storage/hsm.py Line 1346: tName = e.absentTemplateUUID validateImageMove() is used only in this two functions and in all the call flow this exception can't be raise except this way. In addition the exception instance was modified then if the missing template extra attributes exist the exception was raised in validateImageMove(). -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
Ayal Baron has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 1: (2 inline comments) Commit Message Line 12: All the related fake template code should be removed. this sentence is redundant and out of context. File vdsm/storage/hsm.py Line 1346: tName = e.absentTemplateUUID you're assuming that only missing template would throw this exception. Although correct for current implementation, the exception is generic and might be reused... -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
Eduardo has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. Patch Set 1: (1 inline comment) Commit Message Line 10: moveMultipleImages() will be removed when this image will be s/image/function -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Igor Lvovsky ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.
Eduardo has uploaded a new change for review. Change subject: BZ#840407 - Create a fake template when moving to backup SD. .. BZ#840407 - Create a fake template when moving to backup SD. This code is repeated twice because the copy in deprecated moveMultipleImages() will be removed when this image will be removed in the next version. All the related fake template code should be removed. Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Signed-off-by: Eduardo --- M vdsm/storage/hsm.py 1 file changed, 26 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/6519/1 -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
