Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
Jenkins CI RO has abandoned this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/6822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Omri Hochman Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
Jenkins CI RO has posted comments on this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Patch Set 7: Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/6822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Omri Hochman Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
automat...@ovirt.org has posted comments on this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/6822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Omri Hochman Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
Nir Soffer has posted comments on this change.
Change subject: BZ#844656 Release the _syncroot lock during _findDomain
..
Patch Set 7:
(2 comments)
http://gerrit.ovirt.org/#/c/6822/7/vdsm/storage/sdc.py
File vdsm/storage/sdc.py:
Line 59:
Line 60: def __init__(self, storage_repo):
Line 61: # Acquire order: self._syncProxyCache, self._syncDomainCache
Line 62: self._syncProxyCache = threading.Lock()
Line 63: self._syncDomainCache = threading.Condition(threading.Lock())
This names are little confusing. None of these caches, and they are not the
same type of object - one a lock, the other a condition.
Seems that they should be named:
self._proxyCahceLock
self._domainCacheCond
Line 64:
Line 65: self.__proxyCache = {}
Line 66: self.__domainCache = {}
Line 67: self.__inProgress = set()
Line 78: lvm.invalidateCache()
Line 79: self.storageStale = False
Line 80:
Line 81: # This must be accessed holding the _syncProxyCache lock
Line 82: def __getDomainFromCache(self, sdUUID):
Maybe name this __getDomainFromCacheUnlocked to make it more clear that it must
be locked? Same for __cleanStaleWeakrefs.
Line 83: if self.storageStale == True:
Line 84: return None
Line 85: try:
Line 86: return self.__proxyCache[sdUUID]()
--
To view, visit http://gerrit.ovirt.org/6822
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Eduardo
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Omri Hochman
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
Itamar Heim has posted comments on this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Patch Set 7: and? ping -- To view, visit http://gerrit.ovirt.org/6822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Omri Hochman Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
Federico Simoncelli has restored this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Restored I remember this as being pretty nice to have. -- To view, visit http://gerrit.ovirt.org/6822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Omri Hochman Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
Itamar Heim has abandoned this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Abandoned abandoning per no reply. please restore if still relevant. -- To view, visit http://gerrit.ovirt.org/6822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Omri Hochman Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
Itamar Heim has posted comments on this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Patch Set 7: ping -- To view, visit http://gerrit.ovirt.org/6822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Omri Hochman Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
Dan Kenigsberg has posted comments on this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Patch Set 7: Code-Review-1 Indeed, after a year, a rebase is welcome. -- To view, visit http://gerrit.ovirt.org/6822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Omri Hochman Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
Saggi Mizrahi has posted comments on this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Patch Set 7: Should this be abandoned? It still looks good but I wonder if a rebase and a retest is in order. -- To view, visit http://gerrit.ovirt.org/6822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Omri Hochman Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Patch Set 7: Build Successful http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/41/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/6822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Omri Hochman Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
oVirt Jenkins CI Server has posted comments on this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Patch Set 7: No score Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/41/ -- To view, visit http://gerrit.ovirt.org/6822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Omri Hochman Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
Omri Hochman has posted comments on this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/6822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Omri Hochman Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
Saggi Mizrahi has posted comments on this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain
Saggi Mizrahi has posted comments on this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8088d5fe716a3a08c3e5cef2d2d9a654ee96f60a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
