Change in vdsm[master]: Move zombieReaper to its own package

2013-10-28 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: Move zombieReaper to its own package
..


Move zombieReaper to its own package

It is not vdsm specific so it's a prime candidate for extraction.

Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Signed-off-by: Saggi Mizrahi 
Reviewed-on: http://gerrit.ovirt.org/19253
Reviewed-by: Dan Kenigsberg 
Tested-by: Dan Kenigsberg 
---
M configure.ac
M lib/Makefile.am
A lib/zombiereaper/Makefile.am
R lib/zombiereaper/__init__.py
R lib/zombiereaper/tests.py
M tests/Makefile.am
M tests/testrunner.py
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/storage/remoteFileHandler.py
M vdsm/vdsm
11 files changed, 62 insertions(+), 16 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-10-28 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 8: Verified+1 Code-Review+2

Oh, I've missed that `make check` still runs the zombiereaper tests. You could 
have said so as a response to the my comment on the previous round of reviews!

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-10-28 Thread smizrahi 
Saggi Mizrahi has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 8:

I don't understand. We keep running them.
I added check-local entry in the makefile

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-10-28 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 8:

(A comment beginning with "we should not test zr because..." may be a valid one)

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-10-28 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 8: Code-Review-1

Any comment about my suggestion to keep running the zombiereaper tests?

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-10-27 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 8: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5102/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4298/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5176/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/750/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-10-13 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 7:

Generally I agree. Next to go is creating separate package as you say.. but 
lets start from first step which is that patch

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-10-13 Thread smizrahi 
Saggi Mizrahi has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 7:

No I don't have any work for putting it outside. My main concern is to pull 
infra code to lib so that we don't get assigned other people's bugs. Even if 
things remain VDSM specific putting them outside vdsm/ is better to declare 
layering.

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-10-10 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 7: Code-Review-1

(1 comment)

if the module is to be taken off, it should probably be named in all-lowercase, 
right?

Do you have a work-in-progress for putting this independently on pypi/Fedora?


File lib/zombieReaper/tests.py
Line 20: from time import sleep
Line 21: import os
Line 22: 
Line 23: import zombieReaper
Line 24: from cpopen import CPopen as BetterPopen
could you keep a symlink in the original location, or otherwise keep this test 
to be running until you peel this package off of vdsm?
Line 25: 
Line 26: from unittest import TestCase
Line 27: 
Line 28: zombieReaper.registerSignalHandler()


-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-10-09 Thread abaron 
Ayal Baron has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 7: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-10-08 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 7: Code-Review+1

CentOS slave build fail seems not related to this patch [1]. I see all recent 
build on CentOS slave failed [2]. It seems the official CentOS repo does not 
contain the latest packages we require.

 [1] 
http://jenkins.ovirt.org/job/vdsm_install_rpm_sanity_gerrit/label=centos64/141/console
 [2] http://jenkins.ovirt.org/job/vdsm_install_rpm_sanity_gerrit/label=centos64/

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-10-08 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 7: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-10-08 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 7: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4759/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4835/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3950/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_install_rpm_sanity_gerrit/141/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-10-07 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 6: Code-Review-1

(1 comment)

only tiny little thing..


File vdsm.spec.in
Line 97: Requires: python-netaddr
Line 98: Requires: python-inotify
Line 99: Requires: python-argparse
Line 100: Requires: python-ethtool >= 0.6-3
Line 101: Requires: vdsm-python-zombiereaper = %{version}-%{release}
use %{name}
Line 102: Requires: rpm-python
Line 103: Requires: nfs-utils
Line 104: Requires: m2crypto
Line 105: Requires: libguestfs-tools-c


-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-10-06 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 6:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4720/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4796/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3911/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-30 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 5:

right, just wanted to have python prefix after vdsm: vdsm-python-[package-name] 
so when we want to add it externally to vdsm it will be called 
python-[package-name]
any objections for that? I guess this what Zhou meant also

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-30 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 5:

right

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-30 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 5:

right, just wanted to have python prefix after vdsm - vdsm-python-

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-29 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 5:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3791/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4676/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4600/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-29 Thread smizrahi 
Saggi Mizrahi has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 4:

As long as it's a VDSM subpackage it'll have to have the vdsm-zombiereaper 
prefix.

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-28 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 4: Code-Review-1

Please change to python-zombiereaper as python-cpopen, and we're good to go. 
About "making it public" argument, IMHO we should open a bz on that and 
continue talking about its need there.

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-28 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 4:

I dislike the concept of the zombie reaper. In general, whomever starts a 
process should take notice whether it ends and how. Thus I am not proud to 
publicize it as a top level package. But I do not oppose this patch either, 
just wider if you have an out-of-vdsm use case for it.

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-24 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 4:

Since we already have vdsm-python-cpopen, I think vdsm-python-zombiereaper is a 
better name. For other part of the patch I +1.

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-24 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 4: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-24 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4614/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4536/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3729/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-24 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 3: Code-Review+1

(2 comments)


File vdsm.spec.in
Line 282: 
Line 283: %description yajsonrpc
Line 284: A JSON RPC server and client implementation.
Line 285: 
Line 286: %package zombiereaper
I think better having python prefix here - python-zombiereaper
Line 287: Summary:Collects zombie processes automatically
Line 288: BuildArch:  noarch
Line 289: 
Line 290: Requires:   python >= 2.6


Line 289: 
Line 290: Requires:   python >= 2.6
Line 291: 
Line 292: %description zombiereaper
Line 293: Collects zombie processes automatically so you don't have to
s\"so you don't have to"\"without manual intervention"
Line 294: 
Line 295: %package bootstrap
Line 296: Summary:VDSM bootstrapping package
Line 297: BuildArch:  noarch


-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-24 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4591/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4513/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3706/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-15 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 2:

(1 comment)


File lib/zombieReaper/Makefile.am
Line 21: zombiereaperdir = $(pythondir)/zombieReaper
Line 22: 
Line 23: dist_zombiereaper_PYTHON = \
Line 24:__init__.py \
Line 25:$(NULL)
I think it's better if we have a "check-local" target to run tests.py. I find  
in lib/cpopen/Makefile.am we use nosetest for unit test. Here we can do the 
same and add nosetest to build requirements.


-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-15 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4447/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3550/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4366/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-15 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 1: Code-Review+1

thanks!

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-15 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move zombieReaper to its own package
..


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4442/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3545/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4361/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move zombieReaper to its own package

2013-09-15 Thread smizrahi 
Saggi Mizrahi has uploaded a new change for review.

Change subject: Move zombieReaper to its own package
..

Move zombieReaper to its own package

It is not vdsm specific so it's a prime candidate for extraction.

Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Signed-off-by: Saggi Mizrahi 
---
M configure.ac
M lib/Makefile.am
A lib/zombieReaper/Makefile.am
R lib/zombieReaper/__init__.py
R lib/zombieReaper/tests.py
M tests/Makefile.am
M vdsm.spec.in
M vdsm/Makefile.am
8 files changed, 45 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/19253/1

diff --git a/configure.ac b/configure.ac
index 93b6b96..b6032f8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -256,6 +256,7 @@
lib/vdsm/Makefile
lib/vdsm/tool/Makefile
lib/yajsonrpc/Makefile
+   lib/zombieReaper/Makefile
tests/Makefile
tests/functional/Makefile
vds_bootstrap/Makefile
diff --git a/lib/Makefile.am b/lib/Makefile.am
index b1a1a12..08a9e60 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -19,4 +19,4 @@
 #
 include $(top_srcdir)/build-aux/Makefile.subs
 
-SUBDIRS = vdsm cpopen yajsonrpc
+SUBDIRS = vdsm cpopen yajsonrpc zombieReaper
diff --git a/lib/zombieReaper/Makefile.am b/lib/zombieReaper/Makefile.am
new file mode 100644
index 000..595f17f
--- /dev/null
+++ b/lib/zombieReaper/Makefile.am
@@ -0,0 +1,26 @@
+#
+# Copyright 2008-2011 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+zombiereaperdir = $(pythondir)/zombieReaper
+
+dist_zombiereaper_PYTHON = \
+   __init__.py \
+   $(NULL)
+
diff --git a/vdsm/zombieReaper.py b/lib/zombieReaper/__init__.py
similarity index 100%
rename from vdsm/zombieReaper.py
rename to lib/zombieReaper/__init__.py
diff --git a/tests/zombieReaperTests.py b/lib/zombieReaper/tests.py
similarity index 92%
rename from tests/zombieReaperTests.py
rename to lib/zombieReaper/tests.py
index ff5c641..be819ee 100644
--- a/tests/zombieReaperTests.py
+++ b/lib/zombieReaper/tests.py
@@ -20,12 +20,15 @@
 from time import sleep
 import os
 
-from testrunner import VdsmTestCase as TestCaseBase
 import zombieReaper
 from cpopen import CPopen as BetterPopen
 
+from unittest import TestCase
 
-class zombieReaperTests(TestCaseBase):
+zombieReaper.registerSignalHandler()
+
+
+class zombieReaperTests(TestCase):
 def testProcessDiesAfterBeingTracked(self):
 p = BetterPopen(["sleep", "1"])
 zombieReaper.autoReapPID(p.pid)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 248f2b4..5f1f1da 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -63,7 +63,6 @@
utilsTests.py \
vdsClientTests.py \
volumeTests.py \
-   zombieReaperTests.py \
$(NULL)
 
 nodist_vdsmtests_PYTHON = \
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 237be46..f66c3bd 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -283,6 +283,15 @@
 %description yajsonrpc
 A JSON RPC server and client implementation.
 
+%package zombiereaper
+Summary:Collects zombie processes automatically
+BuildArch:  noarch
+
+Requires:   python >= 2.6
+
+%description zombiereaper
+Collects zombie processes automatically so you don't have to
+
 %package bootstrap
 Summary:VDSM bootstrapping package
 BuildArch:  noarch
@@ -841,7 +850,6 @@
 %{_datadir}/%{vdsm_name}/vdsm-restore-net-config
 %{_datadir}/%{vdsm_name}/vdsm-store-net-config
 %{_datadir}/%{vdsm_name}/vm.py*
-%{_datadir}/%{vdsm_name}/zombieReaper.py*
 %config(noreplace) %{_sysconfdir}/%{vdsm_name}/logger.conf
 %config(noreplace) %{_sysconfdir}/%{vdsm_name}/svdsm.logger.conf
 %config(noreplace) %{_sysconfdir}/%{vdsm_name}/mom.conf
@@ -1235,6 +1243,9 @@
 %{python_sitelib}/yajsonrpc/protonReactor.py*
 %{python_sitelib}/yajsonrpc/client.py*
 
+%files zombiereaper
+%{python_sitelib}/zombieReaper/__init__.py*
+
 %files bootstrap
 %defattr(-, root, root, -)
 %doc COPYING
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index cd78cd8..69d59d9 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -53,7 +53,6 @@
vdsmDebugPlugin.py \
vmChannels.py \
vm.py \
-   zombieReaper.py \
$(NULL)
 
 dist_vdsmex