Change in vdsm[master]: Moving coredump configuration to common script

2013-10-13 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 10: Verified-1

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-13 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 11: Verified+1

Now it works :)

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-13 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: Moving coredump configuration to common script
..


Moving coredump configuration to common script

Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/19889
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M init/systemd/vdsmd.service.in
M init/sysvinit/vdsmd.init.in
M init/vdsmd_init_common.sh.in
M vdsm/vdsm
4 files changed, 24 insertions(+), 15 deletions(-)

Approvals:
  Yaniv Bronhaim: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-13 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 11: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-13 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 10:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4949/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4063/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4873/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-13 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 11:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4951/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4065/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4875/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-10 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 7:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4890/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4005/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4815/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-10 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 7: Verified+1

sorry for the rebasing once again ..

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-10 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 7: Code-Review+2

(1 comment)


File init/sysvinit/vdsmd.init.in
Line 121: start_needed_srv ${NEEDED_SERVICES} || return 1
Line 122: ${VDSMD_INIT_COMMON} --pre-start || return 1
Line 123: 
Line 124: echo $Starting up vdsm daemon: 
Line 125: DAEMON_COREFILE_LIMIT=unlimited NICELEVEL=${NICE_LOWEST} daemon 
--user=vdsm @VDSMDIR@/daemonAdapter \
frankly, I would have preferred breaking this long line.
Line 126: -0 /dev/null -1 /dev/null -2 /dev/null --syslog 
@VDSMDIR@/respawn --minlifetime 10 \
Line 127: --daemon --masterpid ${RESPAWNPIDFILE} ${VDSM_BIN} 
--pidfile ${PIDFILE} || return 1
Line 128: touch ${LOCK_FILE}
Line 129: return 0


-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-10 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 8: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-10 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 8:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4912/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4027/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4837/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-10 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 9:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4919/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4034/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4844/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-10 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 9: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-09 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4785/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4861/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3976/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-09 Thread Alon Bar-Lev 
Alon Bar-Lev has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 4: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-09 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 5:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4792/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4868/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3983/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-09 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 6:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4802/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4878/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3993/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-09 Thread Alon Bar-Lev 
Alon Bar-Lev has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 6: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-08 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4767/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4843/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3958/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-08 Thread Alon Bar-Lev 
Alon Bar-Lev has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 3: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-07 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4728/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4804/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3919/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-07 Thread Alon Bar-Lev 
Alon Bar-Lev has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 2:

(2 comments)


File init/daemonAdapter
Line 67: def execute(self):
Line 68: try:
Line 69: self._parse_args()
Line 70: os.nice(config.getint('vars', 'vdsm_nice'))
Line 71: if os.environ['COREDUMP_ENABLED']:
this value is not reaching here.
Line 72: resource.setrlimit(resource.RLIMIT_CORE, 0)
Line 73: 
Line 74: env = os.environ.copy()
Line 75: env.update({



File init/vdsmd_init_common.sh.in
Line 27: local getconfitem=@VDSMDIR@/get-conf-item
Line 28: 
Line 29: if ${getconfitem} ${conf_file} vars core_dump_enable false |
Line 30:   tr A-Z a-z | grep -q true; then
Line 31: export COREDUMP_ENABLED=True
this is not go into the damaemon anyway... just remove.
Line 32: echo /var/log/core/core.%p.%t.dump  
/proc/sys/kernel/core_pattern
Line 33: fi
Line 34: }
Line 35: 


-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-06 Thread ybronhei 
Yaniv Bronhaim has uploaded a new change for review.

Change subject: Moving coredump configuration to common script
..

Moving coredump configuration to common script

Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M init/systemd/vdsmd.service.in
M init/sysvinit/vdsmd.init.in
M init/vdsmd_init_common.sh.in
3 files changed, 15 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/19889/1

diff --git a/init/systemd/vdsmd.service.in b/init/systemd/vdsmd.service.in
index f14ec17..94be97a 100644
--- a/init/systemd/vdsmd.service.in
+++ b/init/systemd/vdsmd.service.in
@@ -6,6 +6,7 @@
 
 [Service]
 Type=simple
+LimitCORE=infinity
 EnvironmentFile=-/etc/sysconfig/vdsm
 ExecStartPre=@LIBEXECDIR@/vdsmd_init_common.sh --pre-start
 ExecStart=@VDSMDIR@/daemonAdapter -0 /dev/null -1 /dev/null -2 /dev/null 
@VDSMDIR@/vdsm
diff --git a/init/sysvinit/vdsmd.init.in b/init/sysvinit/vdsmd.init.in
index 5ccdc3d..2fb4d0d 100755
--- a/init/sysvinit/vdsmd.init.in
+++ b/init/sysvinit/vdsmd.init.in
@@ -22,13 +22,9 @@
 ### END INIT INFO
 
 VDSM_BIN=@VDSMDIR@/vdsm
-CONF_FILE=@CONFDIR@/vdsm.conf
-GETCONFITEM=@VDSMDIR@/get-conf-item
 prog=vdsm
 PIDFILE=@VDSMRUNDIR@/vdsmd.pid
 RESPAWNPIDFILE=@VDSMRUNDIR@/respawn.pid
-CORE_DUMP_PATH=/var/log/core/core.%p.%t.dump
-CORE_PATTERN=/proc/sys/kernel/core_pattern
 NEEDED_SERVICES=iscsid multipathd rpcbind ntpd wdmd sanlock network libvirtd
  supervdsmd
 CONFLICTING_SERVICES=libvirt-guests ksmtuned
@@ -37,9 +33,6 @@
 NICE_LOWEST=-20
 VDSMD_INIT_COMMON=@LIBEXECDIR@/vdsmd_init_common.sh
 RETVAL=0
-
-is_coredump=$(${GETCONFITEM} ${CONF_FILE} vars core_dump_enable false | 
tr A-Z a-z)
-[ ${is_coredump} != true ]  is_coredump=false
 
 SYSTEMCTL_SKIP_REDIRECT=true
 
@@ -122,10 +115,6 @@
 start() {
 test_already_running  return 0
 
-if [ ${is_coredump} = true ]; then
-export DAEMON_COREFILE_LIMIT=unlimited
-echo ${CORE_DUMP_PATH}  ${CORE_PATTERN}
-fi
 shutdown_conflicting_srv ${CONFLICTING_SERVICES} || return 1
 start_needed_srv ${NEEDED_SERVICES} || return 1
 ${VDSMD_INIT_COMMON} --pre-start || return 1
diff --git a/init/vdsmd_init_common.sh.in b/init/vdsmd_init_common.sh.in
index f81589c..33094a0 100644
--- a/init/vdsmd_init_common.sh.in
+++ b/init/vdsmd_init_common.sh.in
@@ -20,9 +20,22 @@
 
 VDSM_TOOL=@BINDIR@/vdsm-tool
 prog=vdsm
+CONF_FILE=@CONFDIR@/vdsm.conf
+GETCONFITEM=@VDSMDIR@/get-conf-item
+CORE_DUMP_PATH=/var/log/core/core.%p.%t.dump
+CORE_PATTERN=/proc/sys/kernel/core_pattern
 
+is_coredump=$(${GETCONFITEM} ${CONF_FILE} vars core_dump_enable false | 
tr A-Z a-z)
+[ ${is_coredump} != true ]  is_coredump=false
 
  pre-start tasks 
+task_configure_coredump() {
+if [ ${is_coredump} = true ]; then
+export DAEMON_COREFILE_LIMIT=unlimited
+echo ${CORE_DUMP_PATH}  ${CORE_PATTERN}
+fi
+}
+
 task_run_init_hooks(){
 @PYTHON@ @VDSMDIR@/hooks.pyc before_vdsm_start
 }
@@ -206,6 +219,7 @@
 case $1 in
 --pre-start)
 run_tasks  \
+configure_coredump \
 run_init_hooks \
 gencerts \
 check_libvirt_configure \


-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-06 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4715/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4791/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3906/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-06 Thread Alon Bar-Lev 
Alon Bar-Lev has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 1:

(1 comment)


File init/vdsmd_init_common.sh.in
Line 30: 
Line 31:  pre-start tasks 
Line 32: task_configure_coredump() {
Line 33: if [ ${is_coredump} = true ]; then
Line 34: export DAEMON_COREFILE_LIMIT=unlimited
this export has no sense here, it should be done at the init.d script.
Line 35: echo ${CORE_DUMP_PATH}  ${CORE_PATTERN}
Line 36: fi
Line 37: }
Line 38: 


-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Moving coredump configuration to common script

2013-10-06 Thread Alon Bar-Lev 
Alon Bar-Lev has posted comments on this change.

Change subject: Moving coredump configuration to common script
..


Patch Set 1:

if coredump is false we should disable it using rlimit in the initAdapter.

-- 
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches