Change in vdsm[master]: Network functional tests assertion improvements

2013-10-31 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 8: -Verified

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5065/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/756/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-31 Thread asegurap 
Antoni Segura Puimedon has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 8: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-31 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: Network functional tests assertion improvements
..


Network functional tests assertion improvements

This change allows for more fine grained assertion errors. It allows
, among other things, to differentiate if what failed is making a
net or putting it into the running configuration.

Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/20123
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M tests/functional/networkTests.py
M tests/functional/utils.py
M tests/testrunner.py
3 files changed, 196 insertions(+), 167 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-31 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 8: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-25 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 8: Code-Review+1

Toni, do you understand why this fails on el6?

-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-24 Thread asegurap 
Antoni Segura Puimedon has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 6: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-24 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 6: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5048/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4244/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5122/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/729/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-24 Thread asegurap 
Antoni Segura Puimedon has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 7: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-24 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 7: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5050/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4246/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5124/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/731/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-24 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 8: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5065/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4261/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5139/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/737/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-23 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 5: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5029/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4225/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5103/ : ABORTED

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/717/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-11 Thread asegurap 
Antoni Segura Puimedon has uploaded a new change for review.

Change subject: Network functional tests assertion improvements
..

Network functional tests assertion improvements

This change allows for more fine grained assertion errors. It allows
, among other things, to differentiate if what failed is making a
net or putting it into the running configuration.

Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M tests/functional/networkTests.py
M tests/functional/utils.py
2 files changed, 162 insertions(+), 160 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/20123/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index b85c3d5..304a01d 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -163,10 +163,10 @@
   {})
 self.assertEqual(status, SUCCESS, msg)
 for vlan_net in network_names:
-self.assertTrue(self.vdsm_net.networkExists(vlan_net, bridged))
-self.assertTrue(self.vdsm_net.bondExists(BONDING_NAME, nics))
-self.assertTrue(self.vdsm_net.vlanExists(BONDING_NAME + '.' +
-networks[vlan_net]['vlan']))
+self.vdsm_net.assertNetworkExists(vlan_net, bridged)
+self.vdsm_net.assertBondExists(BONDING_NAME, nics)
+self.vdsm_net.assertVlanExists(BONDING_NAME + '.' +
+   networks[vlan_net]['vlan'])
 
 with self.vdsm_net.pinger():
 for vlan_net in network_names:
@@ -174,11 +174,9 @@
 {vlan_net: {'remove': True}},
 {BONDING_NAME: {'remove': True}}, {})
 self.assertEqual(status, SUCCESS, msg)
-self.assertFalse(self.vdsm_net.networkExists(vlan_net,
- bridged))
-self.assertFalse(
-self.vdsm_net.vlanExists(BONDING_NAME + '.' +
- networks[vlan_net]['vlan']))
+self.vdsm_net.assertNetworkDoesntExist(vlan_net)
+self.vdsm_net.assertVlanDoesntExist(
+BONDING_NAME + '.' + networks[vlan_net]['vlan'])
 
 @cleanupNet
 @permutations([[True], [False]])
@@ -192,15 +190,15 @@
 {'bonding': BONDING_NAME, 'bridged': bridged}},
 {BONDING_NAME: {'nics': nics, 'options': 'mode=2'}}, {})
 self.assertEqual(status, SUCCESS, msg)
-self.assertTrue(self.vdsm_net.networkExists(NETWORK_NAME, bridged))
-self.assertTrue(self.vdsm_net.bondExists(BONDING_NAME, nics))
+self.vdsm_net.assertNetworkExists(NETWORK_NAME, bridged)
+self.vdsm_net.assertBondExists(BONDING_NAME, nics)
 
 with self.vdsm_net.pinger():
 status, msg = self.vdsm_net.setupNetworks(
 {NETWORK_NAME: {'remove': True}},
 {BONDING_NAME: {'remove': True}}, {})
 self.assertEqual(status, SUCCESS, msg)
-self.assertFalse(self.vdsm_net.networkExists(NETWORK_NAME))
+self.vdsm_net.assertNetworkDoesntExist(NETWORK_NAME)
 
 @cleanupNet
 @permutations([[True], [False]])
@@ -214,7 +212,7 @@
 {BONDING_NAME: {'nics': nics}},
 {'connectivityCheck': False})
 self.assertEqual(status, SUCCESS, msg)
-self.assertTrue(self.vdsm_net.bondExists(BONDING_NAME, nics))
+self.vdsm_net.assertBondExists(BONDING_NAME, nics)
 
 with nonChangingOperstate(BONDING_NAME):
 status, msg = self.vdsm_net.setupNetworks(
@@ -223,19 +221,32 @@
  'vlan': VLAN_ID}},
 {}, {'connectivityCheck': False})
 self.assertEqual(status, SUCCESS, msg)
-self.assertTrue(self.vdsm_net.networkExists(NETWORK_NAME, bridged))
+self.vdsm_net.assertNetworkExists(NETWORK_NAME, bridged)
 
 status, msg = self.vdsm_net.setupNetworks(
 {NETWORK_NAME: {'remove': True},
  NETWORK_NAME + '0': {'remove': True}},
 {}, {'connectivityCheck': False})
 self.assertEqual(status, SUCCESS, msg)
-self.assertTrue(self.vdsm_net.bondExists(BONDING_NAME, nics))
+self.vdsm_net.assertBondExists(BONDING_NAME, nics)
 
 status, msg = self.vdsm_net.setupNetworks(
 {},
 {BONDING_NAME: {'remove': True}}, {'connectivityCheck': False})
 self.assertEqual(status, SUCCESS, msg)
+
+def assertNetworkExists(self, networkName, bridged=None):
+

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-11 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 1: Code-Review-1

(3 comments)


File tests/functional/networkTests.py
Line 234: {},
Line 235: {BONDING_NAME: {'remove': True}}, 
{'connectivityCheck': False})
Line 236: self.assertEqual(status, SUCCESS, msg)
Line 237: 
Line 238: def assertNetworkExists(self, networkName, bridged=None):
do we need this defined both here and in utils? I prefer to have it here due to 
the delicate differences between self.assertTrue and the 'assert' statement 
that you use in utils.
Line 239: self.assert_(networkName in self.vdsm_net.netinfo.networks)
Line 240: if bridged:
Line 241: self.assertEqual(
Line 242: bridged,


Line 235: {BONDING_NAME: {'remove': True}}, 
{'connectivityCheck': False})
Line 236: self.assertEqual(status, SUCCESS, msg)
Line 237: 
Line 238: def assertNetworkExists(self, networkName, bridged=None):
Line 239: self.assert_(networkName in self.vdsm_net.netinfo.networks)
isn't assert_ an undocumented assertTrue? Do you find it nicer?
Line 240: if bridged:
Line 241: self.assertEqual(
Line 242: bridged,
Line 243: 
self.vdsm_net.netinfo.networks[networkName]['bridged'])


Line 236: self.assertEqual(status, SUCCESS, msg)
Line 237: 
Line 238: def assertNetworkExists(self, networkName, bridged=None):
Line 239: self.assert_(networkName in self.vdsm_net.netinfo.networks)
Line 240: if bridged:
if bridge is not None
Line 241: self.assertEqual(
Line 242: bridged,
Line 243: 
self.vdsm_net.netinfo.networks[networkName]['bridged'])
Line 244: if self.vdsm_net.config is not None:


-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-11 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 1: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4940/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4054/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4864/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/684/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-11 Thread asegurap 
Antoni Segura Puimedon has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 1:

(1 comment)


File tests/functional/networkTests.py
Line 234: {},
Line 235: {BONDING_NAME: {'remove': True}}, 
{'connectivityCheck': False})
Line 236: self.assertEqual(status, SUCCESS, msg)
Line 237: 
Line 238: def assertNetworkExists(self, networkName, bridged=None):
In fact my original code was the new asserts in networkTests. But since we 
originally didn't want this module to access self.vdsm_net.netinfo nor config I 
moved it there. 

This method is not used and it is a glitch of my git cherry-picking.
Line 239: self.assert_(networkName in self.vdsm_net.netinfo.networks)
Line 240: if bridged:
Line 241: self.assertEqual(
Line 242: bridged,


-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-11 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 2: Code-Review+1

(2 comments)


Commit Message
Line 6: 
Line 7: Network functional tests assertion improvements
Line 8: 
Line 9: This change allows for more fine grained assertion errors. It allows
Line 10: , among other things, to differentiate if what failed is making a
English style: no leading comma please.
Line 11: net or putting it into the running configuration.
Line 12: 
Line 13: Change-Id: Icca9a552272818039bc677c6adebfed3d5664454



File tests/functional/networkTests.py
Line 146: 
Line 147: def assertNetworkExists(self, networkName, bridged=None):
Line 148: netinfo = self.vdsm_net.netinfo
Line 149: config = self.vdsm_net.config
Line 150: self.assertTrue(networkName in netinfo.networks)
using assertIn() (after pulling it to python 2.6) would provide clearer outputs 
in case of assertion. Ancient Ruth had it.
Line 151: if bridged is not None:
Line 152: self.assertEqual(bridged, 
netinfo.networks[networkName]['bridged'])
Line 153: if config is not None:
Line 154: self.assertTrue(networkName in config.networks)


-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-11 Thread asegurap 
Antoni Segura Puimedon has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 2:

(1 comment)


File tests/functional/networkTests.py
Line 146: 
Line 147: def assertNetworkExists(self, networkName, bridged=None):
Line 148: netinfo = self.vdsm_net.netinfo
Line 149: config = self.vdsm_net.config
Line 150: self.assertTrue(networkName in netinfo.networks)
Yeah. I had assertIn until I figured it wasn't on 2.7. I guess I could backport 
it to testrunner.
Line 151: if bridged is not None:
Line 152: self.assertEqual(bridged, 
netinfo.networks[networkName]['bridged'])
Line 153: if config is not None:
Line 154: self.assertTrue(networkName in config.networks)


-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-11 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 2: Code-Review-1 Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4941/ : ABORTED

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4055/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4865/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/685/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-11 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 3: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4942/ : ABORTED

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4056/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4866/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/686/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network functional tests assertion improvements

2013-10-11 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Network functional tests assertion improvements
..


Patch Set 4: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4944/ : ABORTED

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4058/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4868/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/688/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches