Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Packaging: VDSM v4.12.0 packaged on Ubuntu

Add files for building VDSM .deb packages on Ubuntu. The package is
split into vdsm-python, vdsm-client, vdsm, vdsm-tests ,various vdsm
hooks, vdsm-python-cpopen vdsm-yajsonrpc and vdsm-gluster.

How does it work.
The deb packaging scripts are written according to Debian New
Maintainers' Guide [1]. We use dh_make, quilt and -buildpackage to do
the packaging. All files unde the sub-dir debian are related to
packaging. The most important ones are as follow.

debian/changelog
This file declares the deb package version.

debian/control
This file declares the dependency packages and other basic informations

debian/rules
This file is an executable Makefile. During the packaging process, it
calls dh_XXX helpers to do the things. We can override some of the stages to
provide custom actions. In this rule file, the following build options
are used.
1 Do not configure libvirt to use sanlock, since it's not supported on
Ubuntu.
2 Do not configure libvirt to use selinux and apparmor. Becuase apparmor
is conflicting with VDSM, and libvirt on Ubuntu does not compiled with
selinux support, so just do not use the security driver of libvirt.
3 Hooks are enabled and built into respetive packages.

debian/package-name.install
Describe files go to the respective sub .deb packages. The directory
containing the file is created automatically.

debian/package-name.dirs
Any dir that is not created automatically by the .intall file.

debian/vdsm.postinst
debian/vdsm.postrm
debian/vdsm.preinst
debian/vdsm.prerm
These four files are maintainer scripts. They are like %pre %post %preun
and %postun in a RPM .spec file. They are run before VDSM package is
intalled, upgraded, and removed. The Debian upgrading process is not
like RPM.
Script execution order when updating a RPM [2]
 %pre of new package
 (package install)
 %post of new package
 %preun of old package
 (removal of old package)
 %postun of old package
Script execution order when updating DEB [3]
old->prerm upgrade new_ver
new->preinst upgrade old_ver
(new files are unpackad)
old->postrm upgrade new_ver
(old files are deleted)
new->postinst configure old_ver
So you will see the contents of these file is very different with
vdsm.spec.in. Another difference is Debian do not generate .pyc files
when packaging, instead, it just ship .py files and after install,
compile the .py to .pyc according to /etc/python/debian_config [4]. The
postinst and prerm scripts do this automatically if we include the
string "#DEBHELPER#". This means actions calling the .pyc files should
happen after the .pyc files are generated.

Other files are just boilerplates to fill.

There are some dependencies that are too old or not available on Ubuntu.

python-ethtool
Too old. The official maintainer does not work on it any longer. So we
have to download the source package and repackage it using the latest
upstream.

python-pthreading
Not available on Ubuntu, need to create .deb packages.

python-rtslib
Ubuntu provide the official version, but in functional tests we use the
Fedora forked version. The two versions are not compatible. Now we do
not add python-rtslib dependency to vdsm-tests. The user can install the
Fedora forked version by "pip install rtslib-fb", if they want to run
functional tests.

sanlock
Too old. The official maintainer does not work on it any longer, but he
helps me and provide new version of sanlock packages. These new packages
are not in Debian official repository unless they are well tested. For
now we can host these packages together with VDSM .deb package. The
packages are for Debian, thus I made a little change to fit into Ubuntu.

libvirt-sanlock
libvirt-sanlock is not available on Ubuntu, but it's in Debian "sid",
the next Debian release. Not sure Ubuntu will take lbvirt-sanlock in
next release. So now just drop libvirt disk locking.

I re-packaged python-ethtool, and packaged python-pthreading from sratch.
sanlock pakcages are provided by the original maintainer, and I modified
it to suit into Ubuntu. The packages are put on launchpad.net [5]. To test
the package, firstly setup a Ubuntu 1304 server, then run the following
command.

add-apt-repository ppa:zhshzhou/vdsm-ubuntu
add-apt-repository ppa:semiosis/ubuntu-glusterfs-3.4
aptitude update
aptitude install python-pip vdsm vdsm-gluster vdsm-tests vdsm-client
pip install rtslib-fb
chmod a+r /boot/vmlinuz* /boot/initrd.img*
cd /usr/share/vdsm/tests
./run_tests.sh functional/virtTests.py functional/storageTests.py

[1] http://www.debian.org/doc/manuals/maint-guide/index.en.html
[2] http://fedoraproject.org/wiki/Packaging:ScriptletSnippets
[3] https://wiki.debian.org/MaintainerScripts
[4] 
http://www.debian.org/doc/packaging-manuals/python-policy/ch-m

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 6: Code-Review+2

Ok, let's take this as a reference to future Ubuntu/Debian downstream 
packagers. I'd like to keep maintaining the rpm spec in-tree, and would be most 
willing to do so for .deb - as long as Zhou can keep maintaining it.

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[zhshzhou]

Zhou Zheng Sheng has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 6: Verified+1

Since Ubuntu and Debian are among the most popular distributions, I think it's 
good to have a reference packaging script in upstream. I'll try to keep up with 
vdsm.spec.in and configure.ac once for a while. I'm not a Ubuntu expert, just 
teach myself Debian packaging system from zero. Debian packaging is easy to 
learn. VDSM knowledge is more important. Everyone can try to contribute to it 
once you have read Debian new maintainers' guide, which is a small and nice 
guide. In fact, the most time consuming work is testing. It will be a lot 
better if we have a Ubuntu Jenkins run the packaging script and functional test 
continuously.

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 6: Code-Review+1

I think that the vdsm tarball would be better if it includes a "reference" deb, 
to be used as a basis for the Ubuntu maintainer.

However, we can take this patch only if Zhou (are any other Ubuntu expert) 
commits to keeping it up to date with changes, as most vdsm developers (and 
maintainers) are quite likely to neglect it.

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 6:

Well, the location of downstream packaging not important for testing, as test 
can be done using upstream sources at any point in time, I do expect people 
break downstream packaging and async fixes to these.

I do not see difference between ubuntu and gentoo[1] in this regard, if I 
maintain Gentoo packaging, I can do this in its own repository, while making 
sure that upstream is contains all customization required.

Like Gentoo has its overlays, ubuntu has its launchpad.net, this is where 
ubuntu community participate.

But I may be wrong...

[1] https://github.com/alonbl/ovirt-overlay

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[zhshzhou]

Zhou Zheng Sheng has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 6:

Hi Alon. Do you mean the bazaar repository hosted by launchpad.net? I think 
it's better to have this patch go to upsteam so we always take the distribution 
neutral problem into consideration when submitting new patches. By continuously 
build, install, and run functional tests on Ubuntu when a new patch is merged, 
we also know whether the compatibility is broken as soon as possible. Without 
this, we will never have an official release on Ubuntu and have to do big bang 
compatibility fixes in each Ubuntu PPA release. I understand that the focus is 
RHEV, but oVirt is not RHEV, it should be a bigger community.

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 6:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4345/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3448/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4264/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 5:

I thought of putting this at bazaar...

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[zhshzhou]

Zhou Zheng Sheng has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 5:

This is a hard question. I think if we want to make VDSM more popular, we'd 
better take this responsibility. We maintain the code inside the community and 
have a jenkins slave build it to verify new patches does not break 
compatibility. If we put it in other place, there comes the problem of who 
maintains it and where to put it. A personal branch on github?

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 5:

And... now the real question... if there are no patches and we do not touch any 
of other project's components, why can't this be maintained externally?

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 5:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4322/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3425/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4241/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 4:

(1 comment)


File debian/rules
Line 26: override_dh_auto_install:
Line 27:dh_auto_install
Line 28:# Install the lvm rules
Line 29:install -Dm 0644 vdsm/storage/12-vdsm-lvm.rules \
Line 30:$(destdir)/lib/udev/rules.d/61-vdsm-lvm.rules
please remember to have this as separate patch... removing 12- prefix at source 
and install 12- suffix at spec.
Line 31:install -Dm 0644 vdsm/limits.conf \
Line 32:$(destdir)/etc/security/limits.d/99-vdsm.conf
Line 33:install -Dm 0644 init/upstart/vdsmd.upstart \
Line 34:$(destdir)/etc/init/vdsmd.conf


-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 4:

(2 comments)


File debian/patches/fix-util-path.patch
Line 5:  
Line 6:  # External programs (sorted, please keep in order)
Line 7:  AC_PATH_PROG([BLKID_PATH], [blkid], [/sbin/blkid])
Line 8: -AC_PATH_PROG([BRCTL_PATH], [brctl], [/usr/sbin/brctl])
Line 9: +AC_PATH_PROG([BRCTL_PATH], [brctl], [/sbin/brctl])
So this is not the way to go...

You should do ./configure BRCTL_PATH=xxx in your packaging.
Line 10:  AC_PATH_PROG([CAT_PATH], [cat], [/bin/cat])
Line 11:  AC_PATH_PROG([CHKCONFIG_PATH], [chkconfig], [/sbin/chkconfig])
Line 12:  AC_PATH_PROG([CHMOD_PATH], [chmod], [/bin/chmod])
Line 13: @@ -167,15 +167,15 @@



File debian/patches/libvirt-conf-path.patch
Line 5:  QEMU_DUMP_PATH="/var/log/core"
Line 6:  LCONF="@sysconfdir@/libvirt/libvirtd.conf"
Line 7:  QCONF="@sysconfdir@/libvirt/qemu.conf"
Line 8: -LDCONF="@sysconfdir@/sysconfig/libvirtd"
Line 9: +LDCONF="@sysconfdir@/default/libvirt-bin"
yes, I hope I understand... :)
Line 10:  QLCONF="@sysconfdir@/libvirt/qemu-sanlock.conf"
Line 11:  [ "${LIBVIRT_SANLOCK}" = "false" ] && QLCONF="/dev/null"


-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[zhshzhou]

Zhou Zheng Sheng has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 4:

(2 comments)


File debian/patches/fix-util-path.patch
Line 5:  
Line 6:  # External programs (sorted, please keep in order)
Line 7:  AC_PATH_PROG([BLKID_PATH], [blkid], [/sbin/blkid])
Line 8: -AC_PATH_PROG([BRCTL_PATH], [brctl], [/usr/sbin/brctl])
Line 9: +AC_PATH_PROG([BRCTL_PATH], [brctl], [/sbin/brctl])
This is because bridge-utils is not in the build dependency. So on a clean 
build machine, after install all build dependencies, brctl is still missing, 
and AC_PATH_PROG uses the default value. This is not an error though.
Line 10:  AC_PATH_PROG([CAT_PATH], [cat], [/bin/cat])
Line 11:  AC_PATH_PROG([CHKCONFIG_PATH], [chkconfig], [/sbin/chkconfig])
Line 12:  AC_PATH_PROG([CHMOD_PATH], [chmod], [/bin/chmod])
Line 13: @@ -167,15 +167,15 @@



File debian/patches/libvirt-conf-path.patch
Line 5:  QEMU_DUMP_PATH="/var/log/core"
Line 6:  LCONF="@sysconfdir@/libvirt/libvirtd.conf"
Line 7:  QCONF="@sysconfdir@/libvirt/qemu.conf"
Line 8: -LDCONF="@sysconfdir@/sysconfig/libvirtd"
Line 9: +LDCONF="@sysconfdir@/default/libvirt-bin"
I also think it's good to have "--with-libvirtd-service=libvirt-bin". For the 
same reason we may also have "--with-iscsd-service=" and 
"--with-multipathd-service=". Since only "--with-libvirtd-service=" is 
necessary for Ubuntu packaging, if I am to submit a patch, I'd add 
"--with-libvirtd-service=" only, other service name options can be skipped. 
Agree?
Line 10:  QLCONF="@sysconfdir@/libvirt/qemu-sanlock.conf"
Line 11:  [ "${LIBVIRT_SANLOCK}" = "false" ] && QLCONF="/dev/null"


-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 4:

(2 comments)


File debian/patches/fix-util-path.patch
Line 5:  
Line 6:  # External programs (sorted, please keep in order)
Line 7:  AC_PATH_PROG([BLKID_PATH], [blkid], [/sbin/blkid])
Line 8: -AC_PATH_PROG([BRCTL_PATH], [brctl], [/usr/sbin/brctl])
Line 9: +AC_PATH_PROG([BRCTL_PATH], [brctl], [/sbin/brctl])
why is that required? it should look up the tool and set BRCTL_PATH correctly. 
If a change is required, the default should be error not a value.
Line 10:  AC_PATH_PROG([CAT_PATH], [cat], [/bin/cat])
Line 11:  AC_PATH_PROG([CHKCONFIG_PATH], [chkconfig], [/sbin/chkconfig])
Line 12:  AC_PATH_PROG([CHMOD_PATH], [chmod], [/bin/chmod])
Line 13: @@ -167,15 +167,15 @@



File debian/patches/libvirt-conf-path.patch
Line 5:  QEMU_DUMP_PATH="/var/log/core"
Line 6:  LCONF="@sysconfdir@/libvirt/libvirtd.conf"
Line 7:  QCONF="@sysconfdir@/libvirt/qemu.conf"
Line 8: -LDCONF="@sysconfdir@/sysconfig/libvirtd"
Line 9: +LDCONF="@sysconfdir@/default/libvirt-bin"
why not have @LIBVIRTD_SERVICE@ in autoconf and --with-libvirtd-servce=xxx?
Line 10:  QLCONF="@sysconfdir@/libvirt/qemu-sanlock.conf"
Line 11:  [ "${LIBVIRT_SANLOCK}" = "false" ] && QLCONF="/dev/null"


-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[zhshzhou]

Zhou Zheng Sheng has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 4: Verified+1

The new patch set split vdsm-python, vdsm-client, vdsm-tests ,various vdsm 
hooks, vdsm-python-cpopen vdsm-yajsonrpc and vdsm-gluster.

To disable libvirt selinux and sanlock plugin, a new patch 
(http://gerrit.ovirt.org/#/c/18921/) is submitted to configure the usage of the 
plugins at build time. Now in debian/rules, we configure VDSM with 
--enable-libvirt-selinux=no and --enable-libvirt-sanlock=no . The previous 
drop-libvirt-sanlock.patch and libvirt_without_apparmor.patch are not needed.

Another change is in the debian/rules, in previous patch, it installs files 
directly to debian/vdsm, now it installs to debian/tmp. Then these files are 
refered in debian/vdsm.install, so the packaging system copies them from 
debian/tmp to debian/vdsm automatically. debian/tmp is like "buildroot" for RPM.

vdsm-reg and bootstrap files are deleted from debian/vdsm.install.

Test on Ubuntu 1304, and the new patch set is uploaded to PPA, and build 
succesfully.

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4292/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3395/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4211/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[zhshzhou]

Zhou Zheng Sheng has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 3:

(1 comment)


File debian/patches/libvirt-conf-path.patch
Line 15:  set_if_default "${ldconf}" DAEMON_COREFILE_LIMIT unlimited
Line 16:  set_if_default "${qconf}" save_image_format \"lzop\"
Line 17: +set_if_default "${qconf}" user \"@QEMUUSER@\"
Line 18: +set_if_default "${qconf}" group \"@QEMUGROUP@\"
Line 19: +echo unix_sock_group=\"@VDSMGROUP@\" >> "${lconf}"
In Fedora, libvirtd.conf the unix_sock_group is not set, but in Ubuntu, it is 
set as 

 unix_sock_group = "libvirtd"

I find another way for solving the unix_sock_group problem. I add vdsm user to 
libvirtd group in the post install script. So this line can be deleted from the 
patch. 

As regarded to set the qemu process user and group, at first I wrote the patch 
for Debian "sid"'s libvirt, but I found there are conflicts, so I drop to 
Ubuntu's libvirt. These two lines  are not needed in Ubuntu, so in the next 
patch set, this .patch file will be dropped.
Line 20:  # FIXME until we are confident with libvirt integration, let us 
have a verbose log
Line 21:  set_if_default "${lconf}" log_outputs 
\"1:file:/var/log/libvirt/libvirtd.log\"


-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[vfeenstr]

Vinzenz Feenstra has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 3:

(1 comment)


Commit Message
Line 6: 
Line 7: Packaging: VDSM v4.12.0 packaged on Ubuntu
Line 8: 
Line 9: Add files for building VDSM .deb packages on Ubuntu. The package is
Line 10: splitted into vdsm, vdsm-tests and various vdsm hooks.
vdsm-python itself is useful. vdsClient uses vdsm-python, you would have to 
install vdsm to beable using vdsClient otherwise. However that's not necessary, 
you can have vdsClient separately.
Line 11: 
Line 12: How does it work.
Line 13: The deb packaging scripts are written according to Debian New
Line 14: Maintainers' Guide [1]. We use dh_make, quilt and -buildpackage to do


-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 3:

(3 comments)


File debian/patches/fix-util-path.patch
Line 1: Adapt to path of the programs on Ubuntu
Line 2: --- a/configure.ac
Line 3: +++ b/configure.ac
Line 4: @@ -137,7 +137,7 @@
Line 5:  
sure it is OK this is patch format.
Line 6:  # External programs (sorted, please keep in order)
Line 7:  AC_PATH_PROG([BLKID_PATH], [blkid], [/sbin/blkid])
Line 8: -AC_PATH_PROG([BRCTL_PATH], [brctl], [/usr/sbin/brctl])
Line 9: +AC_PATH_PROG([BRCTL_PATH], [brctl], [/sbin/brctl])



File debian/patches/libvirt-conf-path.patch
Line 15:  set_if_default "${ldconf}" DAEMON_COREFILE_LIMIT unlimited
Line 16:  set_if_default "${qconf}" save_image_format \"lzop\"
Line 17: +set_if_default "${qconf}" user \"@QEMUUSER@\"
Line 18: +set_if_default "${qconf}" group \"@QEMUGROUP@\"
Line 19: +echo unix_sock_group=\"@VDSMGROUP@\" >> "${lconf}"
any reason why this is not going to upstream? why not do this always?
Line 20:  # FIXME until we are confident with libvirt integration, let us 
have a verbose log
Line 21:  set_if_default "${lconf}" log_outputs 
\"1:file:/var/log/libvirt/libvirtd.log\"



File debian/vdsm.install
I think that the spec should be fixed as wel :)))

There is a new method for specs not sure if rhel supports that:

 %files subpackage -f 

So in theory we can produce  for subpacakges and use it as an input 
to spec or to generate this file... but just an idea.
Line 1: ./etc/bash_completion.d/vdsClient
Line 2: ./etc/cron.d/vdsm-libvirt-logrotate
Line 3: ./etc/cron.hourly/vdsm-logrotate
Line 4: ./etc/cron.hourly/vdsm-reg-logrotate


-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 3:

> @Alon, in debian/rules line 22, the udev 12-vdsm-lvm.rules is installed as 
> 61-vdsm-lvm.rules on Ubuntu. Do you mean we need a separated patch to remove 
> the "12-" prefix from the source and install it in the correct order in 
> vdsm.spec %install section?

yes.

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[zhshzhou]

Zhou Zheng Sheng has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 3:

(20 comments)

Thanks guys.

@Alon, in debian/rules line 22, the udev 12-vdsm-lvm.rules is installed as 
61-vdsm-lvm.rules on Ubuntu. Do you mean we need a separated patch to remove 
the "12-" prefix from the source and install it in the correct order in 
vdsm.spec %install section?


Commit Message
Line 5: CommitDate: 2013-09-02 12:44:16 +0800
Line 6: 
Line 7: Packaging: VDSM v4.12.0 packaged on Ubuntu
Line 8: 
Line 9: Add files for building VDSM .deb packages on Ubuntu. The package is
Done
Line 10: splitted into vdsm, vdsm-tests and various vdsm hooks.
Line 11: 
Line 12: How does it work.
Line 13: The deb packaging scripts are written according to Debian New


Line 6: 
Line 7: Packaging: VDSM v4.12.0 packaged on Ubuntu
Line 8: 
Line 9: Add files for building VDSM .deb packages on Ubuntu. The package is
Line 10: splitted into vdsm, vdsm-tests and various vdsm hooks.
Yes. It's good to split them. On vdsm-client and cpopen I agree with you. 
However I am unclear about the reason for splitting vdsm-python. From what I 
can see, just installing vdsm-python without vdsm itself seems not very useful. 
The python module is tightly coupled with vdsm in its semantics.
Line 11: 
Line 12: How does it work.
Line 13: The deb packaging scripts are written according to Debian New
Line 14: Maintainers' Guide [1]. We use dh_make, quilt and -buildpackage to do



File debian/control
Line 96: Conflicts: apparmor
Line 97: Description: VDSM: Virtual Desktop Server Manager
Line 98:  The VDSM service is required by a Virtualization Manager to manage 
the 
Line 99:  Linux hosts. VDSM manages and monitors the host's storage, memory and 
Line 100:  networks as well as virtual machine creation, other host 
administration 
Done. Thanks
Line 101:  tasks, statistics gathering, and log collection.
Line 102: 
Line 103: Package: vdsm-tests
Line 104: Architecture: any



File debian/copyright
Line 13:  (at your option) any later version.
Line 14:  .
Line 15:  This package is distributed in the hope that it will be useful,
Line 16:  but WITHOUT ANY WARRANTY; without even the implied warranty of
Line 17:  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the 
Done
Line 18:  GNU General Public License for more details.
Line 19:  .
Line 20:  You should have received a copy of the GNU General Public License
Line 21:  along with this program. If not, see 



File debian/patches/drop-libvirt-sanlock.patch
Line 1: libvirt-sanlock provided in latest libvirt needs libaudit0, but 
policycoreutils needs libaudit1.
Line 2: In these release we drop libvirt-sanlock and related feature.
Thanks Vinzenz and Federico, Sanlock is still used in VDSM to protect the 
storage metadata , but sanlock driver for libvirt to protect the VM disks is 
not used. This is because Ubuntu is not fully compatible with Debian. Now my 
target is a subset of features both work in Ubuntu and Debian.
Line 3: --- a/lib/vdsm/tool/libvirt_configure.sh.in
Line 4: +++ b/lib/vdsm/tool/libvirt_configure.sh.in
Line 5: @@ -235,9 +235,9 @@
Line 6:  fi


Line 10: -set_if_default "${qlconf}" auto_disk_leases 0
Line 11: -set_if_default "${qlconf}" require_lease_for_disks 0
Line 12: +#set_if_default "${qconf}" lock_manager \"sanlock\"
Line 13: +#set_if_default "${qlconf}" auto_disk_leases 0
Line 14: +#set_if_default "${qlconf}" require_lease_for_disks 0
OK.
Line 15:  
Line 16:  # Configuring auto dump path



File debian/patches/fix-util-path.patch
Line 1: Adapt to path of the programs on Ubuntu
Line 2: --- a/configure.ac
Line 3: +++ b/configure.ac
Line 4: @@ -137,7 +137,7 @@
Line 5:  
Not sure if this is a dquilt bug or feature. This whitespaces are not part of 
the patch. It seems generated by dquilt. I will try to remove them and see if 
it applies successfully.
Line 6:  # External programs (sorted, please keep in order)
Line 7:  AC_PATH_PROG([BLKID_PATH], [blkid], [/sbin/blkid])
Line 8: -AC_PATH_PROG([BRCTL_PATH], [brctl], [/usr/sbin/brctl])
Line 9: +AC_PATH_PROG([BRCTL_PATH], [brctl], [/sbin/brctl])



File debian/patches/libvirt-conf-path.patch
Line 15:  set_if_default "${ldconf}" DAEMON_COREFILE_LIMIT unlimited
Line 16:  set_if_default "${qconf}" save_image_format \"lzop\"
Line 17: +set_if_default "${qconf}" user \"@QEMUUSER@\"
Line 18: +set_if_default "${qconf}" group \"@QEMUGROUP@\"
Line 19: +echo unix_sock_group=\"@VDSMGROUP@\" >> "${lconf}"
Not sure about the granularity, one "--enable-set-libvir

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 3:

I remember there was udev rule ordering patch... remove the order prefix from 
the source and place it in spec and dev at different order.

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 3:

(3 comments)


File debian/patches/drop-libvirt-sanlock.patch
Line 10: -set_if_default "${qlconf}" auto_disk_leases 0
Line 11: -set_if_default "${qlconf}" require_lease_for_disks 0
Line 12: +#set_if_default "${qconf}" lock_manager \"sanlock\"
Line 13: +#set_if_default "${qlconf}" auto_disk_leases 0
Line 14: +#set_if_default "${qlconf}" require_lease_for_disks 0
this is an .in file, I expect it to be enabled/disabled based on --enable-xxx 
for autoconf.
Line 15:  
Line 16:  # Configuring auto dump path



File debian/patches/libvirt-conf-path.patch
Line 15:  set_if_default "${ldconf}" DAEMON_COREFILE_LIMIT unlimited
Line 16:  set_if_default "${qconf}" save_image_format \"lzop\"
Line 17: +set_if_default "${qconf}" user \"@QEMUUSER@\"
Line 18: +set_if_default "${qconf}" group \"@QEMUGROUP@\"
Line 19: +echo unix_sock_group=\"@VDSMGROUP@\" >> "${lconf}"
this is .in file, I expect this to be enabled/disabled based on autoconf 
--enable-xxx
Line 20:  # FIXME until we are confident with libvirt integration, let us 
have a verbose log
Line 21:  set_if_default "${lconf}" log_outputs 
\"1:file:/var/log/libvirt/libvirtd.log\"



File debian/patches/libvirt_without_apparmor.patch
Line 4: @@ -204,6 +204,7 @@
Line 5:  set_if_default "${lconf}" host_uuid "\"$(uuidgen)\""
Line 6:  set_if_default "${lconf}" keepalive_interval -1
Line 7:  set_if_default "${qconf}" dynamic_ownership 0
Line 8: +set_if_default "${qconf}" security_driver \"none\"
this is an .in file, I expect it to be enabled/disabled based on autoconf 
--enable-xxx
Line 9:  
Line 10:  if [ "${ssl}" = "true" ]; then


-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[fsimonce]

Federico Simoncelli has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 3: -Code-Review

(1 comment)


File debian/patches/drop-libvirt-sanlock.patch
Line 1: libvirt-sanlock provided in latest libvirt needs libaudit0, but 
policycoreutils needs libaudit1.
Line 2: In these release we drop libvirt-sanlock and related feature.
Ah sorry I missed that this would be for debian only.

Maybe removing libvirt-sanlock from this initial debian integration could be 
ok. Anyway it's something that debian will have to deal with in the future.

The important thing is that sanlock is provided for the SPM resource (domain 
v3).
Line 3: --- a/lib/vdsm/tool/libvirt_configure.sh.in
Line 4: +++ b/lib/vdsm/tool/libvirt_configure.sh.in
Line 5: @@ -235,9 +235,9 @@
Line 6:  fi


-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 3:

(3 comments)


File debian/vdsm.install
can't wildcards be used? specifying file based is something that should be 
avoided.
Line 1: ./etc/bash_completion.d/vdsClient
Line 2: ./etc/cron.d/vdsm-libvirt-logrotate
Line 3: ./etc/cron.hourly/vdsm-logrotate
Line 4: ./etc/cron.hourly/vdsm-reg-logrotate


Line 66: ./usr/libexec/vdsm/vdsmd_init_common.sh
Line 67: ./usr/share/man/man1/vdsClient.1
Line 68: ./usr/share/man/man8/vdsm-reg.8
Line 69: ./usr/share/man/man8/vdsmd.8
Line 70: ./usr/share/vdsm-bootstrap/deployUtil.py
vdsm-bootstrap is obsolete, no need.
Line 71: ./usr/share/vdsm-bootstrap/interface-2/deployUtil.py
Line 72: ./usr/share/vdsm-bootstrap/interface-2/miniyum.py
Line 73: ./usr/share/vdsm-bootstrap/interface-2/setup
Line 74: ./usr/share/vdsm-bootstrap/interface-2/vds_bootstrap.py


Line 74: ./usr/share/vdsm-bootstrap/interface-2/vds_bootstrap.py
Line 75: ./usr/share/vdsm-bootstrap/interface-2/vds_bootstrap_complete.py
Line 76: ./usr/share/vdsm-bootstrap/vds_bootstrap.py
Line 77: ./usr/share/vdsm-bootstrap/vds_bootstrap_complete.py
Line 78: ./usr/share/vdsm-reg/config.py
vdsm-reg is ovirt-node specific, no need to install.
Line 79: ./usr/share/vdsm-reg/createDaemon.py
Line 80: ./usr/share/vdsm-reg/deployUtil.py
Line 81: ./usr/share/vdsm-reg/register-to-engine.py
Line 82: ./usr/share/vdsm-reg/save-config


-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[fsimonce]

Federico Simoncelli has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 3: Code-Review-1

(1 comment)


File debian/patches/drop-libvirt-sanlock.patch
Line 1: libvirt-sanlock provided in latest libvirt needs libaudit0, but 
policycoreutils needs libaudit1.
Line 2: In these release we drop libvirt-sanlock and related feature.
Yes, we're on the verge of finally using sanlock for volume leases (hosted 
engine). This is definitely a show stopper.
Line 3: --- a/lib/vdsm/tool/libvirt_configure.sh.in
Line 4: +++ b/lib/vdsm/tool/libvirt_configure.sh.in
Line 5: @@ -235,9 +235,9 @@
Line 6:  fi


-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[vfeenstr]

Vinzenz Feenstra has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 3: Code-Review-1

(17 comments)

There are a lot of things to be changed still. In general it's great work, 
however there must be further split up applied. I just commented on some 
things, however I am not 100% sure if I saw everything


Commit Message
Line 5: CommitDate: 2013-09-02 12:44:16 +0800
Line 6: 
Line 7: Packaging: VDSM v4.12.0 packaged on Ubuntu
Line 8: 
Line 9: Add files for building VDSM .deb packages on Ubuntu. The package is
split
Line 10: splitted into vdsm, vdsm-tests and various vdsm hooks.
Line 11: 
Line 12: How does it work.
Line 13: The deb packaging scripts are written according to Debian New


Line 6: 
Line 7: Packaging: VDSM v4.12.0 packaged on Ubuntu
Line 8: 
Line 9: Add files for building VDSM .deb packages on Ubuntu. The package is
Line 10: splitted into vdsm, vdsm-tests and various vdsm hooks.
Well there should be a split up of lib/vdsm (vdsm-python package on 
RHEL/Fedora), and a package for the vdsClient (vdsm-client) as well. 
Additionally we're splitting off cpopen as a separate package.

I think we should this here as well.
Line 11: 
Line 12: How does it work.
Line 13: The deb packaging scripts are written according to Debian New
Line 14: Maintainers' Guide [1]. We use dh_make, quilt and -buildpackage to do



File debian/control
Line 96: Conflicts: apparmor
Line 97: Description: VDSM: Virtual Desktop Server Manager
Line 98:  The VDSM service is required by a Virtualization Manager to manage 
the 
Line 99:  Linux hosts. VDSM manages and monitors the host's storage, memory and 
Line 100:  networks as well as virtual machine creation, other host 
administration 
trailing whitespaces
Line 101:  tasks, statistics gathering, and log collection.
Line 102: 
Line 103: Package: vdsm-tests
Line 104: Architecture: any



File debian/copyright
Line 13:  (at your option) any later version.
Line 14:  .
Line 15:  This package is distributed in the hope that it will be useful,
Line 16:  but WITHOUT ANY WARRANTY; without even the implied warranty of
Line 17:  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the 
trailing whitespaces
Line 18:  GNU General Public License for more details.
Line 19:  .
Line 20:  You should have received a copy of the GNU General Public License
Line 21:  along with this program. If not, see 



File debian/patches/drop-libvirt-sanlock.patch
Line 1: libvirt-sanlock provided in latest libvirt needs libaudit0, but 
policycoreutils needs libaudit1.
Line 2: In these release we drop libvirt-sanlock and related feature.
I think dropping sanlock is going to be a show stopper. @fsimonce: What do you 
say?
Line 3: --- a/lib/vdsm/tool/libvirt_configure.sh.in
Line 4: +++ b/lib/vdsm/tool/libvirt_configure.sh.in
Line 5: @@ -235,9 +235,9 @@
Line 6:  fi


Line 3: --- a/lib/vdsm/tool/libvirt_configure.sh.in
Line 4: +++ b/lib/vdsm/tool/libvirt_configure.sh.in
Line 5: @@ -235,9 +235,9 @@
Line 6:  fi
Line 7:  
trailing whitespaces
Line 8:  # Configuring sanlock
Line 9: -set_if_default "${qconf}" lock_manager \"sanlock\"
Line 10: -set_if_default "${qlconf}" auto_disk_leases 0
Line 11: -set_if_default "${qlconf}" require_lease_for_disks 0



File debian/patches/fix-util-path.patch
Line 1: Adapt to path of the programs on Ubuntu
Line 2: --- a/configure.ac
Line 3: +++ b/configure.ac
Line 4: @@ -137,7 +137,7 @@
Line 5:  
trailing whitespaces
Line 6:  # External programs (sorted, please keep in order)
Line 7:  AC_PATH_PROG([BLKID_PATH], [blkid], [/sbin/blkid])
Line 8: -AC_PATH_PROG([BRCTL_PATH], [brctl], [/usr/sbin/brctl])
Line 9: +AC_PATH_PROG([BRCTL_PATH], [brctl], [/sbin/brctl])



File debian/vdsm.install
Line 1: ./etc/bash_completion.d/vdsClient
part of vdsm-client
Line 2: ./etc/cron.d/vdsm-libvirt-logrotate
Line 3: ./etc/cron.hourly/vdsm-logrotate
Line 4: ./etc/cron.hourly/vdsm-reg-logrotate
Line 5: ./etc/dhcp/dhclient.d/sourceRoute.sh


Line 19: ./etc/vdsm/mom.d/01-parameters.policy
Line 20: ./etc/vdsm/mom.d/02-balloon.policy
Line 21: ./etc/vdsm/mom.d/03-ksm.policy
Line 22: ./etc/vdsm/svdsm.logger.conf
Line 23: ./usr/bin/vdsClient
vdsm-client
Line 24: ./usr/bin/vdsm-tool
Line 25: ./usr/lib/python2.7/dist-packages/cpopen/__init__.py
Line 26: ./usr/lib/python2.7/dist-packages/cpopen/cpopen.so
Line 27: ./usr/lib/python2.7/dist-packages/ovirt_config_setup/engine.py


Line 21: ./etc/vdsm/mom.d/03-ksm.policy
Line 22: ./etc/vdsm/svdsm.logger.conf
Line 23: ./usr/bin/vdsClient
Line 24: ./usr/bin/vdsm-tool
Line 25: ./usr/lib/pyt

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[zhshzhou]

Zhou Zheng Sheng has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 3: Verified+1

Test on Ubuntu 1304.

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4240/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3345/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4161/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4231/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3336/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4152/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4115/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3220/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4036/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[zhshzhou]

Zhou Zheng Sheng has posted comments on this change.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..


Patch Set 1: Verified+1

Test on Ubuntu 1304. The packages can be installed on Ubuntu together with the 
dependency packages. The upgrade and remove are successful too. Do not affect 
building RPMs.

-- 
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

[zhshzhou]

Zhou Zheng Sheng has uploaded a new change for review.

Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..

Packaging: VDSM v4.12.0 packaged on Ubuntu

Add files for building VDSM .deb package on Ubuntu. vdsm-reg is not
included. For simplicity, the whole VDSM is packaged in a single binary.
In future we can split sub-packages.

How does it work.
The deb packaging scripts are written according to Debian New
Maintainers' Guide [1]. We use dh_make, quilt and -buildpackage to do
the packaging. All files unde the sub-dir debian are related to
packaging. The most important ones are as follow.

debian/changelog
This file declares the deb package version.

debian/control
This file declares the dependency packages and other basic informations

debian/rules
This file is an executable Makefile. During the packaging process, it
calls dh_XXX helpers to do the things. We can override some of the stages to
provide custom actions.

debian/postinst
debian/postrm
debian/preinst
debian/prerm
These four files are maintainer scripts. They are like %pre %post %preun
and %postun in a RPM .spec file. They are run before VDSM package is
intalled, upgraded, and removed. The Debian upgrading process is not
like RPM.
Script execution order when updating a RPM [2]
 %pre of new package
 (package install)
 %post of new package
 %preun of old package
 (removal of old package)
 %postun of old package
Script execution order when updating DEB [3]
old->prerm upgrade new_ver
new->preinst upgrade old_ver
(new files are unpackad)
old->postrm upgrade new_ver
(old files are deleted)
new->postinst configure old_ver
So you will see the contents of these file is very different with
vdsm.spec.in. Another difference is Debian do not generate .pyc files
when packaging, instead, it just ship .py files and after install,
compile the .py to .pyc according to /etc/python/debian_config [4]. The
postinst and prerm scripts do this automatically if we include the
string "#DEBHELPER#". This means actions calling the .pyc files should
happen after the .pyc files are generated.

debian/patches/*
The directory contains Debian specific patches. The patches are too
specific so not go to upstream. Usually are very small patches. In this
gerrit patch set, I create a small patch to adapt to Ubuntu libvirt
configuration path. The patch file can be generated automatically by
quilt [5].

Other files are just boilerplates to fill.

There are some dependencies that are too old or not available on Ubuntu.

python-ethtool
Too old. The official maintainer does not work on it any longer. So we
have to download the source package and repackage it using the latest
upstream.

python-pthreading
Not available on Ubuntu, need to create .deb packages.

python-rtslib
Ubuntu provide the official version, but in xmlrpctests.py we use the
Fedora forked version. The two versions are not compatible. In future we
shoud split the tests package and provide forked version in deb package.

sanlock
Too old. The official maintainer does not work on it any longer, but he
helps me and provide new version of sanlock packages. These new packages
are not in Debian official repository unless they are well tested. For
now we can host these packages together with VDSM .deb package.

libvirt and libvirt-sanlock
libvirt is too old and libvirt-sanlock is not available on Ubuntu.
Fortunately new libvirt and libvirt-sanlock are available in Debian
development repository "sid", but they are conflicting with some Ubuntu
packages. After remove the conflicting ones automatically, libvirt and
libvirt-sanlock can be upraded to new version

I've gathered all VDSM dependencies, including the above ones. libvirt
and libvirt-sanlock are downloaded from Debian "sid", python-ethtool and
python-rtslib some are re-packaged to VDSM compatible version.
python-pthreading are packaged from sratch. sanlock pakcages are provided
by the original maintainer, but not well tested. I'll put these packages
to my github later, then I update the commit message.

[1] http://www.debian.org/doc/manuals/maint-guide/index.en.html
[2] http://fedoraproject.org/wiki/Packaging:ScriptletSnippets
[3] https://wiki.debian.org/MaintainerScripts
[4] 
http://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html#s-byte_compilation
[5] http://www.debian.org/doc/manuals/maint-guide/modify.en.html

Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Signed-off-by: Zhou Zheng Sheng 
---
A debian/README.Debian
A debian/TODO
A debian/changelog
A debian/compat
A debian/control
A debian/copyright
A debian/dependencyMap.txt
A debian/docs
A debian/patches/libvirt-conf-path.patch
A debian/patches/series
A debian/postinst
A debian/postrm
A debian/preinst
A debian/prerm
A debian/rules
A debian/source/format
A debian/watch
17 files changed, 491 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm