Change in vdsm[master]: Replace username and file location for SASL by constants
Dan Kenigsberg has submitted this change and it was merged. Change subject: Replace username and file location for SASL by constants .. Replace username and file location for SASL by constants Change since v1: - Define another constant P_VDSM_LIBVIRT_PASSWD for the password file location suggested by Dan. As Dan suggested, replace the uername and password file location for SASL authenticating with constant SASL_USERNAME and P_VDSM_LIBVIRT_PASSWD. Change-Id: Ic73829bf7e1b10d72203a607680221c0ef0a889f Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- M vdsm/constants.py.in M vdsm/libvirtconnection.py 2 files changed, 8 insertions(+), 3 deletions(-) Approvals: Wenchao Xia: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic73829bf7e1b10d72203a607680221c0ef0a889f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiaw...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace username and file location for SASL by constants
Dan Kenigsberg has posted comments on this change. Change subject: Replace username and file location for SASL by constants .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/5037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic73829bf7e1b10d72203a607680221c0ef0a889f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiaw...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace username and file location for SASL by constants
Wenchao Xia has posted comments on this change. Change subject: Replace username and file location for SASL by constants .. Patch Set 4: Looks good to me, but someone else must approve good, I do not need to search the vdsm Project anymore when I want to use virsh. -- To view, visit http://gerrit.ovirt.org/5037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic73829bf7e1b10d72203a607680221c0ef0a889f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiaw...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace username and file location for SASL by constants
Lei Li has posted comments on this change. Change subject: Replace username and file location for SASL by constants .. Patch Set 1: (1 inline comment) File vdsm/libvirtconnection.py Line 106: 'libvirt_password').readline().rstrip(\n) Done -- To view, visit http://gerrit.ovirt.org/5037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic73829bf7e1b10d72203a607680221c0ef0a889f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace username and file location for SASL by constants
Dan Kenigsberg has posted comments on this change. Change subject: Replace username and file location for SASL by constants .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment) File vdsm/constants.py.in Line 65: P_VDSM_FILE = '/etc/pki/vdsm/keys/libvirt_password' this should be P_VDSM_LIBVIRT_PASSWD = P_VDSM_KEYS + 'libvirt_password' the name you've chosen is not very descriptive... -- To view, visit http://gerrit.ovirt.org/5037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic73829bf7e1b10d72203a607680221c0ef0a889f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace username and file location for SASL by constants
Lei Li has posted comments on this change. Change subject: Replace username and file location for SASL by constants .. Patch Set 2: (1 inline comment) File vdsm/constants.py.in Line 65: P_VDSM_FILE = '/etc/pki/vdsm/keys/libvirt_password' Yeah, I agree with this. Thank you! I will update soon. -- To view, visit http://gerrit.ovirt.org/5037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic73829bf7e1b10d72203a607680221c0ef0a889f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Lei Li li...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace username and file location for SASL by constants
Dan Kenigsberg has posted comments on this change. Change subject: Replace username and file location for SASL by constants .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment) File vdsm/constants.py.in Line 65: P_VDSM_FILE = '/etc/pki/vdsm/keys/libvirt_password' former comment ignored for some reason. -- To view, visit http://gerrit.ovirt.org/5037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic73829bf7e1b10d72203a607680221c0ef0a889f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Lei Li li...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace username and file location for SASL by constants
Lei Li has posted comments on this change. Change subject: Replace username and file location for SASL by constants .. Patch Set 3: (1 inline comment) File vdsm/constants.py.in Line 65: P_VDSM_FILE = '/etc/pki/vdsm/keys/libvirt_password' Oh... I am sure I have modified, but seems there must be some stupid mistake I made!! I am really sorry for that... Update soon. -- To view, visit http://gerrit.ovirt.org/5037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic73829bf7e1b10d72203a607680221c0ef0a889f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Lei Li li...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Replace username and file location for SASL by constants
Dan Kenigsberg has posted comments on this change. Change subject: Replace username and file location for SASL by constants .. Patch Set 4: Looks good to me, approved Yeah, pushing from a wrong branch may happen.. Thanks. -- To view, visit http://gerrit.ovirt.org/5037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic73829bf7e1b10d72203a607680221c0ef0a889f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Lei Li li...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
