Change in vdsm[master]: Skip monitoring the usage of tmpfs filesystems in diskStats

2013-11-12 Thread wudxw 
Mark Wu has abandoned this change.

Change subject: Skip monitoring the usage of tmpfs filesystems in diskStats
..


Abandoned

It should be done on engine side

-- 
To view, visit http://gerrit.ovirt.org/11675
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Idb0a4ae2cf7ceb6297e348d9e90c166373461ca1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Skip monitoring the usage of tmpfs filesystems in diskStats

2013-11-11 Thread iheim 
Itamar Heim has posted comments on this change.

Change subject: Skip monitoring the usage of tmpfs filesystems in diskStats
..


Patch Set 3:

ping?

-- 
To view, visit http://gerrit.ovirt.org/11675
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb0a4ae2cf7ceb6297e348d9e90c166373461ca1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Skip monitoring the usage of tmpfs filesystems in diskStats

2013-07-17 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Skip monitoring the usage of tmpfs filesystems in diskStats
..


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)


File vdsm/sampling.py
Line 160: for p in self.MONITORED_PATHS:
Line 161: rc, out, _ = utils.execCmd(['stat', '--file-system', 
'--format=%T',
Line 162: p])
Line 163: if rc == 0 and out[0] == 'tmpfs':
Line 164: continue
If we have to filter out the tmpfs-mounted paths, how about doing this with 
storage.mount.mount? I'd prefer to have a path->vfstype mapping function there.

But in a more general note - if we do not need to monitor these paths on Fedora 
18-based nodes, we most probably do not need to monitor them AT all. I do think 
that we SHOULD monitor them, but lower the threshold on Engine.
Line 165: 
Line 166: free = 0
Line 167: try:
Line 168: stat = os.statvfs(p)


-- 
To view, visit http://gerrit.ovirt.org/11675
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb0a4ae2cf7ceb6297e348d9e90c166373461ca1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Skip monitoring the usage of tmpfs filesystems in diskStats

2013-07-16 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: Skip monitoring the usage of tmpfs filesystems in diskStats
..


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

Current solution is good.


File vdsm/sampling.py
Line 160: for p in self.MONITORED_PATHS:
Line 161: rc, out, _ = utils.execCmd(['stat', '--file-system', 
'--format=%T',
Line 162: p])
Line 163: if rc == 0 and out[0] == 'tmpfs':
Line 164: continue
So can we put this piece near the definition of MONITORED_PATHS ?

MONITORED_PATHS =  [
p for p in ['/tmp', '/var/log', '/var/log/core', P_VDSM_RUN]
if utils.execCmd(
['stat', '--file-system', '--format=%T', p]) != (0, ['tmpfs'], [])]

or

MONITORED_PATHS = filter(
lambda p: utils.execCmd(
['stat', '--file-system', '--format=%T', p]) != (0, ['tmpfs'], []),
['/tmp', '/var/log', '/var/log/core', P_VDSM_RUN])
Line 165: 
Line 166: free = 0
Line 167: try:
Line 168: stat = os.statvfs(p)


-- 
To view, visit http://gerrit.ovirt.org/11675
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb0a4ae2cf7ceb6297e348d9e90c166373461ca1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Skip monitoring the usage of tmpfs filesystems in diskStats

2013-07-16 Thread wudxw 
Mark Wu has posted comments on this change.

Change subject: Skip monitoring the usage of tmpfs filesystems in diskStats
..


Patch Set 3: (1 inline comment)


File vdsm/sampling.py
Line 160: for p in self.MONITORED_PATHS:
Line 161: rc, out, _ = utils.execCmd(['stat', '--file-system', 
'--format=%T',
Line 162: p])
Line 163: if rc == 0 and out[0] == 'tmpfs':
Line 164: continue
Good point! But in current Host sampling code,  it has the same effect of 
putting it into __init__ and _getDiskStats, because it create a new instance of 
HostSample in every sampling. You approach will show its advantadge after we 
refactor the host sampling code.
Line 165: 
Line 166: free = 0
Line 167: try:
Line 168: stat = os.statvfs(p)


-- 
To view, visit http://gerrit.ovirt.org/11675
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb0a4ae2cf7ceb6297e348d9e90c166373461ca1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Skip monitoring the usage of tmpfs filesystems in diskStats

2013-07-16 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: Skip monitoring the usage of tmpfs filesystems in diskStats
..


Patch Set 3: (1 inline comment)


File vdsm/sampling.py
Line 160: for p in self.MONITORED_PATHS:
Line 161: rc, out, _ = utils.execCmd(['stat', '--file-system', 
'--format=%T',
Line 162: p])
Line 163: if rc == 0 and out[0] == 'tmpfs':
Line 164: continue
I think this piece of code can be put in __init__():

self.MONITORED_PATHS = filter(
lambda p: utils.execCmd(
['stat', '--file-system', '--format=%T', p]) != (0, ['tmpfs'], []),
self.MONITORED_PATHS)

or

self.MONITORED_PATHS = [
p for p in MONITORED_PATHS
if utils.execCmd(
['stat', '--file-system', '--format=%T', p]) != (0, ['tmpfs'], [])]

Then _getDiskStats() does not have to stat the file system every time.
Line 165: 
Line 166: free = 0
Line 167: try:
Line 168: stat = os.statvfs(p)


-- 
To view, visit http://gerrit.ovirt.org/11675
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb0a4ae2cf7ceb6297e348d9e90c166373461ca1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Skip monitoring the usage of tmpfs filesystems in diskStats

2013-07-16 Thread Gerrit Code Review 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Skip monitoring the usage of tmpfs filesystems in diskStats
..


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2532/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3339/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3422/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/11675
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb0a4ae2cf7ceb6297e348d9e90c166373461ca1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Skip monitoring the usage of tmpfs filesystems in diskStats

2013-07-16 Thread wudxw 
Mark Wu has posted comments on this change.

Change subject: Skip monitoring the usage of tmpfs filesystems in diskStats
..


Patch Set 3: Verified

-- 
To view, visit http://gerrit.ovirt.org/11675
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb0a4ae2cf7ceb6297e348d9e90c166373461ca1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Deepak C Shetty 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches