Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Dan Kenigsberg has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 11: Code-Review+2 Verified+1 copying scores. -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
gerrit-hooks has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Dan Kenigsberg has submitted this change and it was merged. Change subject: Skipping networkTests if alien bonds presents in the system .. Skipping networkTests if alien bonds presents in the system Alien bonds causes to tests to report incorrect results. Testing with alien bonds doesnt test vdsm networking. It makes sense since ovirt host shouldn't be used for other purposes. Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Signed-off-by: Ilia Meerovich Reviewed-on: https://gerrit.ovirt.org/53498 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Tested-by: Dan Kenigsberg --- M tests/functional/networkTests.py 1 file changed, 26 insertions(+), 11 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
gerrit-hooks has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Edward Haas has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Dan Kenigsberg has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 10: Code-Review+2 Verified+1 Raising Edy's score, copying V+1 after fixing minor nits. -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
gerrit-hooks has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Edward Haas has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 9: Verified+1 Regular unit and functional (network) tests pass. When creating an empty bond, the network functional tests is skipped. -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Ilia Meerovich has uploaded a new change for review.
Change subject: Skipping networkTests if alien bonds presents in the system
..
Skipping networkTests if alien bonds presents in the system
Alien bonds causes to tests to report incorrect results.
Testing with alien bonds doesnt test vdsm networking.
It makes sense since ovirt host shouldn't be used for other
purposes.
Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261
Signed-off-by: Ilia Meerovich
---
M tests/functional/networkTests.py
1 file changed, 26 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/53498/9
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 0d20c28..412343a 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -53,7 +53,6 @@
from vdsm.commands import execCmd
from vdsm.utils import CommandPath, RollbackContext, pgrep, running
-
from hookValidation import ValidatesHook
from modprobe import RequireDummyMod, RequireVethMod
@@ -100,8 +99,18 @@
@ValidateRunningAsRoot
@RequireDummyMod
def setupModule():
-"""Persists network configuration."""
-getProxy().save_config()
+vds = getProxy()
+running_config, kernel_config = _get_running_and_kernel_config(
+vds.config)
+if ((running_config['networks'] != kernel_config['networks']) or
+(running_config['bonds'] != kernel_config['bonds'])):
+raise SkipTest("Tested host is not clean (running vs kernel):\n"
+ "networks: %r != %r\n"
+ "bonds: %r != %r\n",
+ running_config['networks'], kernel_config['networks'],
+ running_config['bonds'], kernel_config['bonds'])
+
+vds.save_config()
for _ in range(DUMMY_POOL_SIZE):
dummy = Dummy()
dummy.create()
@@ -190,6 +199,18 @@
test_method(*args, **kwargs)
return wrapped_test_method
return wrapper
+
+
+def _get_running_and_kernel_config(bare_running_config):
+""":param config: vdsm configuration, could be retrieved from getProxy()
+"""
+bare_kernel_config = kernelconfig.KernelConfig(
+vdsm.netinfo.cache.CachingNetInfo())
+normalized_running_config = kernelconfig.normalize(bare_running_config)
+# Unify strings to unicode instances so differences are easier to
+# understand. This won't be needed once we move to Python 3.
+return normalized_running_config.as_unicode(),\
+bare_kernel_config.as_unicode()
@expandPermutations
@@ -393,15 +414,8 @@
return status, msg
def _assert_kernel_config_matches_running_config(self):
-bare_kernel_config = kernelconfig.KernelConfig(
-vdsm.netinfo.cache.CachingNetInfo())
-bare_running_config = self.vdsm_net.config
-normalized_running_config = kernelconfig.normalize(bare_running_config)
-# Unify strings to unicode instances so differences are easier to
-# understand. This won't be needed once we move to Python 3.
-running_config = normalized_running_config.as_unicode()
-kernel_config = bare_kernel_config.as_unicode()
-
+running_config, kernel_config = _get_running_and_kernel_config(
+self.vdsm_net.config)
# Do not use KernelConfig.__eq__ to get a better exception if something
# breaks.
self.assertEqual(running_config['networks'], kernel_config['networks'])
--
To view, visit https://gerrit.ovirt.org/53498
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ilia Meerovich
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Ilia Meerovich
Gerrit-Reviewer: Yaniv Kaul
Gerrit-Reviewer: gerrit-hooks
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Edward Haas has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 9: Please run the unit tests and networking functional tests in order to mark 'verified'. -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Edward Haas has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 9: Code-Review+1 (1 comment) This patch is marked as a 'draft', please move it to 'publish'. https://gerrit.ovirt.org/#/c/53498/9/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 212: \ nit: We try to avoid backslash and prefer surrounding the statement with () -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
gerrit-hooks has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Edward Haas has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 8: (2 comments) nits https://gerrit.ovirt.org/#/c/53498/8/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 222: config Just cleanup stuff: rename to bare_running_config Line 231: running_config = normalized_running_config.as_unicode() : kernel_config = bare_kernel_config.as_unicode() : return (running_config, kernel_config) just return it directly: return normalized_running_config.as_unicode(), bare_kernel_config.as_unicode() -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
gerrit-hooks has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Edward Haas has posted comments on this change.
Change subject: Skipping networkTests if alien bonds presents in the system
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/53498/7/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 99:
Line 100: @ValidateRunningAsRoot
Line 101: @RequireDummyMod
Line 102: def setupModule():
Line 103: # getting network bridges
We already check running vs kernel config in the tests.
Reusing it here to assure that the host is 'clean' makes sense. (check
_assert_kernel_config_matches_running_config(self) in the test class)
The only difference is with the assert, so some separation is in order to avoid
duplicate code.
This one is with duplicate code:
#def setupModule():
vds = getProxy()
_assert_kernel_config_matches_running_config(vds.config)
...
vds.save_config()
def _assert_kernel_config_matches_running_config(config):
bare_kernel_config = kernelconfig.KernelConfig(
vdsm.netinfo.cache.CachingNetInfo())
bare_running_config = config
normalized_running_config = kernelconfig.normalize(bare_running_config)
# Unify strings to unicode instances so differences are easier to
# understand. This won't be needed once we move to Python 3.
running_config = normalized_running_config.as_unicode()
kernel_config = bare_kernel_config.as_unicode()
if running_config['networks'] != kernel_config['networks'] or (
running_config['bonds'] != kernel_config['bonds']):
raise SkipTest("Tested host is not clean (running vs kernel):\n"
"networks: %r != %r\n"
"bonds: %r != %r\n",
running_config['networks'], kernel_config['networks'],
running_config['bonds'], kernel_config['bonds'])
Line 104: rc, out, _ = execCmd([EXT_BRCTL, 'show'])
Line 105: if not rc:
Line 106: # removing header line of brctl output and vdsm dummy (if
exists)
Line 107: total_number_of_bonds = \
--
To view, visit https://gerrit.ovirt.org/53498
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ilia Meerovich
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Ilia Meerovich
Gerrit-Reviewer: Yaniv Kaul
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Ilia Meerovich has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 7: verified locally: http://fpaste.org/324026/71381914/ And I have a question: I have noticed that tests are failing very ugly in case that there are no bridges in the system, I can easily prevent running networktests on system without any bridges but I wnat toa sk your opinion before doing that. -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Ilia Meerovich has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 6: > (1 comment) Thanks :) - fixed -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
gerrit-hooks has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Yaniv Kaul has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/53498/6//COMMIT_MSG Commit Message: Line 7: Skipping networkTests if alien bonds presents in the system Line 8: Line 9: Alien bonds causes to tests to report incorrect results Line 10: testing with alien bonds doesnt test vdsm networking Line 11: It make sence since ovirt host shouldn't be used for other sense Line 12: purposes Line 13: Line 14: Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Ilia Meerovich has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 5: > Why won't we test with bonds? > (at least the commit message should explain it) I have added an explanation -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ilia Meerovich Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
gerrit-hooks has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
gerrit-hooks has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
Yaniv Kaul has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 4: Why won't we test with bonds? (at least the commit message should explain it) -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
gerrit-hooks has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
gerrit-hooks has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
gerrit-hooks has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system
gerrit-hooks has posted comments on this change. Change subject: Skipping networkTests if alien bonds presents in the system .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ilia Meerovich Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
