Change in vdsm[master]: Ubuntu: packaging: keep up with vdsm.spec.in
Zhou Zheng Sheng has uploaded a new change for review. Change subject: Ubuntu: packaging: keep up with vdsm.spec.in .. Ubuntu: packaging: keep up with vdsm.spec.in In vdsm.spec.in we add new files and folders, so add those files and folders to Ubuntu packaging scripts as well. Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Signed-off-by: Zhou Zheng Sheng --- M debian/vdsm-tests.install M debian/vdsm.dirs 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/19587/1 diff --git a/debian/vdsm-tests.install b/debian/vdsm-tests.install index 4526d63..ad48def 100644 --- a/debian/vdsm-tests.install +++ b/debian/vdsm-tests.install @@ -7,6 +7,10 @@ usr/share/vdsm/tests/functional/*.policy usr/share/vdsm/tests/functional/*.py usr/share/vdsm/tests/glob_1c60971a-8647-44ac-ae33-6520887f8843.out +usr/share/vdsm/tests/glusterVolumeProfileInfo.xml +usr/share/vdsm/tests/glusterVolumeProfileInfoNfs.xml +usr/share/vdsm/tests/glusterVolumeRebalanceStatus.xml +usr/share/vdsm/tests/glusterVolumeRemoveBricksStatus.xml usr/share/vdsm/tests/lvs_3386c6f2-926f-42c4-839c-38287fac8998.out usr/share/vdsm/tests/netmaskconversions usr/share/vdsm/tests/run_tests.sh diff --git a/debian/vdsm.dirs b/debian/vdsm.dirs index b30e5fc..d33303b 100644 --- a/debian/vdsm.dirs +++ b/debian/vdsm.dirs @@ -2,6 +2,7 @@ etc/pki/vdsm etc/pki/vdsm/certs etc/pki/vdsm/keys +etc/pki/vdsm/libvirt-spice etc/vdsm etc/vdsm/mom.d rhev -- To view, visit http://gerrit.ovirt.org/19587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ubuntu: packaging: keep up with vdsm.spec.in
oVirt Jenkins CI Server has posted comments on this change. Change subject: Ubuntu: packaging: keep up with vdsm.spec.in .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3759/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4568/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4644/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ubuntu: packaging: keep up with vdsm.spec.in
Zhou Zheng Sheng has posted comments on this change. Change subject: Ubuntu: packaging: keep up with vdsm.spec.in .. Patch Set 1: Verified+1 Tested on Ubunt 13.04 and launchpad.net PPA build environment. -- To view, visit http://gerrit.ovirt.org/19587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ubuntu: packaging: keep up with vdsm.spec.in
Alon Bar-Lev has posted comments on this change. Change subject: Ubuntu: packaging: keep up with vdsm.spec.in .. Patch Set 1: You are the maintainer of this :) CC me if you have any doubt... patches added, ugly workarounds etc... BTW: what about engine ubutntu support? -- To view, visit http://gerrit.ovirt.org/19587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ubuntu: packaging: keep up with vdsm.spec.in
Zhou Zheng Sheng has posted comments on this change. Change subject: Ubuntu: packaging: keep up with vdsm.spec.in .. Patch Set 1: Thanks! Till now I did not investigate how to run oVirt Engine on Ubuntu. I think the next step may be adding Ubuntu hosts to oVirt Engine. Trying to make a list of things I hacked in ovirt-host-deploy, but a bit busy these days. -- To view, visit http://gerrit.ovirt.org/19587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ubuntu: packaging: keep up with vdsm.spec.in
Alon Bar-Lev has posted comments on this change. Change subject: Ubuntu: packaging: keep up with vdsm.spec.in .. Patch Set 1: > I think the next step may be adding Ubuntu hosts to oVirt Engine. Trying to > make a list of things I hacked in ovirt-host-deploy I suggest first to make ubuntu engine work and be able to deploy fedora based host, then to focus on host-deploy. -- To view, visit http://gerrit.ovirt.org/19587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ubuntu: packaging: keep up with vdsm.spec.in
Dan Kenigsberg has submitted this change and it was merged. Change subject: Ubuntu: packaging: keep up with vdsm.spec.in .. Ubuntu: packaging: keep up with vdsm.spec.in In vdsm.spec.in we add new files and folders, so add those files and folders to Ubuntu packaging scripts as well. Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Signed-off-by: Zhou Zheng Sheng Reviewed-on: http://gerrit.ovirt.org/19587 Reviewed-by: Dan Kenigsberg --- M debian/vdsm-tests.install M debian/vdsm.dirs 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Verified -- To view, visit http://gerrit.ovirt.org/19587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ubuntu: packaging: keep up with vdsm.spec.in
Dan Kenigsberg has posted comments on this change. Change subject: Ubuntu: packaging: keep up with vdsm.spec.in .. Patch Set 1: Code-Review+2 Zhou, would you send an email to vdsm-devel, asking people to remember Ubuntu when changing the rpm spec? It would be wonderful if you get to have a jenkins Ubuntu slave testing if the package builds properly. -- To view, visit http://gerrit.ovirt.org/19587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ubuntu: packaging: keep up with vdsm.spec.in
Zhou Zheng Sheng has posted comments on this change. Change subject: Ubuntu: packaging: keep up with vdsm.spec.in .. Patch Set 2: Thanks Dan. Mail sent. @Alon, when I do Ubuntu compatibility fix and packaging, I find Ubuntu specific knowledge is not very important, knowing how VDSM works is most important. Ubuntu packaging is easy to learn, they provide many templates, and one can start hacking after reading several pages of the tutorial. The tough problem is how to fit VDSM packaging code into Ubuntu packaging system, the prerequisite skill is that we know VDSM well enough. I think the same case can be applied to oVirt Engine. If someone is already an Engine developer, he can test it on Ubuntu easily, even write packaging scripts. If the case is reverse, someone knows Ubuntu well, but know nothing about oVirt Engine internals, he'd struggled to find the internal details of Engine. So for now I have no plan to introduce oVirt Engine to Ubuntu. Even we have not provided Ubuntu support yet, we can run oVirt Engine in Fedora VM on Ubuntu host, because Engine is a high level management entity. VDSM manages hosts directly, so it must be run on Ubuntu host directly. Once we have Ubuntu hosts, they are useless if we can not add them to Engine. That's why I think adding Ubuntu hosts to oVirt Engine should be done in the first place. -- To view, visit http://gerrit.ovirt.org/19587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
