Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 24: No change in patch set 24. -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 24: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4562/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4484/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3671/ : FAILURE -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 24: -Verified Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4562/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4484/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3679/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Dan Kenigsberg has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 24: Code-Review+1 (1 comment) File lib/vdsm/netconfpersistence.py Line 80: @staticmethod Line 81: def _setConfig(config, path): Line 82: dirPath = os.path.dirname(path) Line 83: try: Line 84: os.makedirs(dirPath) still, why do we even need to create the directory during runtime? Line 85: except OSError as ose: Line 86: if errno.EEXIST != ose.errno: Line 87: raise Line 88: with open(path, 'w') as configurationFile: -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 24: (1 comment) File lib/vdsm/netconfpersistence.py Line 80: @staticmethod Line 81: def _setConfig(config, path): Line 82: dirPath = os.path.dirname(path) Line 83: try: Line 84: os.makedirs(dirPath) I don't know. Antoni? Line 85: except OSError as ose: Line 86: if errno.EEXIST != ose.errno: Line 87: raise Line 88: with open(path, 'w') as configurationFile: -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Mark Wu has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 24: Code-Review+1 (1 comment) File lib/vdsm/netconfpersistence.py Line 80: @staticmethod Line 81: def _setConfig(config, path): Line 82: dirPath = os.path.dirname(path) Line 83: try: Line 84: os.makedirs(dirPath) I guess it's because the dir is only needed when unified persistence is configured. If we choose the static approach, vdsm-tmpfiles.d.conf needs be updated accordingly to make it persist across reboot. Line 85: except OSError as ose: Line 86: if errno.EEXIST != ose.errno: Line 87: raise Line 88: with open(path, 'w') as configurationFile: -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 24: (1 comment) File lib/vdsm/netconfpersistence.py Line 80: @staticmethod Line 81: def _setConfig(config, path): Line 82: dirPath = os.path.dirname(path) Line 83: try: Line 84: os.makedirs(dirPath) It is partly as Mark says. These dirs are only necessary when the configuration vars are set to use "unified". Additionally, and I might be wrong with this, I thought that since /var/run can be a tmpfs, it doesn't hurt to create it just in case. Line 85: except OSError as ose: Line 86: if errno.EEXIST != ose.errno: Line 87: raise Line 88: with open(path, 'w') as configurationFile: -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 25: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3773/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4658/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4582/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 25: Verified+1 Added a modification to the utils checks so that unified persistence is checked on all the tests. Ran all functional tests except the testSafeNetwork and testVolatileConfig, as those need parts of unified persistence that are added in follow up patches. -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [1/4] - Save running config
..
Patch Set 25:
(2 comments)
This patch set is a very good idea Antoni!
File tests/functional/utils.py
Line 186: return bond_name in self.netinfo.bondings and \
Line 187: (not nics or set(nics) ==
Line 188: set(self.netinfo.bondings[bond_name]['slaves'])) and \
Line 189: (self.config is None or
Line 190: (bond_name in self.config.bonds and
What if nics is None?
Line 191: self.config.bonds[bond_name]['nics'] == nics))
Line 192:
Line 193: def vlanExists(self, vlan_name):
Line 194: dev, vlanid = vlan_name.split('.')
Line 190: (bond_name in self.config.bonds and
Line 191: self.config.bonds[bond_name]['nics'] == nics))
Line 192:
Line 193: def vlanExists(self, vlan_name):
Line 194: dev, vlanid = vlan_name.split('.')
To get rid of the 'found' boolean, maybe consider moving the for loop into an
inner function, then use it at the end of the return statement.
Line 195: if self.config is not None:
Line 196: found = False
Line 197: for net, attrs in self.config.networks.iteritems():
Line 198: if (vlanid == attrs.get('vlan') and
--
To view, visit http://gerrit.ovirt.org/16699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Livnat Peer
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Petr Šebek
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 26: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3777/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4662/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4586/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 27: Addressed Assaf's comments. -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 27: Code-Review+1 Thanks Toni :) -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 27: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3778/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4663/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4587/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 27: Verified+1 -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 28: Rebased on top of master so that it doesn't have an extra restoreNetConfig in vdsProxy. -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 28: Build Successful http://jenkins.ovirt.org/job/vdsm_network_functional_tests/643/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4674/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4750/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3865/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Dan Kenigsberg has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 28: Verified+1 Code-Review+2 Copy score from ps27 -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Dan Kenigsberg has submitted this change and it was merged. Change subject: Unified network persistence [1/4] - Save running config .. Unified network persistence [1/4] - Save running config This patch introduces the new persistence model for vdsm networking. It is meant to provide a single reliable way abstracting persistence out of the netconf configurators as much as possible. To achieve its purpose, it stores the network actions as setupNetwork parameters serialized in json which are then used for rollback and initialization. The first patch in the series saves the current state of networks, nics and bonds to a folder. The second patch copies the contents of the running config folder to a startup config folder The third patch uses the startup config folder to restore network configuration to the host upon host boot up. Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Signed-off-by: Assaf Muller Signed-off-by: Antoni S. Puimedon Reviewed-on: http://gerrit.ovirt.org/16699 Reviewed-by: Dan Kenigsberg Tested-by: Dan Kenigsberg --- M lib/vdsm/Makefile.am M lib/vdsm/config.py.in A lib/vdsm/netconfpersistence.py M lib/vdsm/netinfo.py M tests/functional/utils.py M vdsm.spec.in M vdsm/configNetwork.py M vdsm/netconf/__init__.py M vdsm/netconf/ifcfg.py 9 files changed, 287 insertions(+), 14 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
