Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-10-04 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 13: Verified+1 Code-Review+2

Copying ancient score.

-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-10-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Unified network persistence [2/4] Respond to setSafeNetworkConfig

This patch adds setSafeNetwork capabilities to the unified
persistence model. At this stage, it is able to store the running
configuration to /var/lib/vdsm/persistence/netconf/{nets,bonds}
in an atomic way so that it will be available after reboot.

In the following patches there should be added a service that
calls a configurator flushing system that deletes the configurator
persistence bits before networking goes up and instead uses the
unified persistence to restore the network configuration.

Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Signed-off-by: Assaf Muller amul...@redhat.com
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/17009
Reviewed-by: Dan Kenigsberg dan...@redhat.com
Tested-by: Dan Kenigsberg dan...@redhat.com
---
M lib/vdsm/netconfpersistence.py
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/configNetwork.py
M vdsm/vdsm-store-net-config.in
5 files changed, 67 insertions(+), 12 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-10-03 Thread asegurap
Antoni Segura Puimedon has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 13:

Rebased.

-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-10-03 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 13:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/644/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4675/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4751/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3866/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-09-29 Thread asegurap
Antoni Segura Puimedon has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 10: Verified+1

added oVirt node comment and verified on el6.

-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-09-29 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 10:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3775/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4660/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4584/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-09-29 Thread asegurap
Antoni Segura Puimedon has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 11: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-09-29 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 11:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3776/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4661/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4585/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-09-29 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 12:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3781/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4666/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4590/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-09-23 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 9: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-09-23 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 8:

(1 comment)


File lib/vdsm/unifiedpersistence.py
Line 28: import utils
Line 29: 
Line 30: 
Line 31: CONF_RUN_DIR = constants.P_VDSM_RUN + 'netconf/'
Line 32: CONF_PERSIST_DIR = constants.P_VDSM_LIB + 'persistence/netconf/'
I wish you had an in-code comment about it. If you're not in the ovirt-node 
mindset, it's hard to guess the reason.
Line 33: 
Line 34: 
Line 35: class Config(object):
Line 36: def __init__(self, savePath):


-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-09-22 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 9: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4560/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4482/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3669/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-09-12 Thread asegurap
Antoni Segura Puimedon has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 8:

(1 comment)


File lib/vdsm/unifiedpersistence.py
Line 28: import utils
Line 29: 
Line 30: 
Line 31: CONF_RUN_DIR = constants.P_VDSM_RUN + 'netconf/'
Line 32: CONF_PERSIST_DIR = constants.P_VDSM_LIB + 'persistence/netconf/'
This is done like it is because of the inability of the node to persist 
symlinks. The only way to persist symlinks is to persist the directory that 
contains them, so for this reason I created the persisted directory 
persistence in which there are netconf.timestamp dirs and symlinks to the 
current one.
Line 33: 
Line 34: 
Line 35: class Config(object):
Line 36: def __init__(self, savePath):


-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-09-11 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 8: Code-Review-1

(1 comment)


File lib/vdsm/unifiedpersistence.py
Line 28: import utils
Line 29: 
Line 30: 
Line 31: CONF_RUN_DIR = constants.P_VDSM_RUN + 'netconf/'
Line 32: CONF_PERSIST_DIR = constants.P_VDSM_LIB + 'persistence/netconf/'
everything under /var/lib is persisted. I think that /var/lib/vdsm/netconf is 
enough.
Line 33: 
Line 34: 
Line 35: class Config(object):
Line 36: def __init__(self, savePath):


-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-09-09 Thread asegurap
Antoni Segura Puimedon has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 8: Verified+1

Adding networks:
➜  vdsm git:(tans_pers) vdsClient 0 addNetwork bridge=foorr vlan=14 
bond=bond0 nics=p1p4 mtu=1234
Done
➜  vdsm git:(tans_pers) vdsClient 0 addNetwork bridge=foo vlan=15 
bond=bond0 nics=p1p4 mtu=1234
Done

Persisting them:
➜  vdsm git:(tans_pers) vdsClient 0 setSafeNetworkConfig
Done
➜  vdsm git:(tans_pers) ls /var/lib/vdsm/persistence/
netconf  netconf.1378723617
➜  vdsm git:(tans_pers) cat /var/lib/vdsm/persistence/netconf/nets/foo
{bonding: bond0, vlan: 15, mtu: 1234}#
➜  vdsm git:(tans_pers) cat /var/run/vdsm/netconf/nets/foo
{bonding: bond0, vlan: 15, mtu: 1234}#
➜  vdsm git:(tans_pers) cat /var/run/vdsm/netconf/bonds/bond0
{nics: [p1p4], options: mode=802.3ad miimon=150}#
➜  vdsm git:(tans_pers) cat /var/lib/vdsm/persistence/netconf/bonds/bond0
{nics: [p1p4], options: mode=802.3ad miimon=150}#

Checking for selinux conflicts (el6)
➜  vdsm git:(tans_pers) getenforce
Enforcing

After reboot the persistent /var/lib/vdsm/persistence/ contains the same as
before.

-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-09-09 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Unified network persistence [2/4] Respond to 
setSafeNetworkConfig
..


Patch Set 8:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4321/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3424/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4240/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli giuse...@openquake.org
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches