Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 22: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/78/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Dan Kenigsberg has submitted this change and it was merged. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Unified network persistence [4.2/4.*] - Upgrade updates running conf Adds a pre-start task that calls: vdsm-tool upgrade-to-unified-persistence The upgrade gathers networking information and updates the running config of the unified network persistence. Networking persistence currently uses ifcfg files and after the upgrade will use the new model. An explanation of how the new persistence model works can be found at: http://www.ovirt.org/Feature/NetworkReloaded#Unified_persistence Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Signed-off-by: Assaf Muller Reviewed-on: http://gerrit.ovirt.org/18425 Reviewed-by: Yaniv Bronhaim Reviewed-by: Dan Kenigsberg --- M debian/vdsm-python.install M init/vdsmd_init_common.sh.in M lib/vdsm/tool/Makefile.am A lib/vdsm/tool/unified_persistence.py M vdsm.spec.in 5 files changed, 158 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve Assaf Muller: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Dan Kenigsberg has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 21: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Yaniv Bronhaim has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 21: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 21: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5855/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5946/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5059/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/74/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 21: Verified+1 -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 20: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5850/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5942/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5054/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/72/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 19: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5844/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5935/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5047/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/68/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 18:
(1 comment)
File lib/vdsm/tool/unified_persistence.py
Line 138:
Line 139: if upgrade.isNeeded() and unifiedPersistenceUpgrade.isNeeded():
Line 140: upgrade.log.debug("Running upgrade %s" % upgradeName)
Line 141: unifiedPersistenceUpgrade.run()
Line 142: upgrade.seal()
Done
--
To view, visit http://gerrit.ovirt.org/18425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 18: Code-Review-1
(1 comment)
one last comment
File lib/vdsm/tool/unified_persistence.py
Line 138:
Line 139: if upgrade.isNeeded() and unifiedPersistenceUpgrade.isNeeded():
Line 140: upgrade.log.debug("Running upgrade %s" % upgradeName)
Line 141: unifiedPersistenceUpgrade.run()
Line 142: upgrade.seal()
as a command you should return 0 on success or always, raise exception on
failure
--
To view, visit http://gerrit.ovirt.org/18425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 16:
(3 comments)
Commit Message
Line 6:
Line 7: Unified network persistence [4.2/4.*] - Upgrade updates running conf
Line 8:
Line 9: Run a VDSM upgrade that gathers net info and updates the running
Line 10: config of the unified network persistence.
Done
Line 11:
Line 12: Ran using vdsm-tool upgrade mechanism as part of pre-start functions
Line 13: in init/vdsmd_init_common.sh.in
Line 14:
File lib/vdsm/tool/unified_persistence.py
Line 124: runningConfig.save()
Line 125: runningConfig.store()
Line 126:
Line 127:
Line 128: @expose('unified-persistence')
Done
Line 129: def unified_persistence():
Line 130: """
Line 131: Upgrade host networking persistence from ifcfg to unified if the
Line 132: persistence model is set as unified in
/usr/lib64/python2.X/site-packages/
Line 129: def unified_persistence():
Line 130: """
Line 131: Upgrade host networking persistence from ifcfg to unified if the
Line 132: persistence model is set as unified in
/usr/lib64/python2.X/site-packages/
Line 133: vdsm/config.py
Ball's in your court.
Line 134: """
Line 135: unifiedPersistenceUpgrade = UnifiedPersistence()
Line 136: upgradeName = UnifiedPersistence.__name__
Line 137: upgrade = Upgrade(upgradeName)
--
To view, visit http://gerrit.ovirt.org/18425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 18: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4779/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5579/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5662/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4729/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5608/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 17: Patch set 17 is a rebase. -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 16:
(1 comment)
File lib/vdsm/tool/unified_persistence.py
Line 29: networks, bondings = self._getNetInfo()
Line 30: self._persist(networks, bondings)
Line 31:
Line 32: def isNeeded(self):
Line 33: return config.get('vars', 'persistence') == 'unified'
ok
Line 34:
Line 35: def _toIfcfgFormat(self, value):
Line 36: filter = {'on': 'yes', 'off': 'no'}
Line 37: # If value is in the dict and hashable - Get its filtered
value.
--
To view, visit http://gerrit.ovirt.org/18425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Antoni Segura Puimedon has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 16:
(1 comment)
File lib/vdsm/tool/unified_persistence.py
Line 29: networks, bondings = self._getNetInfo()
Line 30: self._persist(networks, bondings)
Line 31:
Line 32: def isNeeded(self):
Line 33: return config.get('vars', 'persistence') == 'unified'
I'm afraid I have to disagree with this comment. This would be a good
suggestion if the "==" would not return a boolean or if we wanted to return
something constructed upon said boolean. As it is in the patch it is simpler.
Line 34:
Line 35: def _toIfcfgFormat(self, value):
Line 36: filter = {'on': 'yes', 'off': 'no'}
Line 37: # If value is in the dict and hashable - Get its filtered
value.
--
To view, visit http://gerrit.ovirt.org/18425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 16:
(1 comment)
File lib/vdsm/tool/unified_persistence.py
Line 124: runningConfig.save()
Line 125: runningConfig.store()
Line 126:
Line 127:
Line 128: @expose('unified-persistence')
dan suggested "upgrade-to-unified-persistence"
Line 129: def unified_persistence():
Line 130: """
Line 131: Upgrade host networking persistence from ifcfg to unified if the
Line 132: persistence model is set as unified in
/usr/lib64/python2.X/site-packages/
--
To view, visit http://gerrit.ovirt.org/18425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 16:
(3 comments)
Commit Message
Line 6:
Line 7: Unified network persistence [4.2/4.*] - Upgrade updates running conf
Line 8:
Line 9: Run a VDSM upgrade that gathers net info and updates the running
Line 10: config of the unified network persistence.
you can just say:
This patch adds pre-start task that runs vdsm-tool upgrade which does blah blah
more clear imo..
Line 11:
Line 12: Ran using vdsm-tool upgrade mechanism as part of pre-start functions
Line 13: in init/vdsmd_init_common.sh.in
Line 14:
File lib/vdsm/tool/unified_persistence.py
Line 29: networks, bondings = self._getNetInfo()
Line 30: self._persist(networks, bondings)
Line 31:
Line 32: def isNeeded(self):
Line 33: return config.get('vars', 'persistence') == 'unified'
I prefer:
return True if config.get('vars', 'persistence') == 'unified' else False
Line 34:
Line 35: def _toIfcfgFormat(self, value):
Line 36: filter = {'on': 'yes', 'off': 'no'}
Line 37: # If value is in the dict and hashable - Get its filtered
value.
Line 129: def unified_persistence():
Line 130: """
Line 131: Upgrade host networking persistence from ifcfg to unified if the
Line 132: persistence model is set as unified in
/usr/lib64/python2.X/site-packages/
Line 133: vdsm/config.py
way too long. this info is provided as help string on the command.. can't you
find something more sufficient and short ?
Line 134: """
Line 135: unifiedPersistenceUpgrade = UnifiedPersistence()
Line 136: upgradeName = UnifiedPersistence.__name__
Line 137: upgrade = Upgrade(upgradeName)
--
To view, visit http://gerrit.ovirt.org/18425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Yaniv Bronhaim has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 16: (1 comment) File lib/vdsm/tool/unified_persistence.py Line 129: def unified_persistence(): Line 130: """ Line 131: Upgrade host networking persistence from ifcfg to unified if the Line 132: persistence model is set as unified in /usr/lib64/python2.X/site-packages/ Line 133: vdsm/config.py after seeing http://gerrit.ovirt.org/#/c/20803/3/lib/vdsm/tool/upgrade_300_networks.py , I understand that you are not the only one that provides such explanation here. I'll try to think about better solution for detailed and short description Line 134: """ Line 135: unifiedPersistenceUpgrade = UnifiedPersistence() Line 136: upgradeName = UnifiedPersistence.__name__ Line 137: upgrade = Upgrade(upgradeName) -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4484/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5284/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5362/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 15: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4481/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5281/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5359/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 14: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4458/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5260/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5338/ : FAILURE -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 14: Verified+1 Verification: Compared manually what the unified network persistence produces and what the upgrade produces for the following networking permutations: IP: none, dhcp, static Topology: nic or bond, vlan or non-vlan, bridged or non-bridged Total 24 combinations. I then used most of the functional tests to see what they produce and what the upgrade produces. -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 13:
(5 comments)
Commit Message
Line 6:
Line 7: Unified network persistence [4.2/4.*] - Upgrade updates running conf
Line 8:
Line 9: Run a VDSM upgrade that gathers net info and updates the running
Line 10: config of the unified network persistence.
Done
Line 11:
Line 12: To-Do:
Line 13: * Bonds that don't have a network over them are unnoticed
Line 14:
File lib/vdsm/tool/Makefile.am
Line 43:restore_nets.py \
Line 44:sanlock.py \
Line 45:seboolsetup.py \
Line 46:service.py \
Line 47:unifiedPersistence.py \
Done
Line 48:upgrade.py \
Line 49:vdsm-id.py \
Line 50:$(NULL)
Line 51:
File lib/vdsm/tool/unifiedPersistence.py
Line 41: except TypeError:
Line 42: return value
Line 43:
Line 44: def _getNetInfo(self):
Line 45: _netinfo = NetInfo()
Done
Line 46: networks = {}
Line 47: bondings = {}
Line 48: whitelist = ['bridged', 'mtu', 'qosInbound', 'qosOutbound']
Line 49: toCaps = ['stp']
Line 110: runningConfig.store()
Line 111:
Line 112:
Line 113: @expose('unifiedPersistence')
Line 114: def main():
Done
Line 115: unifiedPersistenceUpgrade = UnifiedPersistence()
Line 116: upgradeName = UnifiedPersistence.__name__
Line 117: upgrade = Upgrade(upgradeName)
Line 118:
Line 116: upgradeName = UnifiedPersistence.__name__
Line 117: upgrade = Upgrade(upgradeName)
Line 118:
Line 119: if upgrade.isNeeded() and unifiedPersistenceUpgrade.isNeeded():
Line 120: upgrade.log.debug("Running upgrade %s" % upgradeName)
Still under discussion in previous patch.
Line 121: unifiedPersistenceUpgrade.run()
--
To view, visit http://gerrit.ovirt.org/18425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 13:
(5 comments)
looks good. some small comments
Commit Message
Line 6:
Line 7: Unified network persistence [4.2/4.*] - Upgrade updates running conf
Line 8:
Line 9: Run a VDSM upgrade that gathers net info and updates the running
Line 10: config of the unified network persistence.
as part of pre-start functions
Line 11:
Line 12: To-Do:
Line 13: * Bonds that don't have a network over them are unnoticed
Line 14:
File lib/vdsm/tool/Makefile.am
Line 43:restore_nets.py \
Line 44:sanlock.py \
Line 45:seboolsetup.py \
Line 46:service.py \
Line 47:unifiedPersistence.py \
call it unified_persistence as all the others
Line 48:upgrade.py \
Line 49:vdsm-id.py \
Line 50:$(NULL)
Line 51:
File lib/vdsm/tool/unifiedPersistence.py
Line 41: except TypeError:
Line 42: return value
Line 43:
Line 44: def _getNetInfo(self):
Line 45: _netinfo = NetInfo()
why netinfo gets underscore and all other private variables dont?
Line 46: networks = {}
Line 47: bondings = {}
Line 48: whitelist = ['bridged', 'mtu', 'qosInbound', 'qosOutbound']
Line 49: toCaps = ['stp']
Line 110: runningConfig.store()
Line 111:
Line 112:
Line 113: @expose('unifiedPersistence')
Line 114: def main():
why main?
call it unified-persistence please, to fit all vdsm-tool verbs
Line 115: unifiedPersistenceUpgrade = UnifiedPersistence()
Line 116: upgradeName = UnifiedPersistence.__name__
Line 117: upgrade = Upgrade(upgradeName)
Line 118:
Line 116: upgradeName = UnifiedPersistence.__name__
Line 117: upgrade = Upgrade(upgradeName)
Line 118:
Line 119: if upgrade.isNeeded() and unifiedPersistenceUpgrade.isNeeded():
Line 120: upgrade.log.debug("Running upgrade %s" % upgradeName)
print it to stdout
Line 121: unifiedPersistenceUpgrade.run()
--
To view, visit http://gerrit.ovirt.org/18425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4743/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4819/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3934/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4737/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4813/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3928/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 11: Code-Review-1
(4 comments)
Commit Message
Line 10: config of the unified network persistence.
Line 11:
Line 12: To-Do:
Line 13: * Bonds that don't have a network over them are unnoticed
Line 14:
where is a link to 4.3 as you put in 4.1?
Line 15: Change-Id: I051b0f168b6357e60184409845ea410c5891b083
File lib/vdsm/tool/unifiedPersistence.py
Line 21: from vdsm.config import config
Line 22: from vdsm.netconfpersistence import RunningConfig
Line 23: from vdsm.tool import expose
Line 24:
Line 25: from vdsm.tool.upgrade import Upgrade
only here you use upgrade.py, squash both to one patch
Line 26:
Line 27:
Line 28: class UnifiedPersistence(Upgrade):
Line 29: def __init__(self):
Line 117: runningConfig.store()
Line 118:
Line 119:
Line 120: @expose('unifiedPersistence')
Line 121: def main():
add explanation. please follow previous comments, wrote it in last ps.
File vdsm/vdsmd.init.in
Line 261: return 1
Line 262: fi
Line 263:
Line 264: "$VDSM_TOOL" unifiedPersistence
Line 265:
you haven't rebased as I suggested. you should move this call to
vdsmd_init_common.sh.in
Line 266: echo $"Starting up vdsm daemon: "
Line 267: local vdsm_nice="$("${GETCONFITEM}" "${CONF_FILE}" vars vdsm_nice
-5)"
Line 268:
Line 269: LIBVIRT_LOG_FILTERS="$("${GETCONFITEM}" "${CONF_FILE}" vars
libvirt_env_variable_log_filters "")" \
--
To view, visit http://gerrit.ovirt.org/18425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4569/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4491/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3683/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
