Change in vdsm[master]: WIP: Makefile: changed tests Makefile so that both python2 a...

2016-05-10 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: WIP: Makefile: changed tests Makefile so that both python2 and 
pyhton3 will be default. That way, all tests (including new ones) will have to 
support python3 eventually.
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/57106/2/tests/Makefile.am
File tests/Makefile.am:

Line 382:   for m in $(run_modules) ; do \
Line 383:   if ! [[ "$(blacklist_modules_python3)" =~ "$$m" 
]]; \
Line 384:   then \
Line 385:   PYTHON_EXE="$(PYTHON3)" \
Line 386:   $(top_srcdir)/tests/run_tests_local.sh 
$$m; \
> can't we add some kind of --exclude flag to run_tests_local and then just c
If you go that path, in a separate patch we can move everything there:

args += --python3
$(top_srcdir)/tests/run_tests_local.sh $(args) $(run_modules)
Line 387:   fi \
Line 388:   done; \


-- 
To view, visit https://gerrit.ovirt.org/57106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: Makefile: changed tests Makefile so that both python2 a...

2016-05-09 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: WIP: Makefile: changed tests Makefile so that both python2 and 
pyhton3 will be default. That way, all tests (including new ones) will have to 
support python3 eventually.
..


Patch Set 2:

(4 comments)

https://gerrit.ovirt.org/#/c/57106/2/tests/Makefile.am
File tests/Makefile.am:

Line 28:  integration \
Line 29:  network \
Line 30:  $(NULL)
Line 31: 
Line 32: test_modules_py3 = \
you should remove this list I guess
Line 33:apiData.py \
Line 34:cmdutilsTests.py \
Line 35:concurrentTests.py \
Line 36:cpuinfo_test.py \


Line 155:   vdscliTests.py \
Line 156:   vdsClientTests.py \
Line 157:   vdsmDumpChainsTests.py \
Line 158:   verify.py \
Line 159:   virt_api_test.py \
adding those tests can be in separate patch
Line 160:   vmApiTests.py \
Line 161:   vmfakelibTests.py \
Line 162:   vmMigrationTests.py \
Line 163:   vmOperationsTests.py \


Line 170:   vmUtilsTests.py \
Line 171:   vmXmlTests.py \
Line 172:   v2vTests.py \
Line 173:   $(NULL)
Line 174: 
add comment # list of tests modules that don't pass in py3
Line 175: blacklist_modules_python3 = \
Line 176:   alignmentScanTests.py \
Line 177:   blockVolumeTests.py \
Line 178:   blocksdTests.py \


Line 382:   for m in $(run_modules) ; do \
Line 383:   if ! [[ "$(blacklist_modules_python3)" =~ "$$m" 
]]; \
Line 384:   then \
Line 385:   PYTHON_EXE="$(PYTHON3)" \
Line 386:   $(top_srcdir)/tests/run_tests_local.sh 
$$m; \
can't we add some kind of --exclude flag to run_tests_local and then just call 
it once with run_tests.sh run_modules --exclude backlist_modules? later if 
we'll use py.tests you have the --ignore= option inside
Line 387:   fi \
Line 388:   done; \


-- 
To view, visit https://gerrit.ovirt.org/57106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: Makefile: changed tests Makefile so that both python2 a...

2016-05-09 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: WIP: Makefile: changed tests Makefile so that both python2 and 
pyhton3 will be default. That way, all tests (including new ones) will have to 
support python3 eventually.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: Makefile: changed tests Makefile so that both python2 a...

2016-05-05 Thread igoihman 
Irit Goihman has uploaded a new change for review.

Change subject: WIP: Makefile: changed tests Makefile so that both python2 and 
pyhton3 will be default. That way, all tests (including new ones) will have to 
support python3 eventually.
..

WIP: Makefile: changed tests Makefile so that both python2 and pyhton3 will
be default.
That way, all tests (including new ones) will have to support python3 
eventually.

Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043
Signed-off-by: Irit Goihman 
---
M tests/Makefile.am
1 file changed, 100 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/57106/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index a1505e3..7cd5649 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -170,6 +170,106 @@
v2vTests.py \
$(NULL)
 
+blacklist_modules_python3 = \
+   vmRecoveryTests.py \
+   domain_manifest_test.py \
+   network/config_network_test.py \
+   network/netinfo_test.py \
+   imagetickets_test.py \
+   vmSecretTests.py \
+   network/hook_ovs_test.py \
+   encodingTests.py \
+   mountTests.py \
+   network/ip_test.py \
+   vmXmlTests.py \
+   network/conf_test.py \
+   guestagentTests.py \
+   network/sourcerouting_test.py \
+   mkimageTests.py \
+   common/contextlib_test.py \
+   network/conf_persistence_test.py \
+   hooksTests.py \
+   vdsmDumpChainsTests.py \
+   devices/parsing/complex_vm_tests.py \
+   storagetestlibTests.py \
+   utilsTests.py \
+   network/qos_test.py \
+   network/connectivity_test.py \
+   vmTests.py \
+   miscTests.py \
+   vmUtilsTests.py \
+   fuserTests.py \
+   stompAsyncDispatcherTests.py \
+   storageServerTests.py \
+   bridgeTests.pybulk_sampling_test.py \
+   storageMailboxTests.py \
+   commands_test.py \
+   periodicTests.py \
+   securableTests.py \
+   alignmentScanTests.py \
+   hostdevTests.py \
+   stompTests.py \
+   vmOperationsTests.py \
+   momTests.py \
+   fileUtilTests.py \
+   numaUtilsTests.py \
+   iscsiTests.py \
+   testlibTests.py \
+   schemaValidationTest.py \
+   toolTests.py \
+   stompAsyncClientTests.py \
+   sdm_indirection_tests.py \
+   v2vTests.py \
+   network/unified_persistence_test.py \
+   protocoldetectorTests.py \
+   fileVolumeTests.py \
+   network/link_test.py \
+   network/ipwrapper_test.py \
+   cPopenTests.py \
+   lvmTests.py \
+   hoststatsTests.py \
+   clientifTests.py \
+   resourceManagerTests.py \
+   gluster_cli_tests.py \
+   vdsClientTests.py \
+   monkeypatchTests.py \
+   sparsifyTests.py \
+   vmApiTests.py \
+   vdscliTests.py \
+   network/iproute2_test.py \
+   outOfProcessTests.py \
+   vmStorageTests.py \
+   storage_sdm_create_volume_test.py \
+   samplingTests.py \
+   momPolicyTests.py \
+   capsTests.py \
+   persistentDictTests.py \
+   qemuimgTests.py \
+   deviceTests.py \
+   storageMonitorTests.py \
+   storage_volume_artifacts_test.py \
+   blocksdTests.py \
+   network/tc_test.py \
+   fileSDTests.py \
+   storagefakelibTests.py \
+   stompAdapterTests.py \
+   blockVolumeTests.py \
+   vmfakelibTests.py \
+   storage_sdm_api_test.py \
+   toolBondingTests.py \
+   common/network_test.py \
+   schemaTests.py \
+   network/ovs_test.py \
+   transportWrapperTests.py \
+   libvirtconnectionTests.py \
+   main.py \
+   unicode_test.py \
+   storage_rwlock_test.py \
+   tasksetTests.py \
+   vmMigrationTests.py \
+   verify.py \
+   $(NULL)
+
 nodist_vdsmtests_PYTHON = \
crossImportsTests.py \
$(NULL)


-- 
To view, visit https://gerrit.ovirt.org/57106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: Makefile: changed tests Makefile so that both python2 a...

2016-05-05 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: WIP: Makefile: changed tests Makefile so that both python2 and 
pyhton3 will be default. That way, all tests (including new ones) will have to 
support python3 eventually.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches