Change in vdsm[master]: addNetwork script: Prevent empty bond and vlan from reaching...
oVirt Jenkins CI Server has posted comments on this change. Change subject: addNetwork script: Prevent empty bond and vlan from reaching RunningConfig .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11734/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12678/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2008/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12523/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: addNetwork script: Prevent empty bond and vlan from reaching...
Dan Kenigsberg has submitted this change and it was merged. Change subject: addNetwork script: Prevent empty bond and vlan from reaching RunningConfig .. addNetwork script: Prevent empty bond and vlan from reaching RunningConfig The consumers of the addNetwork script pass empty parameters, e.g. in order to fill the positional arguments that the script takes. The problem with that is that those parameters were being passed to addNetwork without modification, and that includes the _alterNetworkConfig wrapper that makes addNetwork requests reach runningConfig (and eventually PersistentConfig). Due to the issue above, a stored network could contain entries like 'bonding': '' and 'vlan': '' that would mess with selective network restoration. Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Bug-Url: https://bugzilla.redhat.com/1144639 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33510 Reviewed-by: Douglas Schilling Landgraf dougsl...@redhat.com Tested-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/network/api.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: addNetwork script: Prevent empty bond and vlan from reaching...
Dan Kenigsberg has posted comments on this change. Change subject: addNetwork script: Prevent empty bond and vlan from reaching RunningConfig .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: addNetwork script: Prevent empty bond and vlan from reaching...
oVirt Jenkins CI Server has posted comments on this change. Change subject: addNetwork script: Prevent empty bond and vlan from reaching RunningConfig .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/244/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5877/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4037/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/47/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/43/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/49/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/23/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
