Change in vdsm[master]: automation: add a repo with a fresh nose

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: automation: add a repo with a fresh nose
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: automation: add a repo with a fresh nose

2016-09-15 Thread danken
Dan Kenigsberg has uploaded a new change for review.

Change subject: automation: add a repo with a fresh nose
..

automation: add a repo with a fresh nose

We need nose >= 1.3.7 to test vdsm, but don't have it on el7. One option
discussed is not to run test when building for el7. As a quick-and dirty
fix for upstream, this patch pulls nose from CentOS virt SIG. It does
NOT solve the problem when building in brew or koji.

Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599
Signed-off-by: Dan Kenigsberg 
---
M automation/check-patch.repos.el7
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/63986/1

diff --git a/automation/check-patch.repos.el7 b/automation/check-patch.repos.el7
index 405074d..aa2ab18 100644
--- a/automation/check-patch.repos.el7
+++ b/automation/check-patch.repos.el7
@@ -6,3 +6,4 @@
 lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/$distro
 epel,http://download.fedoraproject.org/pub/epel/7/$basearch/
 centos-debuginfo,http://debuginfo.centos.org/7/x86_64/
+centos-ovirt-common-candidate,http://cbs.centos.org/repos/virt7-ovirt-common-candidate/$basearch/os/


-- 
To view, visit https://gerrit.ovirt.org/63986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: automation: add a repo with a fresh nose

2016-09-15 Thread sbonazzo
Sandro Bonazzola has posted comments on this change.

Change subject: automation: add a repo with a fresh nose
..


Patch Set 1: Verified+1

Worked fine: 
http://jenkins.ovirt.org/job/vdsm_master_build-artifacts-el7-x86_64/839/

-- 
To view, visit https://gerrit.ovirt.org/63986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: automation: add a repo with a fresh nose

2016-09-15 Thread igoihman
Irit Goihman has posted comments on this change.

Change subject: automation: add a repo with a fresh nose
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: automation: add a repo with a fresh nose

2016-09-15 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: automation: add a repo with a fresh nose
..


Patch Set 1: Code-Review+1

This fixes the build in jenkins, but does not fix the build in brew/koji.

-- 
To view, visit https://gerrit.ovirt.org/63986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: automation: add a repo with a fresh nose

2016-09-15 Thread edwardh
Edward Haas has posted comments on this change.

Change subject: automation: add a repo with a fresh nose
..


Patch Set 1:

This makes no sense to me, it's a mess.
I am reverting the nose 1.3.7 hard requirement.

-- 
To view, visit https://gerrit.ovirt.org/63986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: automation: add a repo with a fresh nose

2016-09-15 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: automation: add a repo with a fresh nose
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: automation: add a repo with a fresh nose

2016-09-15 Thread danken
Dan Kenigsberg has submitted this change and it was merged.

Change subject: automation: add a repo with a fresh nose
..


automation: add a repo with a fresh nose

We need nose >= 1.3.7 to test vdsm, but don't have it on el7. One option
discussed is not to run test when building for el7. As a quick-and dirty
fix for upstream, this patch pulls nose from CentOS virt SIG. It does
NOT solve the problem when building in brew or koji.

Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/63986
Continuous-Integration: Jenkins CI
Tested-by: Sandro Bonazzola 
Reviewed-by: Irit Goihman 
Reviewed-by: Nir Soffer 
---
M automation/check-patch.repos.el7
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Sandro Bonazzola: Verified
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/63986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: automation: add a repo with a fresh nose

2016-09-15 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: automation: add a repo with a fresh nose
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org