Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 3: Build Started (5/10) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/854/ -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/848/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/443/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4829/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/820/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/448/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/854/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/438/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/854/ : FAILURE http://jenkins.ovirt.org/job/sshnaidm_vdsm_master_create-rpms-fc21-ppc64_merged/15/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/452/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 3: Build Started (10/10) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/820/ -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 3: Build Started (9/10) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/448/ -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 3: Build Started (8/10) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/438/ -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 3: Build Started (7/10) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/452/ -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 3: Build Started (6/10) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/854/ -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 3: Build Started (3/10) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/443/ -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 3: Build Started (4/10) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/848/ -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
Dan Kenigsberg has submitted this change and it was merged. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. betterAsyncore: Fix event loop data stealing [1/2] When a dispatcher is removed from the event loop from a handle_read() handler, and the underlying socket has pending data, the event loop could steal data from the socket, invoking handle_read() multiple times, detecting multiple connections for one connection. In this patch we add little sleep before handling the request in the protocol detectors, revealing this issue in the protocolDetector tests. Following is protocol detector log from failing test_detect_uppercase(use_ssl=True), sending one request: >> begin captured logging << vds.MultiProtocolAcceptor: INFO: Listening at 127.0.0.1:39304 vds.MultiProtocolAcceptor: DEBUG: Adding detector vds.MultiProtocolAcceptor: DEBUG: Adding detector vds.MultiProtocolAcceptor: DEBUG: Running ProtocolDetector.AcceptorImpl: INFO: Accepting connection from 127.0.0.1:32855 ProtocolDetector.Detector: DEBUG: Using required_size=9 ProtocolDetector.Detector: INFO: Detected protocol uppercase from 127.0.0.1:32855 ProtocolDetector.Detector: INFO: Detected protocol uppercase from 127.0.0.1:32855 ProtocolDetector.Detector: INFO: Detected protocol uppercase from 127.0.0.1:32855 ProtocolDetector.Detector: INFO: Detected protocol uppercase from 127.0.0.1:32855 ProtocolDetector.Detector: WARNING: Unrecognized protocol: ' testing ' - >> end captured logging << - Note that same connection from 127.0.0.1:32855 was detected 5 times! In the application, this would cause one connection to be handled by multiple threads in xmlrpc or jsonrpc servers. The last event show data stealing - "uppercase: " was stolen from the socket buffer by the event loop. Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/39513 Reviewed-by: Piotr Kliczewski Reviewed-by: Francesco Romani Reviewed-by: Federico Simoncelli --- M tests/protocoldetectorTests.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 3: Build Started (2/10) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4829/ -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 3: Build Started (1/10) -> http://jenkins.ovirt.org/job/sshnaidm_vdsm_master_create-rpms-fc21-ppc64_merged/15/ -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
automat...@ovirt.org has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
Federico Simoncelli has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
Francesco Romani has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17462/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17636/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
Nir Soffer has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 2: Verified on fedora 20 and rhel 7. -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17636/ -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
automat...@ovirt.org has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17462/ -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
Piotr Kliczewski has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
Nir Soffer has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17460/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17634/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17634/ -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
automat...@ovirt.org has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
Nir Soffer has uploaded a new change for review. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. betterAsyncore: Fix event loop data stealing [1/2] When a dispatcher is removed from the event loop from a handle_read() handler, and the underlying socket has pending data, the event loop could steal data from the socket, invoking handle_read() multiple times. In this patch we add little sleep before handling the request in the protocol detectors, revealing this issue in the protocolDetector tests. Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Signed-off-by: Nir Soffer --- M tests/protocoldetectorTests.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/39513/1 diff --git a/tests/protocoldetectorTests.py b/tests/protocoldetectorTests.py index 8ef1582..297537d 100644 --- a/tests/protocoldetectorTests.py +++ b/tests/protocoldetectorTests.py @@ -49,6 +49,9 @@ dispatcher.del_channel() def run(): +# Wait to detect case where the event loop steals data from +# the socket after the dispatcher was removed. +time.sleep(0.05) try: request = "" while "\n" not in request: -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
oVirt Jenkins CI Server has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17460/ -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
