Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

2016-09-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

2016-09-14 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..


build tests: Require NOSE 1.3.7 and up for running tests

On RHEL7/Centos7 the provided NOSE version is 1.3.0.
CI runs the tests with 1.3.7.

To be consistent and avoid different behaviours, assure that the tests
are running with a minimum nose version of 1.3.7.

Specifically, between 1.3.0 and 1.3.7 a bug has been resolved regarding
test labeling and its support with test class inheritance.

Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/63638
Continuous-Integration: Jenkins CI
Reviewed-by: Petr Horáček 
Reviewed-by: Irit Goihman 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Piotr Kliczewski 
---
M Makefile.am
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Irit Goihman: Looks good to me, but someone else must approve
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

2016-09-14 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

2016-09-13 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

2016-09-13 Thread igoihman 
Irit Goihman has posted comments on this change.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

2016-09-12 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

2016-09-12 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

2016-09-11 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

2016-09-11 Thread edwardh 
Edward Haas has uploaded a new change for review.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..

build tests: Require NOSE 1.3.7 and up for running tests

On RHEL7/Centos7 the provided NOSE version is 1.3.0.
CI runs the tests with 1.3.7.

To be consistent and avoid different behaviours, assure that the tests
are running with a minimum nose version of 1.3.7.

Specifically, between 1.3.0 and 1.3.7 a bug has been resolved regarding
test labeling and its support with test class inheritance.

Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Signed-off-by: Edward Haas 
---
M Makefile.am
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/63638/1

diff --git a/Makefile.am b/Makefile.am
index 40ddeb8..64cd9a0 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -138,7 +138,12 @@
 
 .PHONY: tests
 tests:
-   $(MAKE) -C tests/ check
+   @version=`nosetests --version | cut -d' ' -f3`; \
+   if build-aux/vercmp $$version "1.3.7"; then \
+ echo "Error: NOSE is too old, please install NOSE 1.3.7 or later"; \
+ exit 1; \
+   fi
+   @$(MAKE) -C tests/ check
 
 all-local: \
vdsm.spec


-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

2016-09-11 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org