Change in vdsm[master]: configfile: remove no longer used methods. vdsm is no l...
Jenkins CI RO has abandoned this change. Change subject: configfile: remove no longer used methods. vdsm is no longer involved in libvirt log rotation since 33925 and we can remove prefixLines and prependSection. .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/36324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Icf08bfebc83a9af5eb3c7de48f9a51d2263766fd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-Reviewer: mooli tayer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configfile: remove no longer used methods. vdsm is no l...
gerrit-hooks has posted comments on this change. Change subject: configfile: remove no longer used methods. vdsm is no longer involved in libvirt log rotation since 33925 and we can remove prefixLines and prependSection. .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/36324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf08bfebc83a9af5eb3c7de48f9a51d2263766fd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configfile: remove no longer used methods. vdsm is no l...
Dan Kenigsberg has posted comments on this change. Change subject: configfile: remove no longer used methods. vdsm is no longer involved in libvirt log rotation since 33925 and we can remove prefixLines and prependSection. .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/36324/3/lib/vdsm/tool/configfile.py File lib/vdsm/tool/configfile.py: Line 127: continue Line 128: Line 129: if not self._remove or self._rmstate != WITHIN: Line 130: if self._prefixRemove: Line 131: # todo: remove once from 3.5 not supported > I don't see anywhere such comment in vdsm REQUIRED_FOR is added when we have ugly legacy code that we want to drop in the future. Line 132: prefix = '# VDSM backup' Line 133: if line.startswith(prefix): Line 134: line = line[len(prefix):] Line 135: m = confpat.match(line.rstrip()) -- To view, visit https://gerrit.ovirt.org/36324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf08bfebc83a9af5eb3c7de48f9a51d2263766fd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configfile: remove no longer used methods. vdsm is no l...
Yaniv Bronhaim has posted comments on this change. Change subject: configfile: remove no longer used methods. vdsm is no longer involved in libvirt log rotation since 33925 and we can remove prefixLines and prependSection. .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/36324/3/lib/vdsm/tool/configfile.py File lib/vdsm/tool/configfile.py: Line 127: continue Line 128: Line 129: if not self._remove or self._rmstate != WITHIN: Line 130: if self._prefixRemove: Line 131: # todo: remove once from 3.5 not supported > use our legacy-related comment I don't see anywhere such comment in vdsm look below also - # remove this if at 4.0. see 'Backward compatibility' - this also doesn't sound like some kind of our "standard".. Maybe you meant to something else? " # for 3.5 backward compatibility " will do it for you? Line 132: prefix = '# VDSM backup' Line 133: if line.startswith(prefix): Line 134: line = line[len(prefix):] Line 135: m = confpat.match(line.rstrip()) -- To view, visit https://gerrit.ovirt.org/36324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf08bfebc83a9af5eb3c7de48f9a51d2263766fd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configfile: remove no longer used methods. vdsm is no l...
Dan Kenigsberg has posted comments on this change. Change subject: configfile: remove no longer used methods. vdsm is no longer involved in libvirt log rotation since 33925 and we can remove prefixLines and prependSection. .. Patch Set 3: Code-Review-1 (1 comment) very partial review https://gerrit.ovirt.org/#/c/36324/3/lib/vdsm/tool/configfile.py File lib/vdsm/tool/configfile.py: Line 127: continue Line 128: Line 129: if not self._remove or self._rmstate != WITHIN: Line 130: if self._prefixRemove: Line 131: # todo: remove once from 3.5 not supported use our legacy-related comment REQUIRE_FOR: upgrade from ovirt-3.5 Line 132: prefix = '# VDSM backup' Line 133: if line.startswith(prefix): Line 134: line = line[len(prefix):] Line 135: m = confpat.match(line.rstrip()) -- To view, visit https://gerrit.ovirt.org/36324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf08bfebc83a9af5eb3c7de48f9a51d2263766fd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configfile: remove no longer used methods. vdsm is no l...
Yaniv Bronhaim has posted comments on this change. Change subject: configfile: remove no longer used methods. vdsm is no longer involved in libvirt log rotation since 33925 and we can remove prefixLines and prependSection. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/36324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf08bfebc83a9af5eb3c7de48f9a51d2263766fd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configfile: remove no longer used methods. vdsm is no l...
oVirt Jenkins CI Server has posted comments on this change. Change subject: configfile: remove no longer used methods. vdsm is no longer involved in libvirt log rotation since 33925 and we can remove prefixLines and prependSection. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17832/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17661/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/36324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf08bfebc83a9af5eb3c7de48f9a51d2263766fd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configfile: remove no longer used methods. vdsm is no l...
oVirt Jenkins CI Server has posted comments on this change. Change subject: configfile: remove no longer used methods. vdsm is no longer involved in libvirt log rotation since 33925 and we can remove prefixLines and prependSection. .. Patch Set 3: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17832/ -- To view, visit https://gerrit.ovirt.org/36324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf08bfebc83a9af5eb3c7de48f9a51d2263766fd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configfile: remove no longer used methods. vdsm is no l...
oVirt Jenkins CI Server has posted comments on this change. Change subject: configfile: remove no longer used methods. vdsm is no longer involved in libvirt log rotation since 33925 and we can remove prefixLines and prependSection. .. Patch Set 3: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17661/ -- To view, visit https://gerrit.ovirt.org/36324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf08bfebc83a9af5eb3c7de48f9a51d2263766fd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configfile: remove no longer used methods. vdsm is no l...
automat...@ovirt.org has posted comments on this change. Change subject: configfile: remove no longer used methods. vdsm is no longer involved in libvirt log rotation since 33925 and we can remove prefixLines and prependSection. .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf08bfebc83a9af5eb3c7de48f9a51d2263766fd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
