Change in vdsm[master]: configurator.py: sort imports alphabetically
Dan Kenigsberg has submitted this change and it was merged. Change subject: configurator.py: sort imports alphabetically .. configurator.py: sort imports alphabetically Change-Id: Ida7bc770363838b460db54ec7a269813197c8cae Signed-off-by: Mooli Tayer Reviewed-on: http://gerrit.ovirt.org/28654 Reviewed-by: Nir Soffer Reviewed-by: Dan Kenigsberg --- M lib/vdsm/tool/configurator.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve mooli tayer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida7bc770363838b460db54ec7a269813197c8cae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1432/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7bc770363838b460db54ec7a269813197c8cae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9171/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9955/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10110/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5037/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3194/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7bc770363838b460db54ec7a269813197c8cae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Dan Kenigsberg has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7bc770363838b460db54ec7a269813197c8cae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
mooli tayer has uploaded a new change for review. Change subject: configurator.py: sort imports alphabetically .. configurator.py: sort imports alphabetically Change-Id: Ida7bc770363838b460db54ec7a269813197c8cae Signed-off-by: Mooli Tayer --- M lib/vdsm/tool/configurator.py 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/28654/1 diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index ea2ae6d..382c233 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -17,16 +17,16 @@ # Refer to the README and COPYING files for full details of the license # -import os -import sys -import grp import argparse +import grp +import os import pwd +import sys -from .. import utils -from . import service, expose, NotRootError, UsageError from ..constants import P_VDSM_EXEC, QEMU_PROCESS_GROUP, \ SANLOCK_USER, VDSM_GROUP +from . import service, expose, NotRootError, UsageError +from .. import utils class InvalidConfig(UsageError): -- To view, visit http://gerrit.ovirt.org/28654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ida7bc770363838b460db54ec7a269813197c8cae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Nir Soffer has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 1: After you verify it this should be trivial to verify - Mooli? -- To view, visit http://gerrit.ovirt.org/28654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7bc770363838b460db54ec7a269813197c8cae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
mooli tayer has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/28654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7bc770363838b460db54ec7a269813197c8cae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Nir Soffer has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 1: Code-Review+1 Great! now we can merge it quickly - Dan? -- To view, visit http://gerrit.ovirt.org/28654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7bc770363838b460db54ec7a269813197c8cae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Nir Soffer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
mooli tayer has abandoned this change. Change subject: configurator.py: sort imports alphabetically .. Abandoned replaced with http://gerrit.ovirt.org/#/c/28463/ -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
mooli tayer has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 15: So we put small patches before and big patches in the end to make rebase as little as we can? I've was asked by a maintainer once to upload patches only when they change and not on rebase. I could do that here If it bothers somebody but I'm don't see how doing this now makes sense on the last day of work on (hopefully) on these patches after 15 patch sets. -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Nir Soffer has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 15: Code-Review-1 They way you organized the patches does not make sense. Please put this patch *before* http://gerrit.ovirt.org/27298, so it does not have to change each time that huge patch changes. -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9150/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9935/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10090/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5017/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3174/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
mooli tayer has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 14: Verified+1 -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9094/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9878/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10034/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/4960/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3117/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9057/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9841/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9997/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/4923/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3080/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8905/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9689/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9844/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Nir Soffer has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 11: Code-Review+1 Why it take so much time to merge such trivial change? -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9797/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8859/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9644/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9773/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8835/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9620/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Yaniv Bronhaim has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9627/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8695/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9481/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9605/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8673/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9459/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9598/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8666/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9452/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9591/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8659/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9445/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Douglas Schilling Landgraf has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9280/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9423/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8492/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Dan Kenigsberg has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 4: Code-Review+2 Escalating scores -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8986/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9127/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8198/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Yaniv Bronhaim has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
mooli tayer has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8959/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9100/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8171/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8951/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9092/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8163/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Nir Soffer has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 1: Code-Review+1 Nice, easy to review. -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8923/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9061/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8133/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
mooli tayer has uploaded a new change for review. Change subject: configurator.py: sort imports alphabetically .. configurator.py: sort imports alphabetically Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Signed-off-by: Mooli Tayer --- M lib/vdsm/tool/configurator.py 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/27783/1 diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index 4b5c354..176b0aa 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -17,14 +17,14 @@ # Refer to the README and COPYING files for full details of the license # -import errno -import os -import sys -import grp import argparse +import errno import filecmp +import grp +import os import rpm import shutil +import sys import traceback import uuid -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
