Change in vdsm[master]: core: Use constant instead of text

2016-08-25 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: core: Use constant instead of text
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/62366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e3b4d519140d570103eef09e76776a7330c568c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: core: Use constant instead of text

2016-08-25 Thread ahino 
Ala Hino has abandoned this change.

Change subject: core: Use constant instead of text
..


Abandoned

squashed to https://gerrit.ovirt.org/60889

-- 
To view, visit https://gerrit.ovirt.org/62366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I8e3b4d519140d570103eef09e76776a7330c568c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: core: Use constant instead of text

2016-08-25 Thread ahino 
Ala Hino has posted comments on this change.

Change subject: core: Use constant instead of text
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/62366/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS1, Line 4752: vol_format = sc.name2type(baseInfo['format'])
> If baseInfo['format'] is a string (like COW or RAW) then just compare again
Done


-- 
To view, visit https://gerrit.ovirt.org/62366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e3b4d519140d570103eef09e76776a7330c568c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: core: Use constant instead of text

2016-08-24 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: core: Use constant instead of text
..


Patch Set 1: Code-Review-1

(1 comment)

This patch fixes up code from a previous patch,  Please squash it into the 
previous one.

https://gerrit.ovirt.org/#/c/62366/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS1, Line 4752: vol_format = sc.name2type(baseInfo['format'])
If baseInfo['format'] is a string (like COW or RAW) then just compare against 
the string based constants in sc:

 if drive.chunked and baseInfo['format'] == sc.type2name(sc.COW_FORMAT):


-- 
To view, visit https://gerrit.ovirt.org/62366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e3b4d519140d570103eef09e76776a7330c568c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: core: Use constant instead of text

2016-08-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: core: Use constant instead of text
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e3b4d519140d570103eef09e76776a7330c568c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: core: Use constant instead of text

2016-08-16 Thread ahino 
Ala Hino has uploaded a new change for review.

Change subject: core: Use constant instead of text
..

core: Use constant instead of text

Use storage constants instead of text when checking volume format

Change-Id: I8e3b4d519140d570103eef09e76776a7330c568c
Signed-off-by: Ala Hino 
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/62366/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index d66e4cb..5f097d7 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4749,7 +4749,8 @@
 self.untrackBlockJob(jobUUID)
 return response.error('mergeErr')
 
-if drive.chunked and baseInfo['format'] == 'COW':
+vol_format = sc.name2type(baseInfo['format'])
+if drive.chunked and vol_format == sc.COW_FORMAT:
 # We try to get volume alloc value from libvirt
 alloc = self._getVolumeWriteWatermarks(drive, baseVolUUID)
 if not alloc:


-- 
To view, visit https://gerrit.ovirt.org/62366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e3b4d519140d570103eef09e76776a7330c568c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org