Change in vdsm[master]: core: removal of unneeded callback passing
Dan Kenigsberg has submitted this change and it was merged. Change subject: core: removal of unneeded callback passing .. core: removal of unneeded callback passing The callback can be executed from sp.py after completing the operation, eliminating the need to pass it to imageSharing. Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Signed-off-by: Liron Aravot lara...@redhat.com Reviewed-on: http://gerrit.ovirt.org/26760 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Yoav Kleinberger yklei...@redhat.com Reviewed-by: Xavi Francisco xfran...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/image.py M vdsm/storage/sp.py 2 files changed, 6 insertions(+), 11 deletions(-) Approvals: Xavi Francisco: Looks good to me, but someone else must approve Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, approved Yoav Kleinberger: Looks good to me, but someone else must approve Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1374/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
Liron Ar has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 12: the whole topic patches were verified with various upload/download scenarios. -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
Liron Ar has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8605/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/973/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9539/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9393/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8611/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/979/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9545/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9399/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8626/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/993/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9560/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9414/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8547/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/941/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9481/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9335/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8552/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/946/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9486/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9340/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9294/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9437/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8506/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/922/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9157/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9300/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8369/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9166/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9309/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8378/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9173/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9316/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8385/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8858/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8994/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8068/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8726/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8863/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7936/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
Federico Simoncelli has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
Nir Soffer has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 1: Why not verify this simple change and get it merged? -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
Xavi Francisco has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 1: Code-Review+1 Looks good -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
Yoav Kleinberger has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 1: Code-Review+1 nice -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
Nir Soffer has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 1: Code-Review+1 I would make this patch first in the set, since it can be easily merged now. -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
Liron Ar has uploaded a new change for review. Change subject: core: removal of unneeded callback passing .. core: removal of unneeded callback passing The callback can be executed from sp.py after completing the operation, eliminating the need to pass it to imageSharing. Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Signed-off-by: Liron Aravot lara...@redhat.com --- M vdsm/storage/image.py M vdsm/storage/sp.py 2 files changed, 6 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/26760/1 diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py index 44ba822..63dc56a 100644 --- a/vdsm/storage/image.py +++ b/vdsm/storage/image.py @@ -1174,14 +1174,7 @@ finally: domain.deactivateImage(imgUUID) -def downloadFromStream(self, methodArgs, callback, sdUUID, imgUUID, - volUUID=None): -try: -self._downloadFromStream(methodArgs, sdUUID, imgUUID, volUUID) -finally: -callback() - -def _downloadFromStream(self, methodArgs, sdUUID, imgUUID, volUUID=None): +def downloadFromStream(self, methodArgs, sdUUID, imgUUID, volUUID=None): domain = sdCache.produce(sdUUID) vol = self._activateVolumeForImportExport(domain, imgUUID, volUUID) diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index 338232f..4de27d9 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -1639,9 +1639,11 @@ rm.LockType.exclusive) with imgResourceLock: -return image.Image(self.poolPath) \ -.downloadFromStream(methodArgs, callback, sdUUID, imgUUID, -volUUID) +try: +return image.Image(self.poolPath) \ +.downloadFromStream(methodArgs, sdUUID, imgUUID, volUUID) +finally: +callback() def moveMultipleImages(self, srcDomUUID, dstDomUUID, imgDict, vmUUID, force): -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: removal of unneeded callback passing
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: removal of unneeded callback passing .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8034/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8147/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7244/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6e455dc3824f695fab241197ac628713f683a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar lara...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
