Change in vdsm[master]: detector: make sure to drop connection when no data
automat...@ovirt.org has posted comments on this change. Change subject: detector: make sure to drop connection when no data .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/40172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
Piotr Kliczewski has abandoned this change. Change subject: detector: make sure to drop connection when no data .. Abandoned This issue was fixed in different patch. -- To view, visit https://gerrit.ovirt.org/40172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
Piotr Kliczewski has posted comments on this change.
Change subject: detector: make sure to drop connection when no data
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40172/2/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:
Line 104: return
Line 105: dispatcher.handle_error()
Line 106: return
Line 107:
Line 108: if monotonic_time() > self._give_up_at:
> can't you use the has_expired function? and doesn't readable() function tak
As part of breakdown of bigger patches I created this one but in the mean time
there was separate patch to have it in readable() so it is OK to abandon this
patch.
Line 109: self.log.debug("Timed out while waiting for data")
Line 110: dispatcher.close()
Line 111: return
Line 112:
--
To view, visit https://gerrit.ovirt.org/40172
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
Yaniv Bronhaim has posted comments on this change.
Change subject: detector: make sure to drop connection when no data
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40172/2/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:
Line 104: return
Line 105: dispatcher.handle_error()
Line 106: return
Line 107:
Line 108: if monotonic_time() > self._give_up_at:
can't you use the has_expired function? and doesn't readable() function take
care of this ?
Line 109: self.log.debug("Timed out while waiting for data")
Line 110: dispatcher.close()
Line 111: return
Line 112:
--
To view, visit https://gerrit.ovirt.org/40172
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
oVirt Jenkins CI Server has posted comments on this change. Change subject: detector: make sure to drop connection when no data .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18084/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1313/ : 0 -- To view, visit https://gerrit.ovirt.org/40172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
oVirt Jenkins CI Server has posted comments on this change. Change subject: detector: make sure to drop connection when no data .. Patch Set 2: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1313/ -- To view, visit https://gerrit.ovirt.org/40172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
automat...@ovirt.org has posted comments on this change. Change subject: detector: make sure to drop connection when no data .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
oVirt Jenkins CI Server has posted comments on this change. Change subject: detector: make sure to drop connection when no data .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18084/ -- To view, visit https://gerrit.ovirt.org/40172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
oVirt Jenkins CI Server has posted comments on this change. Change subject: detector: make sure to drop connection when no data .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18049/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1278/ : 0 -- To view, visit https://gerrit.ovirt.org/40172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
oVirt Jenkins CI Server has posted comments on this change. Change subject: detector: make sure to drop connection when no data .. Patch Set 1: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1278/ -- To view, visit https://gerrit.ovirt.org/40172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
Piotr Kliczewski has posted comments on this change. Change subject: detector: make sure to drop connection when no data .. Patch Set 1: Verified+1 Verified by host deploying vdsm containing all patches from events topic. Storage domain was provisioned and vm was created. Flow of events when changing vm state was observed. -- To view, visit https://gerrit.ovirt.org/40172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
oVirt Jenkins CI Server has posted comments on this change. Change subject: detector: make sure to drop connection when no data .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18049/ -- To view, visit https://gerrit.ovirt.org/40172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
automat...@ovirt.org has posted comments on this change. Change subject: detector: make sure to drop connection when no data .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: make sure to drop connection when no data
Piotr Kliczewski has uploaded a new change for review.
Change subject: detector: make sure to drop connection when no data
..
detector: make sure to drop connection when no data
Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf
Signed-off-by: pkliczewski
---
M vdsm/protocoldetector.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/40172/1
diff --git a/vdsm/protocoldetector.py b/vdsm/protocoldetector.py
index 68972c6..0c0dd9c 100644
--- a/vdsm/protocoldetector.py
+++ b/vdsm/protocoldetector.py
@@ -105,6 +105,11 @@
dispatcher.handle_error()
return
+if monotonic_time() > self._give_up_at:
+self.log.debug("Timed out while waiting for data")
+dispatcher.close()
+return
+
if len(data) < self._required_size:
return
--
To view, visit https://gerrit.ovirt.org/40172
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
