Change in vdsm[master]: dmidecode: Handle missing values
Dan Kenigsberg has submitted this change and it was merged. Change subject: dmidecode: Handle missing values .. dmidecode: Handle missing values Make all hwInfo fields in API optional, and change property retrieval so it cannot fail, also, get rid of all keys that contain no actual information. The engine will assume that all the missing keys are not available and report/display an according message (rather than sending 'Not Specified') Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1089393 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Signed-off-by: Dima Kuznetsov dkuzn...@redhat.com Reviewed-on: http://gerrit.ovirt.org/26942 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/dmidecodeUtil.py M vdsm_api/vdsmapi-schema.json 2 files changed, 13 insertions(+), 11 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve Dima Kuznetsov: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dmidecode: Handle missing values
oVirt Jenkins CI Server has posted comments on this change. Change subject: dmidecode: Handle missing values .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1364/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dmidecode: Handle missing values
Dan Kenigsberg has posted comments on this change. Change subject: dmidecode: Handle missing values .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dmidecode: Handle missing values
Dima Kuznetsov has posted comments on this change. Change subject: dmidecode: Handle missing values .. Patch Set 4: Verified+1 Verified by using vdsClient getHardwareInformation verb and engine webadmin, locally changed dmidecodeUtil to omit several keys and everything worked as expected, keys were not reported vdsClient and webadmin showed no information. -- To view, visit http://gerrit.ovirt.org/26942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dmidecode: Handle missing values.
oVirt Jenkins CI Server has posted comments on this change. Change subject: dmidecode: Handle missing values. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9045/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9186/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8257/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dmidecode: Handle missing values
Yaniv Bronhaim has posted comments on this change. Change subject: dmidecode: Handle missing values .. Patch Set 4: Code-Review+1 in ovirt-engine those values just remain empty -- To view, visit http://gerrit.ovirt.org/26942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dmidecode: Handle missing values
oVirt Jenkins CI Server has posted comments on this change. Change subject: dmidecode: Handle missing values .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9047/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9188/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8259/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
