Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Ondřej Svoboda has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/37733/8/tests/functional/dummy.py File tests/functional/dummy.py: Line 52:(dummy_name, e)) Line 53: Line 54: Line 55: @contextmanager Line 56: def device(prefix='dummy_', max_length=11): > never used? Do you mean max_length? I must have lost it in (local) rebases. Line 57: dummy_name = create(prefix=prefix) Line 58: try: Line 59: yield dummy_name Line 60: finally: -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
automat...@ovirt.org has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
automat...@ovirt.org has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Ido Barkan has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Ondřej Svoboda has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 10: Verified+1 There was no regression when running functional tests on EL7 (but slow tests were skipped). -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
automat...@ovirt.org has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Ondřej Svoboda has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 11: Verified+1 Again, there were failures but they weren't caused by the patch. testSetupNetworksAddBondWithManyVlans (not bridged, bridged), testSetupNetworksEmergencyDevicesCleanupVlanOverwrite (not bridged), test_getVdsStats http://fpaste.org/226331/ -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Petr Horáček has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
automat...@ovirt.org has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Dan Kenigsberg has submitted this change and it was merged. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Signed-off-by: Ondřej Svoboda Reviewed-on: https://gerrit.ovirt.org/37733 Continuous-Integration: Jenkins CI Reviewed-by: Petr Horáček Reviewed-by: Dan Kenigsberg --- M tests/functional/dummy.py M tests/netinfoTests.py M tests/samplingTests.py 3 files changed, 31 insertions(+), 30 deletions(-) Approvals: Ondřej Svoboda: Verified Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Dan Kenigsberg has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Ondřej Svoboda has uploaded a new change for review. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Signed-off-by: Ondřej Svoboda --- M tests/functional/dummy.py M tests/netinfoTests.py M tests/samplingTests.py 3 files changed, 24 insertions(+), 24 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/37733/1 diff --git a/tests/functional/dummy.py b/tests/functional/dummy.py index 9385e45..8594734 100644 --- a/tests/functional/dummy.py +++ b/tests/functional/dummy.py @@ -16,6 +16,8 @@ # # Refer to the README and COPYING files for full details of the license # +from contextlib import contextmanager + from nose.plugins.skip import SkipTest from vdsm.ipwrapper import linkAdd, linkDel, addrAdd, linkSet, IPRoute2Error @@ -53,6 +55,15 @@ (dummy_name, e)) +@contextmanager +def device(prefix='dummy_', max_length=11): +dummy_name = create() +try: +yield dummy_name +finally: +remove(dummy_name) + + def setIP(dummy_name, ipaddr, netmask, family=4): try: addrAdd(dummy_name, ipaddr, netmask, family) diff --git a/tests/netinfoTests.py b/tests/netinfoTests.py index b64cc94..ef4bf64 100644 --- a/tests/netinfoTests.py +++ b/tests/netinfoTests.py @@ -182,21 +182,19 @@ with MonkeyPatchScope([(ipwrapper.Link, '_fakeNics', ['veth_*', 'dummy_*'])]): with veth.pair() as (v1a, v1b): -d1 = dummy.create() -fakes = set([d1, v1a, v1b]) -nics = netinfo.nics() -dummy.remove(d1) -self.assertTrue(fakes.issubset(nics), 'Fake devices %s are not' -' listed in nics %s' % (fakes, nics)) +with dummy.device() as d1: +fakes = set([d1, v1a, v1b]) +nics = netinfo.nics() +self.assertTrue(fakes.issubset(nics), 'Fake devices %s are' +' not listed in nics %s' % (fakes, nics)) with veth.pair(prefix='mehv_') as (v2a, v2b): -d2 = dummy.create(prefix='mehd_') -hiddens = set([d2, v2a, v2b]) -dummy.remove(d2) -nics = netinfo.nics() -self.assertFalse(hiddens.intersection(nics), 'Some of hidden ' - 'devices %s is shown in nics %s' % (hiddens, - nics)) +with dummy.device(prefix='mehd_') as d2: +hiddens = set([d2, v2a, v2b]) +nics = netinfo.nics() +self.assertFalse(hiddens.intersection(nics), 'Some of ' + 'hidden devices %s is shown in nics %s' % + (hiddens, nics)) def testGetIfaceCfg(self): deviceName = "___This_could_never_be_a_device_name___" diff --git a/tests/samplingTests.py b/tests/samplingTests.py index 1d0dd4d..3585530 100644 --- a/tests/samplingTests.py +++ b/tests/samplingTests.py @@ -112,15 +112,6 @@ @contextmanager -def dummy_if(): -dummy_name = dummy.create() -try: -yield dummy_name -finally: -dummy.remove(dummy_name) - - -@contextmanager def vlan(name, link, vlan_id): ipwrapper.linkAdd(name, 'vlan', link=link, args=['id', str(vlan_id)]) try: @@ -150,7 +141,7 @@ hs_before = sampling.HostSample(os.getpid()) interfaces_before = set(hs_before.interfaces.iterkeys()) -with dummy_if() as dummy_name: +with dummy.device() as dummy_name: hs_after = sampling.HostSample(os.getpid()) interfaces_after = set(hs_after.interfaces.iterkeys()) interfaces_diff = interfaces_after - interfaces_before @@ -167,7 +158,7 @@ with MonkeyPatchScope( [(ipwrapper, 'getLinks', faultyGetLinks)]): -with dummy_if() as dummy_name: +with dummy.device() as dummy_name: with vlan(self.NEW_VLAN, dummy_name, 999): hs = sampling.HostSample(os.getpid()) self.assertNotIn(self.NEW_VLAN, hs.interfaces) -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15598/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14796/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15767/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2634/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/574/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15599/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14797/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15768/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2635/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/575/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15601/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14799/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15770/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2637/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/577/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15603/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14801/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15772/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2639/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/579/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Ondřej Svoboda has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 4: Verified+1 Unit tests passed with the exception of ERRORs in testHostSampleHandlesDisappearingVlanInterfaces and testHostSampleReportsNewInterface The two tests failed before this change on File "/root/vdsm/tests/samplingTests.py", line 163, in testHostSampleHandlesDisappearingVlanInterfaces hs = sampling.HostSample(os.getpid()) File "/root/vdsm/vdsm/virt/sampling.py", line 281, in __init__ self.numaNodeMem = NumaNodeMemorySample() File "/root/vdsm/vdsm/virt/sampling.py", line 173, in __init__ memInfo = caps.getMemoryStatsByNumaCell(int(nodeIndex)) File "/root/vdsm/vdsm/caps.py", line 356, in getMemoryStatsByNumaCell cellMemInfo = libvirtconnection.get().getMemoryStats(cell, 0) AttributeError: 'virConnect' object has no attribute 'getMemoryStats' -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Ido Barkan has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Petr Horáček has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Dan Kenigsberg has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
automat...@ovirt.org has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
automat...@ovirt.org has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
automat...@ovirt.org has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
automat...@ovirt.org has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Dan Kenigsberg has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 4: Code-Review-1 Please rebase! -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
automat...@ovirt.org has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
automat...@ovirt.org has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 6: Build Started (2/3) -> http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2818/ -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 6: Build Started (1/3) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16897/ -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 5: Build Started (3/3) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17066/ -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 5: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16894/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17066/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2815/ : The patch does not pass the network functional tests -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 6: Build Started (3/3) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17069/ -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16897/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17069/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2818/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
automat...@ovirt.org has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
automat...@ovirt.org has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Ido Barkan has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 8: Code-Review-1 (1 comment) -1 for visibility (comments inside) https://gerrit.ovirt.org/#/c/37733/8/tests/functional/dummy.py File tests/functional/dummy.py: Line 52:(dummy_name, e)) Line 53: Line 54: Line 55: @contextmanager Line 56: def device(prefix='dummy_', max_length=11): never used? Line 57: dummy_name = create(prefix=prefix) Line 58: try: Line 59: yield dummy_name Line 60: finally: -- To view, visit https://gerrit.ovirt.org/37733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
