Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...

2015-02-11 Thread osvoboda 
Ondřej Svoboda has uploaded a new change for review.

Change subject: dummy: unify parameter 'dummy_name' naming with a variable name 
already used
..

dummy: unify parameter 'dummy_name' naming with a variable name already used

Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Signed-off-by: Ondřej Svoboda 
---
M tests/functional/dummy.py
1 file changed, 13 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/37728/1

diff --git a/tests/functional/dummy.py b/tests/functional/dummy.py
index f036784..eebefed 100644
--- a/tests/functional/dummy.py
+++ b/tests/functional/dummy.py
@@ -38,40 +38,40 @@
 return dummy_name
 
 
-def remove(dummyName):
+def remove(dummy_name):
 """
 Removes dummy interface dummyName. Assumes root privileges.
 """
 
 try:
-linkDel(dummyName)
+linkDel(dummy_name)
 except IPRoute2Error as e:
 raise SkipTest("Unable to delete dummy interface %s because %s" %
-   (dummyName, e))
+   (dummy_name, e))
 
 
-def setIP(dummyName, ipaddr, netmask, family=4):
+def setIP(dummy_name, ipaddr, netmask, family=4):
 try:
-addrAdd(dummyName, ipaddr, netmask, family)
+addrAdd(dummy_name, ipaddr, netmask, family)
 except IPRoute2Error as e:
 message = ('Failed to add the IPv%s address %s/%s to device %s: %s'
-   % (family, ipaddr, netmask, dummyName, e))
+   % (family, ipaddr, netmask, dummy_name, e))
 if family == 6:
 message += ('; NetworkManager may have set the sysctl disable_ipv6'
 ' flag on the device, please see e.g. RH BZ #1102064')
 raise SkipTest(message)
 
 
-def setLinkUp(dummyName):
-_setLinkState(dummyName, 'up')
+def setLinkUp(dummy_name):
+_setLinkState(dummy_name, 'up')
 
 
-def setLinkDown(dummyName):
-_setLinkState(dummyName, 'down')
+def setLinkDown(dummy_name):
+_setLinkState(dummy_name, 'down')
 
 
-def _setLinkState(dummyName, state):
+def _setLinkState(dummy_name, state):
 try:
-linkSet(dummyName, [state])
+linkSet(dummy_name, [state])
 except IPRoute2Error:
-raise SkipTest('Failed to bring %s to state %s' % (dummyName, state))
+raise SkipTest('Failed to bring %s to state %s' % (dummy_name, state))


-- 
To view, visit http://gerrit.ovirt.org/37728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...

2015-02-11 Thread osvoboda 
Ondřej Svoboda has posted comments on this change.

Change subject: dummy: unify parameter 'dummy_name' naming with a variable name 
already used
..


Patch Set 1: Verified+1

Renaming only. (I fell to the hole I dug myself – anyone knows the proper 
English idiom?)

-- 
To view, visit http://gerrit.ovirt.org/37728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...

2015-02-11 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: dummy: unify parameter 'dummy_name' naming with a variable name 
already used
..


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15593/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14791/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15762/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2630/ 
: There was an infra issue, please contact in...@ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/569/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...

2015-02-11 Thread osvoboda 
Ondřej Svoboda has posted comments on this change.

Change subject: dummy: unify parameter 'dummy_name' naming with a variable name 
already used
..


Patch Set 2: Verified+1

Forgot to update a docstring.

-- 
To view, visit http://gerrit.ovirt.org/37728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...

2015-02-11 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: dummy: unify parameter 'dummy_name' naming with a variable name 
already used
..


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15597/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14795/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15766/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2633/ 
: There was an infra issue, please contact in...@ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/573/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...

2015-02-14 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: dummy: unify parameter 'dummy_name' naming with a variable name 
already used
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/37728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...

2015-02-14 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: dummy: unify parameter 'dummy_name' naming with a variable name 
already used
..


dummy: unify parameter 'dummy_name' naming with a variable name already used

Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Signed-off-by: Ondřej Svoboda 
Reviewed-on: http://gerrit.ovirt.org/37728
Reviewed-by: Dan Kenigsberg 
---
M tests/functional/dummy.py
1 file changed, 14 insertions(+), 14 deletions(-)

Approvals:
  Ondřej Svoboda: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/37728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...

2015-02-14 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: dummy: unify parameter 'dummy_name' naming with a variable name 
already used
..


Patch Set 3:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/643/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/242/
 : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4626/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/619/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/246/
 : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/644/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/246/
 : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/233/
 : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/640/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6465/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...

2015-03-15 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: dummy: unify parameter 'dummy_name' naming with a variable name 
already used
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...

2015-03-15 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: dummy: unify parameter 'dummy_name' naming with a variable name 
already used
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...

2015-03-15 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: dummy: unify parameter 'dummy_name' naming with a variable name 
already used
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit http://gerrit.ovirt.org/37728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches