Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2014-06-23 Thread iheim 
Itamar Heim has abandoned this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Abandoned

no activity, restore if relevant

-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2014-04-28 Thread iheim 
Itamar Heim has posted comments on this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Patch Set 7:

ping

-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2013-12-09 Thread mtayer 
mooli tayer has posted comments on this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Patch Set 7:

(1 comment)


File vdsm.spec.in
Line 608: install -Dm 0644 init/systemd/vdsm-tmpfiles.d.conf \
Line 609:  %{buildroot}%{_tmpfilesdir}/%{vdsm_name}.conf
Line 610: %endif
Line 611: 
Line 612: %if %{?rhel}
note to self, this is a mistake, fix according to 
http://gerrit.ovirt.org/#/c/21290/1
Line 613: # Install the configuration sample
Line 614: install -Dm 0644 lib/vdsm/vdsm.conf.sample \
Line 615:  %{buildroot}%{_sysconfdir}/vdsm/vdsm.conf
Line 616: 


-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2013-12-09 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Patch Set 7:

(2 comments)


Commit Message
Line 4: Commit: Mooli Tayer mta...@redhat.com
Line 5: CommitDate: 2013-11-21 10:58:52 +0200
Line 6: 
Line 7: generate qemu-kvm coredumps using abrt
Line 8: 
I would describe how we did this before, and why we want to use abrt instead.
Line 9: Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9



File vdsm/sampling.py
Line 150: 
Line 151: A sample of host-related statistics.
Line 152: 
Line 153: Contains the state of the host in the time of initialization.
Line 154: 
Is this spelling related to this patch?
Line 155: MONITORED_PATHS = ['/tmp', '/var/log', '/var/log/core', 
P_VDSM_RUN]
Line 156: 
Line 157: def _getDiskStats(self):
Line 158: d = {}


-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2013-11-25 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Patch Set 7: Code-Review-1

I really like detailed commit messages. Could you provide, in the commit 
message, an explanation on what does abrt do, and consider how it integrates 
with log-collector?

-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2013-11-22 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Patch Set 7:

(6 comments)


Commit Message
Line 3: AuthorDate: 2013-10-30 16:02:10 +0200
Line 4: Commit: Mooli Tayer mta...@redhat.com
Line 5: CommitDate: 2013-11-21 10:58:52 +0200
Line 6: 
Line 7: generate qemu-kvm coredumps using abrt
I would say, removing core dump configuration from vdsm and start using abrt 
service as a substitute
Line 8: 
Line 9: Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9



File init/systemd/vdsmd.service.in
Line 6: Conflicts=libvirt-guests.service ksmtuned.service
Line 7: 
Line 8: [Service]
Line 9: Type=simple
Line 10: LimitCORE=infinity
is LimitCore can be removed too?
Line 11: EnvironmentFile=-/etc/sysconfig/vdsm
Line 12: ExecStartPre=@LIBEXECDIR@/vdsmd_init_common.sh --pre-start
Line 13: ExecStart=@VDSMDIR@/daemonAdapter -0 /dev/null -1 /dev/null -2 
/dev/null @VDSMDIR@/vdsm
Line 14: ExecStopPost=@LIBEXECDIR@/vdsmd_init_common.sh --post-stop



File init/sysvinit/vdsmd.init.in
Line 25: prog=vdsm
Line 26: PIDFILE=@VDSMRUNDIR@/vdsmd.pid
Line 27: RESPAWNPIDFILE=@VDSMRUNDIR@/respawn.pid
Line 28: NEEDED_SERVICES=iscsid multipathd rpcbind ntpd wdmd sanlock network 
libvirtd
Line 29:  supervdsmd abrtd
should be stated also in init/upstart/vdsmd.upstart
Line 30: CONFLICTING_SERVICES=libvirt-guests ksmtuned
Line 31: LOCK_FILE=/var/lock/subsys/vdsmd
Line 32: VDSM_TOOL=@BINDIR@/vdsm-tool
Line 33: NICE_LOWEST=-20



File init/vdsmd_init_common.sh.in
Line 21
Line 22
Line 23
Line 24
Line 25
abrt conf should be configured? (http://linux.die.net/man/5/abrt.conf)



File lib/vdsm/config.py.in
Line 26
Line 27
Line 28
Line 29
Line 30
can't be that user will want to disable also the abrt's coredumps ?.. it might 
consume some memory that can be important to some..



File vdsm/vdsm
Line 163
Line 164
Line 165
Line 166
Line 167
does rlimit configure effects abrt? if is, should you initialize it?


-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2013-11-21 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Patch Set 7:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4776/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5576/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5659/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2013-11-19 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4730/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5530/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5610/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2013-11-19 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Patch Set 3:

(1 comment)

Is that all that it takes? Where are the cores dumped too? Log-collector should 
pick them up, and we must make sure it's writable on ovirt-node.

You should also drop the selinux hack and any other ref to /var/log/core.


File init/vdsmd_init_common.sh.in
Line 24:  pre-start tasks 
Line 25: task_configure_coredump() {
Line 26: local conf_file=@CONFDIR@/vdsm.conf
Line 27: local getconfitem=@VDSMDIR@/get-conf-item
Line 28: }
Please drop this configurable from config.py.in too.
Line 29: 
Line 30: task_run_init_hooks(){
Line 31: @PYTHON@ @VDSMDIR@/hooks.pyc before_vdsm_start
Line 32: }


-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2013-11-19 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Patch Set 3:

Oh I see that you have the hack reverted in the same topic branch. Thanks.

-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2013-11-19 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4741/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5541/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5621/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2013-11-19 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Patch Set 5:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4742/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5542/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5622/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2013-11-19 Thread mtayer 
mooli tayer has posted comments on this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Patch Set 6:

(1 comment)


File vdsm/vdsm
Line 55: 
Line 56: signal.signal(signal.SIGTERM, sigtermHandler)
Line 57: signal.signal(signal.SIGUSR1, sigusr1Handler)
Line 58: zombiereaper.registerSignalHandler()
Line 59: 
Is this comment relevant to this patch in any way?
Line 60: from clientIF import clientIF  # must import after config is read
Line 61: cif = clientIF.getInstance(log)
Line 62: cif.serve()
Line 63: 


-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2013-11-19 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Patch Set 6:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4743/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5543/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5623/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: generate qemu-kvm coredumps using abrt

2013-11-19 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: generate qemu-kvm coredumps using abrt
..


Patch Set 6: Code-Review-1

more cleanup needed, most probably.

$ git grep /var/log/core|wc -l
5

Could you provide, in the commit message, an explanation on what does abrt do, 
and consider how it integrates with log-collector?

-- 
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches