Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 7: Code-Review+2

raising

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


gluster: Added VDSM verb to stop gluster related processes

Added a verb which stops the gluster related process like
brick processes, gsyncd process.
This needs to be done as part of a host moving to maintenance
mode. as data should not be available if a host is moved to
maintenence mode for some migration etc.

Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Bug-URL: https://bugzilla.redhat.com/1205724
Signed-off-by: Shubhendu Tripathi 
Reviewed-on: https://gerrit.ovirt.org/43821
Tested-by: Ramesh N 
Continuous-Integration: Jenkins CI
Reviewed-by: Bala.FA 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Dan Kenigsberg 
---
M client/vdsClientGluster.py
M lib/api/vdsmapi-gluster-schema.json
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/exception.py
5 files changed, 45 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Bala.FA: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Ramesh N: Verified



-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[barumuga]

Bala.FA has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 6: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/43821/6/vdsm/gluster/exception.py
File vdsm/gluster/exception.py:

Line 106: GlusterStopProcessesFailedException
Please change the name to GlusterProcessesStopFailedException()


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 6: Code-Review-1

Please follow approach as it is used in volumeSnapshotConfigSet.

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 6:

(1 comment)

I changed the schema to follow the approach used in volumeSnapshotConfigSet. 
Patch set to follow.

https://gerrit.ovirt.org/#/c/43821/6/vdsm/gluster/exception.py
File vdsm/gluster/exception.py:

Line 106: GlusterStopProcessesFailedException
> Please change the name to GlusterProcessesStopFailedException()
Done


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 7: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[barumuga]

Bala.FA has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 4: Code-Review-1

Marking it as -1 since the dependent gluster patch is not yet merged.

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/43821/4/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 274: @makePublic
Line 275: def stopProcesses():
Line 276: command = ["/bin/sh", _stopAllProcessesPath.cmd]
Line 277: rc, out, err = utils.execCmd(command)
Line 278: if rc:
> Looking at the schema file I can see that we return true or false depending
Looks like all gluster functions are returning exceptions instead of false. We 
have to fix all of them and that requires change in the engine as well. Can we 
live with exceptions for the time being?.
Line 279: raise ge.GlusterStopProcessesFailedException(rc)
Line 280: return True
Line 281: 
Line 282: 


Line 771: stopProcesses(sel
> Please change the name as ProcessesStop to be consistent with other verbs. 
Done. Changed this to ProcessesStop in all the places.


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 3:

(3 comments)

https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 53: )
Line 54: 
Line 55: _stopAllProcessesPath = utils.CommandPath(
Line 56: "stop-all-gluster-processes.sh",
Line 57: "/usr/share/glusterfs/scripts/stop-all-gluster-processes.sh",
> Please confirm this.
The patch https://review.gluster.org/#/c/11739/ is already acked and can be 
merged. Currently Merge is blocked because of some test case in the branch. 

Regarding the location of the script. It may vary based on the platform. Bala 
may know better here.
Line 58: )
Line 59: 
Line 60: 
Line 61: GLUSTER_RPM_PACKAGES = (


Line 276: _stopAllProcessesPath
> Is there any reason why the script is not set with execute permission?
I am not sure why it has execute permission in RHEL7 and Fedora but not in 
RHEL6.


https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/exception.py
File vdsm/gluster/exception.py:

Line 607: GlusterStopProcessesFailedException
> You should move it to gluster general
Done


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[barumuga]

Bala.FA has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 53: )
Line 54: 
Line 55: _stopAllProcessesPath = utils.CommandPath(
Line 56: "stop-all-gluster-processes.sh",
Line 57: "/usr/share/glusterfs/scripts/stop-all-gluster-processes.sh",
> The patch https://review.gluster.org/#/c/11739/ is already acked and can be
You could check with gluster team about the location of the script for various 
platform and how to resolve that.
Line 58: )
Line 59: 
Line 60: 
Line 61: GLUSTER_RPM_PACKAGES = (


Line 276: _stopAllProcessesPath
> I am not sure why it has execute permission in RHEL7 and Fedora but not in 
May be a bug.  You should check with glusterfs team.


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[barumuga]

Bala.FA has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 4: Code-Review-1

(1 comment)

Please make yourself to -1 till the dependency patch gets merged in glusterfs.

https://gerrit.ovirt.org/#/c/43821/4/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 771: stopProcesses(sel
Please change the name as ProcessesStop to be consistent with other verbs.  You 
should change it everywhere.  Sorry for the late review on this.


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/43821/4/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 274: @makePublic
Line 275: def stopProcesses():
Line 276: command = ["/bin/sh", _stopAllProcessesPath.cmd]
Line 277: rc, out, err = utils.execCmd(command)
Line 278: if rc:
Looking at the schema file I can see that we return true or false depending on 
the result but here we have true or exception. Please make it consistent.
Line 279: raise ge.GlusterStopProcessesFailedException(rc)
Line 280: return True
Line 281: 
Line 282: 


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[barumuga]

Bala.FA has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 3:

(3 comments)

https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 53: )
Line 54: 
Line 55: _stopAllProcessesPath = utils.CommandPath(
Line 56: "stop-all-gluster-processes.sh",
Line 57: "/usr/share/glusterfs/scripts/stop-all-gluster-processes.sh",
> I think so. But may be we should verify with gluster team as well.
Please confirm this.
Line 58: )
Line 59: 
Line 60: 
Line 61: GLUSTER_RPM_PACKAGES = (


Line 276: _stopAllProcessesPath
Is there any reason why the script is not set with execute permission?


https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/exception.py
File vdsm/gluster/exception.py:

Line 607: GlusterStopProcessesFailedException
You should move it to gluster general


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[barumuga]

Bala.FA has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 3: Code-Review-1

As this patch depends on https://review.gluster.org/#/c/11739/, set -1 till 
that patch gets merged.

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[shtripat]

Shubhendu Tripathi has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 53: )
Line 54: 
Line 55: _stopAllProcessesPath = utils.CommandPath(
Line 56: "stop-all-gluster-processes.sh",
Line 57: "/usr/share/glusterfs/scripts/stop-all-gluster-processes.sh",
> Shubhendu. This script works but doesn't return 0 as a result of execution.
The patch https://review.gluster.org/#/c/11739/ already available to take care 
of this.
Plz follow on the patch and get it merged.
Its already +2 I feel
Line 58: )
Line 59: 
Line 60: 
Line 61: GLUSTER_RPM_PACKAGES = (


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 53: )
Line 54: 
Line 55: _stopAllProcessesPath = utils.CommandPath(
Line 56: "stop-all-gluster-processes.sh",
Line 57: "/usr/share/glusterfs/scripts/stop-all-gluster-processes.sh",
> I think so. But may be we should verify with gluster team as well.
Shubhendu. This script works but doesn't return 0 as a result of execution. As 
consequence, GlusterStopProcessesFailedException is thrown to engine.
Line 58: )
Line 59: 
Line 60: 
Line 61: GLUSTER_RPM_PACKAGES = (


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/43821/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-07-20 10:33:01 +0530
Line 4: Commit: Ramesh Nachimuthu 
Line 5: CommitDate: 2015-10-23 11:50:03 +0530
Line 6: 
Line 7: gluster: Added VDSM verb to stop gluster related processes
Is there a similar verb to start gluster processes?
Line 8: 
Line 9: Added a verb which stops the gluster related process like
Line 10: brick processes, gsyncd process.
Line 11: This needs to be done as part of a host moving to maintenance


https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 53: )
Line 54: 
Line 55: _stopAllProcessesPath = utils.CommandPath(
Line 56: "stop-all-gluster-processes.sh",
Line 57: "/usr/share/glusterfs/scripts/stop-all-gluster-processes.sh",
Will this be the standard location in all deployments?
Is this provided as part of gluster rpm?
Line 58: )
Line 59: 
Line 60: 
Line 61: GLUSTER_RPM_PACKAGES = (


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[shtripat]

Shubhendu Tripathi has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/43821/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-07-20 10:33:01 +0530
Line 4: Commit: Ramesh Nachimuthu 
Line 5: CommitDate: 2015-10-23 11:50:03 +0530
Line 6: 
Line 7: gluster: Added VDSM verb to stop gluster related processes
> Is there a similar verb to start gluster processes?
I dont think so.
Line 8: 
Line 9: Added a verb which stops the gluster related process like
Line 10: brick processes, gsyncd process.
Line 11: This needs to be done as part of a host moving to maintenance


https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 53: )
Line 54: 
Line 55: _stopAllProcessesPath = utils.CommandPath(
Line 56: "stop-all-gluster-processes.sh",
Line 57: "/usr/share/glusterfs/scripts/stop-all-gluster-processes.sh",
> Will this be the standard location in all deployments?
I think so. But may be we should verify with gluster team as well.
Line 58: )
Line 59: 
Line 60: 
Line 61: GLUSTER_RPM_PACKAGES = (


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan Narayana Murthy 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi shtri...@redhat.com
Gerrit-Reviewer: Darshan Narayana Murthy dnara...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[shtripat]

Shubhendu Tripathi has uploaded a new change for review.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..

gluster: Added VDSM verb to stop gluster related processes

Added a verb which stops the gluster related process like
brick processes, gsyncd process.
This needs to be done as part of a host moving to maintenance
mode. as data should not be available if a host is moved to
maintenence mode for some migration etc.

Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Bug-URL: https://bugzilla.redhat.com/1205724
Signed-off-by: Shubhendu Tripathi shtri...@redhat.com
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/exception.py
M vdsm/rpc/vdsmapi-gluster-schema.json
5 files changed, 51 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/43821/1

diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index a4bce63..a72d4e3 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -740,6 +740,11 @@
 pp.pprint(status)
 return status['status']['code'], status['status']['message']
 
+def do_glusterStopProcesses(self, args):
+status = self.s.glusterStopProcesses()
+pp.pprint(status)
+return status['status']['code'], status['status']['message']
+
 
 def getGlusterCmdDict(serv):
 return \
@@ -1252,5 +1257,10 @@
  serv.do_glusterSnapshotScheduleReset,
  ('',
   'Reset gluster snapshot scheduling'
+  )),
+ 'glusterStopProcesses' : (
+ serv.do_glusterStopProcesses,
+ ('',
+  'Stop gluster processes'
   ))
  }
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 781ab77..3467412 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -52,6 +52,12 @@
 /usr/sbin/snap_scheduler.py,
 )
 
+_stopAllProcessesPath = utils.CommandPath(
+stop-all-gluster-processes.sh,
+/usr/share/glusterfs/scripts/stop-all-gluster-processes.sh,
+)
+
+
 GLUSTER_RPM_PACKAGES = (
 ('glusterfs', ('glusterfs',)),
 ('glusterfs-fuse', ('glusterfs-fuse',)),
@@ -262,6 +268,15 @@
 except (IOError, OSError) as e:
 raise ge.GlusterSnapshotScheduleFlagUpdateFailedException(
 err=[str(e)])
+return True
+
+
+@makePublic
+def stopProcesses():
+command = [/bin/sh, _stopAllProcessesPath.cmd]
+rc, out, err = utils.execCmd(command)
+if rc:
+raise ge.GlusterStopProcessesFailedException(rc)
 return True
 
 
@@ -752,6 +767,10 @@
 def snapshotScheduleReset(self, options=None):
 self.svdsmProxy.glusterSnapshotScheduleFlagUpdate(none)
 
+@exportAsVerb
+def stopProcesses(self):
+self.svdsmProxy.glusterStopProcesses()
+
 
 def getGlusterMethods(gluster):
 l = []
diff --git a/vdsm/gluster/apiwrapper.py b/vdsm/gluster/apiwrapper.py
index 4768a86..13dc859 100644
--- a/vdsm/gluster/apiwrapper.py
+++ b/vdsm/gluster/apiwrapper.py
@@ -86,6 +86,9 @@
 return self._gluster.createBrick(name, mountPoint,
  devList, fsType, raidParams)
 
+def stopProcesses(self):
+return self._gluster.stopProcesses()
+
 
 class GlusterService(GlusterApiBase):
 def __init__(self):
diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py
index 17ad018..2898d3d 100644
--- a/vdsm/gluster/exception.py
+++ b/vdsm/gluster/exception.py
@@ -594,6 +594,12 @@
 message = Failed to disable snapshot schedule through cli
 
 
+class GlusterStopProcessesFailedException(
+GlusterVolumeException):
+code = 4579
+message = Failed to stop gluster processes
+
+
 # geo-replication
 class GlusterGeoRepException(GlusterException):
 code = 4200
diff --git a/vdsm/rpc/vdsmapi-gluster-schema.json 
b/vdsm/rpc/vdsmapi-gluster-schema.json
index c86f43c..2853851 100644
--- a/vdsm/rpc/vdsmapi-gluster-schema.json
+++ b/vdsm/rpc/vdsmapi-gluster-schema.json
@@ -1299,6 +1299,19 @@
  'returns': 'bool'}
 
 ##
+# @GlusterHost.stopProcesses:
+#
+# Stops the gluster processes on the host
+#
+# Returns:
+# Success or failure
+#
+# Since: 4.17.0
+##
+{'command': {'class': 'GlusterHost', 'name': 'stopProcesses'},
+ 'returns': 'bool'}
+
+##
 # @GlusterVolumeStatsInfo:
 #
 # Gluster Volumes disk usage statistics


-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi shtri...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi shtri...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches