Change in vdsm[master]: gluster: Fix output format compatibility of removeBrickStatus

2013-10-11 Thread barumuga 
Bala.FA has posted comments on this change.

Change subject: gluster: Fix output format compatibility of removeBrickStatus
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/20108
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: ndarshan dnara...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Fix output format compatibility of removeBrickStatus

2013-10-11 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Fix output format compatibility of removeBrickStatus
..


Patch Set 1: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4929/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4043/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4853/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/20108
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: ndarshan dnara...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Fix output format compatibility of removeBrickStatus

2013-10-11 Thread avishwan 
Aravinda VK has posted comments on this change.

Change subject: gluster: Fix output format compatibility of removeBrickStatus
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/20108
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: ndarshan dnara...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Fix output format compatibility of removeBrickStatus

2013-10-11 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: gluster: Fix output format compatibility of removeBrickStatus
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/20108
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: ndarshan dnara...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Fix output format compatibility of removeBrickStatus

2013-10-11 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: gluster: Fix output format compatibility of removeBrickStatus
..


gluster: Fix output format compatibility of removeBrickStatus

Rebalance status and Remove brick status have common output structure,
engine uses common code to parse the vdsm output of both verbs.

This patch fixes the incompatibility in remove brick status output.
(As this verb is not consumed by engine/RHS-C yet, its OK to differ
in compatibility now)

Output:
{'summary': {
'filesScanned': INT,
'filesMoved': INT,
'filesFailed': INT,
'filesSkipped': INT,
'totalSizeMoved': INT,
'status': STRING
},
'hosts': [{
'name': STRING,
'filesScanned': INT,
'filesMoved': INT,
'filesFailed': INT,
'filesSkipped': INT,
'totalSizeMoved': INT,
'status': STRING
}..]}

Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5
Signed-off-by: Aravinda VK avish...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/20108
Reviewed-by: Bala.FA barum...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/gluster/api.py
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Bala.FA: Looks good to me, but someone else must approve
  Aravinda VK: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20108
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: ndarshan dnara...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Fix output format compatibility of removeBrickStatus

2013-10-10 Thread avishwan 
Aravinda VK has uploaded a new change for review.

Change subject: gluster: Fix output format compatibility of removeBrickStatus
..

gluster: Fix output format compatibility of removeBrickStatus

Rebalance status and Remove brick status have common output structure,
engine uses common code to parse the vdsm output of both verbs.

This patch fixes the incompatibility in remove brick status output.
(As this verb is not consumed by engine/RHS-C yet, its OK to differ
in compatibility now)

Output:
{'summary': {
'filesScanned': INT,
'filesMoved': INT,
'filesFailed': INT,
'filesSkipped': INT,
'totalSizeMoved': INT,
'status': STRING
},
'hosts': [{
'name': STRING,
'filesScanned': INT,
'filesMoved': INT,
'filesFailed': INT,
'filesSkipped': INT,
'totalSizeMoved': INT,
'status': STRING
}..]}

Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5
Signed-off-by: Aravinda VK avish...@redhat.com
---
M vdsm/gluster/api.py
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/20108/1

diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index ebb0901..284fa97 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -181,10 +181,9 @@
 @exportAsVerb
 def volumeRemoveBrickStatus(self, volumeName, brickList,
 replicaCount=0, options=None):
-message = self.svdsmProxy.glusterVolumeRemoveBrickStatus(volumeName,
- brickList,
- replicaCount)
-return {'message': message}
+return self.svdsmProxy.glusterVolumeRemoveBrickStatus(volumeName,
+  brickList,
+  replicaCount)
 
 @exportAsVerb
 def volumeRemoveBrickCommit(self, volumeName, brickList,


-- 
To view, visit http://gerrit.ovirt.org/20108
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK avish...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches