Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: List activate-on-create volume snapshot option .. gluster: List activate-on-create volume snapshot option Modified the verb glusterSnapshotConfigList to list option activate-on-create as well. Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Signed-off-by: Shubhendu Tripathi Bug-URL: https://bugzilla.redhat.com/1216056 Reviewed-on: https://gerrit.ovirt.org/40416 Reviewed-by: Darshan N Reviewed-by: Timothy Asir Continuous-Integration: Jenkins CI Reviewed-by: Bala.FA Reviewed-by: Piotr Kliczewski Reviewed-by: Dan Kenigsberg --- M tests/glusterSnapshotConfig.xml M tests/glusterTestData.py M vdsm/gluster/cli.py M vdsm/rpc/vdsmapi-gluster-schema.json 4 files changed, 10 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Timothy Asir: Looks good to me, but someone else must approve Bala.FA: Looks good to me, but someone else must approve Shubhendu Tripathi: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Darshan N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
automat...@ovirt.org has posted comments on this change. Change subject: gluster: List activate-on-create volume snapshot option .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
Dan Kenigsberg has posted comments on this change. Change subject: gluster: List activate-on-create volume snapshot option .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
Piotr Kliczewski has posted comments on this change. Change subject: gluster: List activate-on-create volume snapshot option .. Patch Set 2: Code-Review+1 Schema change looks good. -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: List activate-on-create volume snapshot option .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
Bala.FA has posted comments on this change. Change subject: gluster: List activate-on-create volume snapshot option .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
Timothy Asir has posted comments on this change. Change subject: gluster: List activate-on-create volume snapshot option .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
Darshan N has posted comments on this change. Change subject: gluster: List activate-on-create volume snapshot option .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: List activate-on-create volume snapshot option .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1654/ -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: List activate-on-create volume snapshot option .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18423/ -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
automat...@ovirt.org has posted comments on this change. Change subject: gluster: List activate-on-create volume snapshot option .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: List activate-on-create volume snapshot option .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1637/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18406/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: List activate-on-create volume snapshot option .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1637/ -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
automat...@ovirt.org has posted comments on this change. Change subject: gluster: List activate-on-create volume snapshot option .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: List activate-on-create volume snapshot option .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18406/ -- To view, visit https://gerrit.ovirt.org/40416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: List activate-on-create volume snapshot option
Shubhendu Tripathi has uploaded a new change for review.
Change subject: gluster: List activate-on-create volume snapshot option
..
gluster: List activate-on-create volume snapshot option
Modified the verb glusterSnapshotConfigList to list
option activate-on-create as well.
Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73
Signed-off-by: Shubhendu Tripathi
Bug-URL: https://bugzilla.redhat.com/1216056
---
M vdsm/gluster/cli.py
M vdsm/rpc/vdsmapi-gluster-schema.json
2 files changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/40416/1
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index c50b877..8d68271 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -1390,7 +1390,8 @@
"""
returns {'system':{'snap-max-hard-limit': 'hardlimit',
'snap-max-soft-limit': 'softLimit',
- 'auto-delete': 'enable/disable'},
+ 'auto-delete': 'enable/disable',
+ 'activate-on-create': 'enable/disable'},
'volume':{'name' :
{'snap-max-hard-limit: 'hardlimit'}
}
@@ -1403,6 +1404,8 @@
'snapConfig/systemConfig/softLimit').text
systemConfig['auto-delete'] = tree.find(
'snapConfig/systemConfig/autoDelete').text
+systemConfig['activate-on-create'] = tree.find(
+'snapConfig/systemConfig/activateOnCreate').text
volumeConfig = {}
for el in tree.findall('snapConfig/volumeConfig/volume'):
diff --git a/vdsm/rpc/vdsmapi-gluster-schema.json
b/vdsm/rpc/vdsmapi-gluster-schema.json
index 935adff..7f7c936 100644
--- a/vdsm/rpc/vdsmapi-gluster-schema.json
+++ b/vdsm/rpc/vdsmapi-gluster-schema.json
@@ -1865,11 +1865,13 @@
#
# @auto-delete: Auto delete enabled/disabled
#
+# @activate-on-create: Auto activate enabled/disabled
+#
# @Since: 4.17.0
##
{'type': 'SystemSnapshotConfig',
'data': {'snap-max-hard-limit': 'str', 'snap-max-soft-limit': 'str',
- 'auto-delete': 'str'}}
+ 'auto-delete': 'str', 'activate-on-create': 'str'}}
##
#
--
To view, visit https://gerrit.ovirt.org/40416
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
