Change in vdsm[master]: gluster: Modified volumeReplaceBrickCommit verb.
Darshan N has posted comments on this change. Change subject: gluster: Modified volumeReplaceBrickCommit verb. .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2dc16121cdba99c49d56c4e0b8e7a0194d58d14 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Modified volumeReplaceBrickCommit verb.
Darshan N has posted comments on this change. Change subject: gluster: Modified volumeReplaceBrickCommit verb. .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40587/1/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 218: volumeReplaceBrickCommitForce > doesn't the name change cause backward compatibility? Have changed the verb name back. -- To view, visit https://gerrit.ovirt.org/40587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2dc16121cdba99c49d56c4e0b8e7a0194d58d14 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Modified volumeReplaceBrickCommit verb.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Modified volumeReplaceBrickCommit verb. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2dc16121cdba99c49d56c4e0b8e7a0194d58d14 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Modified volumeReplaceBrickCommit verb.
Bala.FA has posted comments on this change. Change subject: gluster: Modified volumeReplaceBrickCommit verb. .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/40587/1/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 218: volumeReplaceBrickCommitForce doesn't the name change cause backward compatibility? -- To view, visit https://gerrit.ovirt.org/40587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2dc16121cdba99c49d56c4e0b8e7a0194d58d14 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Modified volumeReplaceBrickCommit verb.
Darshan N has posted comments on this change. Change subject: gluster: Modified volumeReplaceBrickCommit verb. .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2dc16121cdba99c49d56c4e0b8e7a0194d58d14 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Modified volumeReplaceBrickCommit verb.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Modified volumeReplaceBrickCommit verb. .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2dc16121cdba99c49d56c4e0b8e7a0194d58d14 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Modified volumeReplaceBrickCommit verb.
Darshan N has uploaded a new change for review.
Change subject: gluster: Modified volumeReplaceBrickCommit verb.
..
gluster: Modified volumeReplaceBrickCommit verb.
This patch modifies volumeReplaceBrickCommit verb, this
verb was taking force as optional parameter. But in
glusterfs-3.7 this force option is made manditory in the
command. To accomodate that, removed force as optional
parameter from verb and replace brick is always executed
with force as option. The name of modified verb is
"volumeReplaceBrickCommitForce".
Change-Id: Id2dc16121cdba99c49d56c4e0b8e7a0194d58d14
Signed-off-by: Darshan N
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm/rpc/vdsmapi-gluster-schema.json
6 files changed, 45 insertions(+), 24 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/40587/1
diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index c7ab5f6..72fdc02 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -163,17 +163,15 @@
status = self.s.glusterHostRemoveByUuid(hostUuid, force)
return status['status']['code'], status['status']['message']
-def do_glusterVolumeReplaceBrickCommit(self, args):
+def do_glusterVolumeReplaceBrickCommitForce(self, args):
params = self._eqSplit(args)
volumeName = params.get('volumeName', '')
existingBrick = params.get('existingBrick', '')
newBrick = params.get('newBrick', '')
-force = (params.get('force', 'no').upper() == 'YES')
-status = self.s.glusterVolumeReplaceBrickCommit(volumeName,
-existingBrick,
-newBrick,
-force)
+status = self.s.glusterVolumeReplaceBrickCommitForce(volumeName,
+ existingBrick,
+ newBrick)
return status['status']['code'], status['status']['message']
def do_glusterVolumeRemoveBrickStart(self, args):
@@ -825,10 +823,10 @@
'gluster cluster',
'remove server from gluster cluster'
)),
- 'glusterVolumeReplaceBrickCommit': (
- serv.do_glusterVolumeReplaceBrickCommit,
+ 'glusterVolumeReplaceBrickCommitForce': (
+ serv.do_glusterVolumeReplaceBrickCommitForce,
('volumeName= existingBrick= '
- 'newBrick= [force={yes|no}]\n\t'
+ 'newBrick= \n\t'
' is existing volume name\n\t'
' is existing brick\n\t'
' is new brick',
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 2835876..33ed194 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -215,12 +215,11 @@
return self.svdsmProxy.glusterVolumeRebalanceStatus(volumeName)
@exportAsVerb
-def volumeReplaceBrickCommit(self, volumeName, existingBrick, newBrick,
- force=False, options=None):
-self.svdsmProxy.glusterVolumeReplaceBrickCommit(volumeName,
-existingBrick,
-newBrick,
-force)
+def volumeReplaceBrickCommitForce(self, volumeName, existingBrick,
+ newBrick, options=None):
+self.svdsmProxy.glusterVolumeReplaceBrickCommitForce(volumeName,
+ existingBrick,
+ newBrick)
@exportAsVerb
def volumeRemoveBrickStart(self, volumeName, brickList,
diff --git a/vdsm/gluster/apiwrapper.py b/vdsm/gluster/apiwrapper.py
index 578fc92..0a1d16f 100644
--- a/vdsm/gluster/apiwrapper.py
+++ b/vdsm/gluster/apiwrapper.py
@@ -164,6 +164,11 @@
return self._gluster.volumeRemoveBrickForce(volumeName, brickList,
replicaCount)
+def replaceBrickCommitForce(self, volumeName, existingBrick, newBrick):
+return self._gluster.volumeReplaceBrickCommitForce(volumeName,
+ existingBrick,
+ newBrick)
+
def profileInfo(self, volumeName, nfs=False):
return self._gluster.volumeProfileInfo(volumeName, nfs)
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index db9b3fc..8bcb5cb 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -726,18 +726,16 @@
@makePublic
-def volumeReplaceBrickCommit(volumeName, existingBrick, newBrick,
-
