Change in vdsm[master]: gluster: add gluster heal info verb

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: gluster: add gluster heal info verb
..


gluster: add gluster heal info verb

  Add gluster heal info to get list of unsynced entries
present in the given gluster volume.

Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Signed-off-by: Ramesh Nachimuthu 
Reviewed-on: https://gerrit.ovirt.org/56738
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M client/vdsClientGluster.py
M lib/api/vdsm-api-gluster.yml
M tests/Makefile.am
M tests/glusterTestData.py
A tests/glusterVolumeHealInfo.xml
M tests/gluster_cli_tests.py
M vdsm.spec.in
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
11 files changed, 143 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Ramesh N: Verified



-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 12: Code-Review+2

copying score

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 12: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 11: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 11: Code-Review+2

Raising score

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 11: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 11: Code-Review+1

API changes looks good.

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 10:

(2 comments)

https://gerrit.ovirt.org/#/c/56738/10/lib/api/vdsmapi-gluster-schema.json
File lib/api/vdsmapi-gluster-schema.json:

PS10, Line 2219: 17
> Please update the version 4.0 == 4.18.0.
Done


PS10, Line 2232: 17
> Same here
Done


-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 10:

(2 comments)

https://gerrit.ovirt.org/#/c/56738/10/lib/api/vdsmapi-gluster-schema.json
File lib/api/vdsmapi-gluster-schema.json:

PS10, Line 2219: 17
Please update the version 4.0 == 4.18.0.


PS10, Line 2232: 17
Same here


-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 10: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/56738/9/tests/glusterVolumeHealInfo.xml
File tests/glusterVolumeHealInfo.xml:

Line 9:   
Line 10:   
Line 11: ovirt-node-1.test.com:/brick-2
Line 12: Transport endpoint is not connected
Line 13: -
> As per code, the numberOfEntries element is not added if status is not conn
Yes. This is the mock for gluster cli output. Gluster CLI returns '-' for 
numberOfEntries when brick process is down. Actully it doesn't return name and 
hostUuid also.
Line 14:   
Line 15:   
Line 16: ovirt-node-1.test.com:/brick-3
Line 17: Connected


-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/56738/9/tests/glusterVolumeHealInfo.xml
File tests/glusterVolumeHealInfo.xml:

Line 9:   
Line 10:   
Line 11: ovirt-node-1.test.com:/brick-2
Line 12: Transport endpoint is not connected
Line 13: -
As per code, the numberOfEntries element is not added if status is not 
connected?
Line 14:   
Line 15:   
Line 16: ovirt-node-1.test.com:/brick-3
Line 17: Connected


-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 9: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 8: -Code-Review Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 7:

(4 comments)

Patch-set to follow.

https://gerrit.ovirt.org/#/c/56738/7/lib/api/vdsmapi-gluster-schema.json
File lib/api/vdsmapi-gluster-schema.json:

Line 2213: # @status:  Status of the brick
Line 2214: #
Line 2215: # @hostUuid:UUID of the host where the brick is available
Line 2216: #
Line 2217: # @numberOfEntried: Number of entries to be healed from this brick
> numberOfEntries
Done
Line 2218: #
Line 2219: # Since: 4.17.0
Line 2220: ##
Line 2221: {'type': 'HealInfo',


https://gerrit.ovirt.org/#/c/56738/7/tests/glusterVolumeHealInfo.xml
File tests/glusterVolumeHealInfo.xml:

Line 8: 10
Line 9:   
Line 10:   
Line 11: ovirt-node-1.test.com:/brick-2
Line 12: Connected
> How about test with one of the bricks Not Connected? I think the numberOfEn
Will add that case also to text data
Line 13: 0
Line 14:   
Line 15:   
Line 16: ovirt-node-1.test.com:/brick-3


https://gerrit.ovirt.org/#/c/56738/7/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 1596: 
Line 1597: 
Line 1598: def _parseVolumeHealInfo(tree):
Line 1599: """
Line 1600: {'bricks': [{'name': 'server1:/gfs/test-volume_1',
> can we change this to indicate what return output will have like this:
Done
Line 1601:'status': 'Connected'
Line 1602:'numberOfEntries': 10,
Line 1603:'hostUuid': 
'ff4e2cfe-2646-49d7-90dd-0bff530975ed'},
Line 1604:{'name': 'server2:/gfs/test-volume_2',


Line 1616: brick['name'] = el.find('name').text
Line 1617: brick['status'] = el.find('status').text
Line 1618: brick['hostUuid'] = el.get('hostUuid')
Line 1619: if brick['status'] == 'Connected':
Line 1620: brick['numberOfEntries'] = 
el.find('numberOfEntries').text
> else will numberOfEntries be not populated?
Yes. Client side we will check the status first then read numberOfEntries.
Line 1621: healInfo['bricks'].append(brick)
Line 1622: return healInfo
Line 1623: 
Line 1624: 


-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 7:

(4 comments)

https://gerrit.ovirt.org/#/c/56738/7/lib/api/vdsmapi-gluster-schema.json
File lib/api/vdsmapi-gluster-schema.json:

Line 2213: # @status:  Status of the brick
Line 2214: #
Line 2215: # @hostUuid:UUID of the host where the brick is available
Line 2216: #
Line 2217: # @numberOfEntried: Number of entries to be healed from this brick
numberOfEntries
Line 2218: #
Line 2219: # Since: 4.17.0
Line 2220: ##
Line 2221: {'type': 'HealInfo',


https://gerrit.ovirt.org/#/c/56738/7/tests/glusterVolumeHealInfo.xml
File tests/glusterVolumeHealInfo.xml:

Line 8: 10
Line 9:   
Line 10:   
Line 11: ovirt-node-1.test.com:/brick-2
Line 12: Connected
How about test with one of the bricks Not Connected? I think the 
numberOfEntries in this case is N/A - we can check if this case is handled.
Line 13: 0
Line 14:   
Line 15:   
Line 16: ovirt-node-1.test.com:/brick-3


https://gerrit.ovirt.org/#/c/56738/7/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 1596: 
Line 1597: 
Line 1598: def _parseVolumeHealInfo(tree):
Line 1599: """
Line 1600: {'bricks': [{'name': 'server1:/gfs/test-volume_1',
can we change this to indicate what return output will have like this:
{'name': 'Fully qualified Brick path',
 'status' : 'Connected/Not Connected',
 'numberOfEntries' : int,
 'hostUuid' : uuid}
Line 1601:'status': 'Connected'
Line 1602:'numberOfEntries': 10,
Line 1603:'hostUuid': 
'ff4e2cfe-2646-49d7-90dd-0bff530975ed'},
Line 1604:{'name': 'server2:/gfs/test-volume_2',


Line 1616: brick['name'] = el.find('name').text
Line 1617: brick['status'] = el.find('status').text
Line 1618: brick['hostUuid'] = el.get('hostUuid')
Line 1619: if brick['status'] == 'Connected':
Line 1620: brick['numberOfEntries'] = 
el.find('numberOfEntries').text
else will numberOfEntries be not populated?
Line 1621: healInfo['bricks'].append(brick)
Line 1622: return healInfo
Line 1623: 
Line 1624: 


-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[dnarayan]

Darshan N has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 5:

(3 comments)

https://gerrit.ovirt.org/#/c/56738/5/client/vdsClientGluster.py
File client/vdsClientGluster.py:

PS5, Line 751: remoteServer = params.get('remoteServer', '')
> you don't seem to be using remote-server anywhere
Done


https://gerrit.ovirt.org/#/c/56738/5/lib/api/vdsmapi-gluster-schema.json
File lib/api/vdsmapi-gluster-schema.json:

PS5, Line 2215: 'command': {'class': 'GlusterVolume', 'name': 'healInfo'},
  :  'data': {'volumeName': 'str'}}
> you will have to add "returns".
Done


https://gerrit.ovirt.org/#/c/56738/5/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

PS5, Line 1591: return _parseVolumeHealInfo(xmltree)
> can you have another try except block for this call. Because if this fails 
Done


-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[dnarayan]

Darshan N has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 5:

(3 comments)

https://gerrit.ovirt.org/#/c/56738/5/client/vdsClientGluster.py
File client/vdsClientGluster.py:

PS5, Line 751: remoteServer = params.get('remoteServer', '')
you don't seem to be using remote-server anywhere


https://gerrit.ovirt.org/#/c/56738/5/lib/api/vdsmapi-gluster-schema.json
File lib/api/vdsmapi-gluster-schema.json:

PS5, Line 2215: 'command': {'class': 'GlusterVolume', 'name': 'healInfo'},
  :  'data': {'volumeName': 'str'}}
you will have to add "returns".


https://gerrit.ovirt.org/#/c/56738/5/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

PS5, Line 1591: return _parseVolumeHealInfo(xmltree)
can you have another try except block for this call. Because if this fails it 
wont raise glustercommandfailedexception, instead etreeexception is raised.


-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[rnachimu]

Ramesh N has uploaded a new change for review.

Change subject: gluster: add gluster heal info verb
..

gluster: add gluster heal info verb

  Add gluster heal info to get list of unsynced entries
present in the given gluster volume.

Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Signed-off-by: Ramesh Nachimuthu 
---
M client/vdsClientGluster.py
M lib/api/vdsmapi-gluster-schema.json
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
6 files changed, 74 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/56738/1

diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index 89b90ee..1b03660 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -745,6 +745,15 @@
 pp.pprint(status)
 return status['status']['code'], status['status']['message']
 
+def do_glusterVolumeHealInfo(self, args):
+params = self._eqSplit(args)
+volumeName = params.get('volumeName', '')
+remoteServer = params.get('remoteServer', '')
+
+status = self.s.glusterVolumeHealInfo(volumeName, remoteServer)
+pp.pprint(status)
+return status['status']['code'], status['status']['message']
+
 
 def getGlusterCmdDict(serv):
 return \
@@ -1262,5 +1271,13 @@
  serv.do_glusterProcessesStop,
  ('',
   'Stop gluster processes'
+  )),
+ 'glusterVolumeHealInfo': (
+ serv.do_glusterVolumeHealInfo,
+ ('[volumeName=]\n\t'
+  '[remoteServer=