Change in vdsm[master]: gluster: decommission GlusterVolume
Dan Kenigsberg has uploaded a new change for review. Change subject: gluster: decommission GlusterVolume .. gluster: decommission GlusterVolume GlusterVolume has no semantics beyond these of any other FileVolume. Change-Id: Id023ad3b4c2d6852d1b6b5ce8fdec707524553bc Signed-off-by: Dan Kenigsberg --- M debian/vdsm.install M vdsm.spec.in M vdsm/storage/glusterSD.py D vdsm/storage/glusterVolume.py 4 files changed, 0 insertions(+), 15 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/21124/1 diff --git a/debian/vdsm.install b/debian/vdsm.install index 55464a3..dd447f6 100644 --- a/debian/vdsm.install +++ b/debian/vdsm.install @@ -89,7 +89,6 @@ ./usr/share/vdsm/storage/fileVolume.py ./usr/share/vdsm/storage/fuser.py ./usr/share/vdsm/storage/glusterSD.py -./usr/share/vdsm/storage/glusterVolume.py ./usr/share/vdsm/storage/hba.py ./usr/share/vdsm/storage/hsm.py ./usr/share/vdsm/storage/image.py diff --git a/vdsm.spec.in b/vdsm.spec.in index de066f5..714b11d 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -880,7 +880,6 @@ %{_datadir}/%{vdsm_name}/storage/fuser.py* %if 0%{?with_gluster} %{_datadir}/%{vdsm_name}/storage/glusterSD.py* -%{_datadir}/%{vdsm_name}/storage/glusterVolume.py* %else %exclude %{_datadir}/%{vdsm_name}/storage/gluster* %endif diff --git a/vdsm/storage/glusterSD.py b/vdsm/storage/glusterSD.py index 7458d10..c048dbd 100644 --- a/vdsm/storage/glusterSD.py +++ b/vdsm/storage/glusterSD.py @@ -1,7 +1,6 @@ import os import nfsSD import sd -import glusterVolume import fileSD import mount import storage_exception as se @@ -15,9 +14,6 @@ def getMountPoint(cls, mountPath): return os.path.join(cls.storage_repository, sd.DOMAIN_MNT_POINT, sd.GLUSTERSD_DIR, mountPath) - -def getVolumeClass(self): -return glusterVolume.GlusterVolume @staticmethod def findDomainPath(sdUUID): diff --git a/vdsm/storage/glusterVolume.py b/vdsm/storage/glusterVolume.py deleted file mode 100644 index 1406cdd..000 --- a/vdsm/storage/glusterVolume.py +++ /dev/null @@ -1,9 +0,0 @@ -import fileVolume - - -class GlusterVolume(fileVolume.FileVolume): - -def __init__(self, repoPath, sdUUID, imgUUID, volUUID): -fileVolume.FileVolume.__init__(self, repoPath, sdUUID, imgUUID, - volUUID) - -- To view, visit http://gerrit.ovirt.org/21124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id023ad3b4c2d6852d1b6b5ce8fdec707524553bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: decommission GlusterVolume
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: decommission GlusterVolume .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4519/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5319/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5397/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id023ad3b4c2d6852d1b6b5ce8fdec707524553bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: decommission GlusterVolume
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: decommission GlusterVolume .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4524/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5324/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5402/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id023ad3b4c2d6852d1b6b5ce8fdec707524553bc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: decommission GlusterVolume
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: decommission GlusterVolume .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4629/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5429/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5508/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id023ad3b4c2d6852d1b6b5ce8fdec707524553bc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: decommission GlusterVolume
Dan Kenigsberg has abandoned this change. Change subject: gluster: decommission GlusterVolume .. Abandoned a proper solution for this breakage should include reporting the gluster-native parameter per chain element, not only per the link. -- To view, visit http://gerrit.ovirt.org/21124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id023ad3b4c2d6852d1b6b5ce8fdec707524553bc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches