Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
Piotr Kliczewski has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 6: Code-Review+1 api and schema changes looks good -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: volume snapshot activate and deactivate verbs. .. gluster: volume snapshot activate and deactivate verbs. This patch adds two new verbs to activate and deactivate gluster volume snapshots. *glusterSnapshotActivate: Activates gluster volume snapshot. It takes force as optional argument. when force is provided snapshot is activated forcefully. Returns success/failure. *glusterSnapshotDeactivate: Deactivates gluster volume snapshot. Returns success/failure. Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Signed-off-by: Darshan N dnara...@redhat.com Reviewed-on: http://gerrit.ovirt.org/34579 Reviewed-by: Piotr Kliczewski piotr.kliczew...@gmail.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M client/vdsClientGluster.py M vdsm/gluster/api.py M vdsm/gluster/apiwrapper.py M vdsm/gluster/cli.py M vdsm/gluster/exception.py M vdsm/rpc/vdsmapi-gluster-schema.json 6 files changed, 111 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Darshan N: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
Dan Kenigsberg has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/601/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/597/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/190/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/202/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4586/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/204/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/579/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6424/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/206/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/604/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15586/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15418/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14614/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
Darshan N has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 6: Verified+1 Rebased patch set 5 -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
Bala.FA has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15003/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14834/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14046/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14036/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13247/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14204/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14038/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13249/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14206/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13360/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13199/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12409/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
Darshan N has uploaded a new change for review.
Change subject: gluster: volume snapshot activate and deactivate verbs.
..
gluster: volume snapshot activate and deactivate verbs.
This patch adds two new verbs to activate and deactivate
gluster volume snapshots.
*glusterSnapshotActivate: activates gluster volume
snapshot. Returns success/failure.
*glusterSnapshotDeactivate: deactivates gluster volume
snapshot. Returns success/failure.
Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422
Signed-off-by: Darshan n dnara...@redhat.com
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm/rpc/vdsmapi-gluster-schema.json
6 files changed, 111 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/34579/1
diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index bdd7a6c..6145105 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -452,6 +452,23 @@
pp.pprint(status)
return status['status']['code'], status['status']['message']
+def do_glusterSnapshotActivate(self, args):
+params = self._eqSplit(args)
+snapName = params.get('snapName', '')
+force = (params.get('force', 'no').upper() == 'YES')
+
+status = self.s.glusterSnapshotActivate(snapName, force)
+pp.pprint(status)
+return status['status']['code'], status['status']['message']
+
+def do_glusterSnapshotDeactivate(self, args):
+params = self._eqSplit(args)
+snapName = params.get('snapName', '')
+
+status = self.s.glusterSnapshotDeactivate(snapName)
+pp.pprint(status)
+return status['status']['code'], status['status']['message']
+
def getGlusterCmdDict(serv):
return \
@@ -765,4 +782,15 @@
('snapName=snap_name',
'delete snapshot'
)),
+ 'glusterSnapshotActivate': (
+ serv.do_glusterSnapshotActivate,
+ ('snapName=snap_name '
+ '[force={yes|no}]',
+ 'activate snapshot'
+ )),
+ 'glusterSnapshotDeactivate': (
+ serv.do_glusterSnapshotDeactivate,
+ ('snapName=snap_name',
+ 'de-activate snapshot'
+ )),
}
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 92bdb74..9126359 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -336,6 +336,14 @@
def snapshotDelete(self, snapName):
self.svdsmProxy.glusterSnapshotDelete(snapName)
+@exportAsVerb
+def snapshotActivate(self, snapName, force=False):
+self.svdsmProxy.glusterSnapshotActivate(snapName, force)
+
+@exportAsVerb
+def snapshotDeactivate(self, snapName):
+self.svdsmProxy.glusterSnapshotDeactivate(snapName)
+
def getGlusterMethods(gluster):
l = []
diff --git a/vdsm/gluster/apiwrapper.py b/vdsm/gluster/apiwrapper.py
index 9639c6c..fa26f9b 100644
--- a/vdsm/gluster/apiwrapper.py
+++ b/vdsm/gluster/apiwrapper.py
@@ -190,3 +190,9 @@
def delete(self, snapName):
return self._gluster.snapshotDelete(snapName)
+
+def activate(self, snapName, force=False):
+return self._gluster.snapshotActivate(snapName, force)
+
+def deactivate(self, snapName):
+return self._gluster.snapshotDeactivate(snapName)
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index 10c6cb2..145870d 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -1087,3 +1087,28 @@
return True
except ge.GlusterCmdFailedException as e:
raise ge.GlusterSnapshotDeleteFailedException(rc=e.rc, err=e.err)
+
+
+@makePublic
+def snapshotActivate(snapName, force=False):
+command = _getGlusterSnapshotCmd() + [activate, snapName]
+
+if force:
+command.append('force')
+
+try:
+_execGlusterXml(command)
+return True
+except ge.GlusterCmdFailedException as e:
+raise ge.GlusterSnapshotActivateFailedException(rc=e.rc, err=e.err)
+
+
+@makePublic
+def snapshotDeactivate(snapName):
+command = _getGlusterSnapshotCmd() + [deactivate, snapName]
+
+try:
+_execGlusterXml(command)
+return True
+except ge.GlusterCmdFailedException as e:
+raise ge.GlusterSnapshotDeactivateFailedException(rc=e.rc, err=e.err)
diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py
index e4e6b7d..becb610 100644
--- a/vdsm/gluster/exception.py
+++ b/vdsm/gluster/exception.py
@@ -524,3 +524,13 @@
GlusterSnapshotException):
code = 4602
message = Snapshot delete failed
+
+
+class GlusterSnapshotActivateFailedException(GlusterSnapshotException):
+code = 4603
+message = Snapshot activate failed
+
+
+class GlusterSnapshotDeactivateFailedException(GlusterSnapshotException):
+code = 4604
+message = Snapshot de-activate
Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13245/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13085/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12295/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9a99ec7e3726282eccb771a4cfd9fc80ea8422 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
