Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. gluster:Remove support for Replace gluster brick with data migration. This patch removes verbs related to replace gluster brick with data migration. Now only replace brick with commit is retained. As this feature is deprecated in glusterfs-3.7 on wards. These verbs were not consumed by engine, so it should not cause any backward-compatibility issues when removed. The list of verbs removed are as follows: *volumeReplaceBrickStart *volumeReplaceBrickAbort *volumeReplaceBrickPause *volumeReplaceBrickStatus *volumeReplaceBrickCommit Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Signed-off-by: Darshan N Reviewed-on: https://gerrit.ovirt.org/40545 Continuous-Integration: Jenkins CI Reviewed-by: Bala.FA Reviewed-by: Piotr Kliczewski Reviewed-by: Dan Kenigsberg --- M client/vdsClientGluster.py M vdsm/gluster/api.py M vdsm/gluster/apiwrapper.py M vdsm/gluster/cli.py M vdsm/gluster/exception.py M vdsm/rpc/vdsmapi-gluster-schema.json 6 files changed, 0 insertions(+), 273 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Bala.FA: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
Dan Kenigsberg has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
automat...@ovirt.org has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
Piotr Kliczewski has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
Darshan N has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
Bala.FA has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
automat...@ovirt.org has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
Darshan N has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
Darshan N has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/40545/2//COMMIT_MSG Commit Message: Line 14: > Please list removed verbs here Done https://gerrit.ovirt.org/#/c/40545/2/vdsm/gluster/cli.py File vdsm/gluster/cli.py: Line 791: > without volumeReplaceBrickStart() how is volumeReplaceBrickCommit() going t glusterfs has removed even this. Earlier when replace brick was asynchronous with data migration support start was valid. Now replace brick can be executed only with commit force. the corresponding glusterfs patch: http://review.gluster.org/#/c/10577/ -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
automat...@ovirt.org has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
Bala.FA has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 2: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/40545/2//COMMIT_MSG Commit Message: Line 14: Please list removed verbs here https://gerrit.ovirt.org/#/c/40545/2/vdsm/gluster/cli.py File vdsm/gluster/cli.py: Line 791: without volumeReplaceBrickStart() how is volumeReplaceBrickCommit() going to work? -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
Timothy Asir has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
automat...@ovirt.org has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
Darshan N has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
Darshan N has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
automat...@ovirt.org has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:Remove support for Replace gluster brick with data m...
Darshan N has uploaded a new change for review. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. gluster:Remove support for Replace gluster brick with data migration. This patch removes verbs related to replace gluster brick with data migration. Now only replace brick with commit force option is retained. As this feature is deprecated in glusterfs-3.7 on wards. These verbs were not consumed by engine, so it should not cause any backward-compatibility issues when removed. Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Signed-off-by: Darshan N --- M client/vdsClientGluster.py M vdsm/gluster/api.py M vdsm/gluster/apiwrapper.py M vdsm/gluster/cli.py M vdsm/gluster/exception.py M vdsm/rpc/vdsmapi-gluster-schema.json 6 files changed, 26 insertions(+), 228 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/40545/1 diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py index 4f53eb4..cd0e2f3 100644 --- a/client/vdsClientGluster.py +++ b/client/vdsClientGluster.py @@ -163,56 +163,15 @@ status = self.s.glusterHostRemoveByUuid(hostUuid, force) return status['status']['code'], status['status']['message'] -def do_glusterVolumeReplaceBrickStart(self, args): +def do_glusterVolumeReplaceBrickCommitForce(self, args): params = self._eqSplit(args) volumeName = params.get('volumeName', '') existingBrick = params.get('existingBrick', '') newBrick = params.get('newBrick', '') -status = self.s.glusterVolumeReplaceBrickStart(volumeName, - existingBrick, - newBrick) -pp.pprint(status) -return status['status']['code'], status['status']['message'] - -def do_glusterVolumeReplaceBrickAbort(self, args): -params = self._eqSplit(args) -volumeName = params.get('volumeName', '') -existingBrick = params.get('existingBrick', '') -newBrick = params.get('newBrick', '') - -status = self.s.glusterVolumeReplaceBrickAbort(volumeName, - existingBrick, - newBrick) -return status['status']['code'], status['status']['message'] - -def do_glusterVolumeReplaceBrickPause(self, args): -params = self._eqSplit(args) -volumeName = params.get('volumeName', '') -existingBrick = params.get('existingBrick', '') -newBrick = params.get('newBrick', '') - -status = self.s.glusterVolumeReplaceBrickPause(volumeName, - existingBrick, - newBrick) -return status['status']['code'], status['status']['message'] - -def do_glusterVolumeReplaceBrickStatus(self, args): -status = self.s.glusterVolumeReplaceBrickStatus(args[0], args[1], -args[2]) -return status['status']['code'], status['status']['message'] - -def do_glusterVolumeReplaceBrickCommit(self, args): -params = self._eqSplit(args) -volumeName = params.get('volumeName', '') -existingBrick = params.get('existingBrick', '') -newBrick = params.get('newBrick', '') -force = (params.get('force', 'no').upper() == 'YES') - -status = self.s.glusterVolumeReplaceBrickCommit(volumeName, -existingBrick, -newBrick, -force) +status = self.s.glusterVolumeReplaceBrickCommitForce(volumeName, + existingBrick, + newBrick) return status['status']['code'], status['status']['message'] def do_glusterVolumeRemoveBrickStart(self, args): @@ -864,44 +823,10 @@ 'gluster cluster', 'remove server from gluster cluster' )), - 'glusterVolumeReplaceBrickStart': ( - serv.do_glusterVolumeReplaceBrickStart, + 'glusterVolumeReplaceBrickCommitForce': ( + serv.do_glusterVolumeReplaceBrickCommitForce, ('volumeName= existingBrick= ' - 'newBrick=\n\t' - ' is existing volume name\n\t' - ' is existing brick\n\t' - ' is new brick', - 'start volume replace brick' - )), - 'glusterVolumeReplaceBrickAbort': ( - serv.do_glusterVolumeReplaceBrickAbort, - ('volumeName= existingBrick= ' - 'newBrick=\n\t' - ' is existing volume name\n\t' -