Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

2016-03-22 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: hostdev/sr-iov: don't reattach devices
..


hostdev/sr-iov: don't reattach devices

Similar to [1]. As SR-IOV devices
are still classical VFIO devices, we want to avoid implicitly rebinding
them to the host drivers for reasons outlines in [1].

[1] I1136292cb7e9d13a8202b1f5162299d2155e8036

Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Signed-off-by: Martin Polednik 
Reviewed-on: https://gerrit.ovirt.org/54937
Reviewed-by: Francesco Romani 
Continuous-Integration: Jenkins CI
---
M vdsm/virt/vm.py
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Martin Polednik: Verified



-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

2016-03-22 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hostdev/sr-iov: don't reattach devices
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

2016-03-22 Thread michal . skrivanek 
Michal Skrivanek has posted comments on this change.

Change subject: hostdev/sr-iov: don't reattach devices
..


Patch Set 3:

please document in a (suitable) bug the change in behavior and how to reattach 
the device should that be needed by anyone

-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

2016-03-22 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hostdev/sr-iov: don't reattach devices
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

2016-03-21 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hostdev/sr-iov: don't reattach devices
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

2016-03-21 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: hostdev/sr-iov: don't reattach devices
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

2016-03-21 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hostdev/sr-iov: don't reattach devices
..


Patch Set 2: Code-Review+1

if 54936 is ok, this follows suit.

-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

2016-03-21 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hostdev/sr-iov: don't reattach devices
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

2016-03-19 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hostdev/sr-iov: don't reattach devices
..


Patch Set 1: Code-Review-1

(1 comment)

-1 for visibility

https://gerrit.ovirt.org/#/c/54937/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-03-18 15:04:12 +0100
Line 4: Commit: Martin Polednik 
Line 5: CommitDate: 2016-03-18 15:25:56 +0100
Line 6: 
Line 7: hostdev/sr-iov: don't reattach devices
same comment as per patch 54936: please explain why this is important
Line 8: 
Line 9: Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266


-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

2016-03-19 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hostdev/sr-iov: don't reattach devices
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

2016-03-18 Thread mpolednik 
Martin Polednik has uploaded a new change for review.

Change subject: hostdev/sr-iov: don't reattach devices
..

hostdev/sr-iov: don't reattach devices

Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Signed-off-by: Martin Polednik 
---
M vdsm/virt/vm.py
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/54937/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 093a660..f33c8b7 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2314,8 +2314,6 @@
 try:
 self._dom.detachDevice(nicXml)
 self._waitForDeviceRemoval(nic)
-if nic.is_hostdevice:
-hostdev.reattach_detachable(nic.hostdev)
 except HotunplugTimeout as e:
 self.log.error("%s", e)
 self._rollback_nic_hotunplug(nicDev, nic)


-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches