Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 4:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-03-10 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/37701/4/vdsm/caps.py
File vdsm/caps.py:

Line 691: caps['liveSnapshot'] = str(liveSnapSupported).lower()
Line 692: caps['liveMerge'] = str(getLiveMergeSupport()).lower()
Line 693: caps['kdumpStatus'] = _getKdumpStatus()
Line 694: 
Line 695: caps['directedPassthrough'] = 
str(_getDirectedPassthrough()).lower()
didn't we agree to call this directedIO (like Intel does)?
Line 696: 
Line 697: return caps
Line 698: 
Line 699: 


-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-03-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 4:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16171/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15371/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16341/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1147/ : 
FAILURE

-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-03-02 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-03-02 Thread mpolednik
Martin Polednik has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 4: Verified+1

Manually verified by inspecting caps on vtd host.

-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-02-27 Thread mpolednik
Martin Polednik has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 3: Verified+1

Verified manually.

-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-02-27 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 2: Code-Review-1

schema should be updated with the new item

-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-02-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 3:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16142/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15342/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16312/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1118/ : 
FAILURE

-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-02-26 Thread mpolednik
Martin Polednik has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 2: Verified+1

Manually verified on both intel VT-d enabled and disabled host.

-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-02-26 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 2: Code-Review+1

your explanation makes sense to me. Let's get closer to the optimal solution.

-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-02-26 Thread mpolednik
Martin Polednik has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 1: -Verified

(1 comment)

https://gerrit.ovirt.org/#/c/37701/1/vdsm/caps.py
File vdsm/caps.py:

Line 596: return selinux
Line 597: 
Line 598: 
Line 599: def _getDirectedPassthrough():
Line 600: return bool(len(os.listdir('/sys/class/iommu')))
 silly comment:
As far as I understand only dmarX should be present. This is still not 
*perfect* check, because there are various hardware configurations that require 
more setup, but this gets us close.
Line 601: 
Line 602: 
Line 603: def get():
Line 604: targetArch = getTargetArch()


-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-02-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16106/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15306/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16276/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1082/ : 
FAILURE

-- 
To view, visit https://gerrit.ovirt.org/37701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-02-12 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/37701/1//COMMIT_MSG
Commit Message:

Line 7: hostdev: display directed-passthrough status in caps
Line 8: 
Line 9: Whether the underlying host supports directed passthrough can be
Line 10: read via sysfs /sys/class/iommu, where support would be indicated
Line 11: by pressence of dma remapping indicator - dmarX (where X = 0).
typo: double 's'
Line 12: This patch exposes this fact in caps via directedPassthrough key.
Line 13: 
Line 14: Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460


http://gerrit.ovirt.org/#/c/37701/1/vdsm/caps.py
File vdsm/caps.py:

Line 596: return selinux
Line 597: 
Line 598: 
Line 599: def _getDirectedPassthrough():
Line 600: return bool(len(os.listdir('/sys/class/iommu')))
silly comment:
  return bool(os.listdir('/sys/class/iommu'))
?

A bit more serious concern: in that directory, only dmarX files could be 
present or it is possible that something else
could wrongly be misinterpreted as dmarX?

Just asking, I do not really know yet about how the directory should look like
Line 601: 
Line 602: 
Line 603: def get():
Line 604: targetArch = getTargetArch()


-- 
To view, visit http://gerrit.ovirt.org/37701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15582/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14780/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15751/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/558/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-02-11 Thread mpolednik
Martin Polednik has uploaded a new change for review.

Change subject: hostdev: display directed-passthrough status in caps
..

hostdev: display directed-passthrough status in caps

Whether the underlying host supports directed passthrough can be
read via sysfs /sys/class/iommu, where support would be indicated
by pressence of dma remapping indicator - dmarX (where X = 0).
This patch exposes this fact in caps via directedPassthrough key.

Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Signed-off-by: Martin Polednik mpoled...@redhat.com
---
M vdsm/caps.py
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/37701/1

diff --git a/vdsm/caps.py b/vdsm/caps.py
index cb60e34..eee1032 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -596,6 +596,10 @@
 return selinux
 
 
+def _getDirectedPassthrough():
+return bool(len(os.listdir('/sys/class/iommu')))
+
+
 def get():
 targetArch = getTargetArch()
 
@@ -688,6 +692,8 @@
 caps['liveMerge'] = str(getLiveMergeSupport()).lower()
 caps['kdumpStatus'] = _getKdumpStatus()
 
+caps['directedPassthrough'] = str(_getDirectedPassthrough())
+
 return caps
 
 


-- 
To view, visit http://gerrit.ovirt.org/37701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: hostdev: display directed-passthrough status in caps

2015-02-11 Thread mpolednik
Martin Polednik has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/37701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches