Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

2016-05-17 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

2016-05-17 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..


hostdev: fix rmAppropriateSCSIDevice in reattach

rmAppropriateSCSIDevice also requires name argument. This slipped as we
removed reattaching host devices.

Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Signed-off-by: Martin Polednik 
Reviewed-on: https://gerrit.ovirt.org/57374
Reviewed-by: Milan Zamazal 
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Francesco Romani 
---
M lib/vdsm/hostdev.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Looks good to me, but someone else must approve
  Martin Polednik: Verified



-- 
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

2016-05-17 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..


Patch Set 6: Code-Review+2

raising my score

-- 
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

2016-05-16 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

2016-05-15 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

2016-05-12 Thread mzamazal 
Milan Zamazal has posted comments on this change.

Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

2016-05-12 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

2016-05-12 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

2016-05-12 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/57374/4/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:

PS4, Line 406: device_name
> For my understanding: so what happens with current master?
It's never called for scsi devices without the followup patch - so nothing 
pretty much. :)


-- 
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

2016-05-12 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/57374/4/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:

PS4, Line 406: device_name
For my understanding: so what happens with current master?
Does it work? Does it do additional wasteful work?


-- 
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

2016-05-12 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

2016-05-12 Thread mpolednik 
Martin Polednik has uploaded a new change for review.

Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach
..

hostdev: fix rmAppropriateSCSIDevice in reattach

rmAppropriateSCSIDevice also requires name argument. This slipped as we
removed reattaching host devices.

Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Signed-off-by: Martin Polednik 
---
M lib/vdsm/hostdev.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/57374/1

diff --git a/lib/vdsm/hostdev.py b/lib/vdsm/hostdev.py
index 617a241..9eb503f 100644
--- a/lib/vdsm/hostdev.py
+++ b/lib/vdsm/hostdev.py
@@ -403,7 +403,7 @@
 raise UnsuitableSCSIDevice
 
 supervdsm.getProxy().rmAppropriateSCSIDevice(
-device_params['udev_path'])
+device_name, device_params['udev_path'])
 
 
 def change_numvfs(device_name, numvfs):


-- 
To view, visit https://gerrit.ovirt.org/57374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I90e0e38bc86fa52bb654934b03f080490ba23fd8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches