Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
Dan Kenigsberg has submitted this change and it was merged. Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface .. hsm: Distinguish between iface and initiator when creating iSCSI iface VDSM mistakely assumed that iface name and iface initiator name are the same, so if admin configured specific initiator name in the host its value is mistakenly overwritten by ifaceName in the iface file. In such a case the host fails to establish the iSCSI connection with the target. Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945 Signed-off-by: Sergey Gotliv Reviewed-on: http://gerrit.ovirt.org/25628 Reviewed-by: Nir Soffer Reviewed-by: Federico Simoncelli --- M vdsm/storage/hsm.py 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, approved Sergey Gotliv: Verified -- To view, visit http://gerrit.ovirt.org/25628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
Sergey Gotliv has posted comments on this change. Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface .. Patch Set 2: Steps to verify: 1. Create iSCSI storage domain from Engine - verify that storage domain is successfully created. 2. Define iSCSI bond from the Engine (Data Centers -> iSCSI Multipathing) - verify that all iSCSI Storage Domains are still active and iface file/s are created under /var/lib/iscsi/ifaces and that iface file doesn't contain initiatorname property. -- To view, visit http://gerrit.ovirt.org/25628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
Sergey Gotliv has posted comments on this change. Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/25628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
Sergey Gotliv has posted comments on this change. Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface .. Patch Set 2: Sure, the Engine patch is ready to go. -- To view, visit http://gerrit.ovirt.org/25628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
Federico Simoncelli has posted comments on this change. Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface .. Patch Set 2: Code-Review+2 I assume you're going to backport this to 3.4. Just make sure that engine is aware that this change is available only starting from 3.4 (block its use for dc < 3.4). -- To view, visit http://gerrit.ovirt.org/25628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
Nir Soffer has posted comments on this change. Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7448/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6656/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7562/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7448/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6656/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7557/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Distinguish between iface and initiator when creating
iSCSI iface
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25628/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 147: sd.POSIXFS_DOMAIN: 'posixfs',
Line 148: sd.GLUSTERFS_DOMAIN: 'glusterfs'}
Line 149:
Line 150:
Line 151: def _resolveIscsiIface(ifaceName, initiatorName):
> Renaming this function is not related to this fix. Can you split it to sepa
Sure
Line 152: if not ifaceName:
Line 153: return iscsi.IscsiInterface('default')
Line 154:
Line 155: for iface in iscsi.iterateIscsiInterfaces():
--
To view, visit http://gerrit.ovirt.org/25628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
Nir Soffer has posted comments on this change.
Change subject: hsm: Distinguish between iface and initiator when creating
iSCSI iface
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25628/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 147: sd.POSIXFS_DOMAIN: 'posixfs',
Line 148: sd.GLUSTERFS_DOMAIN: 'glusterfs'}
Line 149:
Line 150:
Line 151: def _resolveIscsiIface(ifaceName, initiatorName):
Renaming this function is not related to this fix. Can you split it to separate
patch?
Line 152: if not ifaceName:
Line 153: return iscsi.IscsiInterface('default')
Line 154:
Line 155: for iface in iscsi.iterateIscsiInterfaces():
--
To view, visit http://gerrit.ovirt.org/25628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7444/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6652/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7553/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
Sergey Gotliv has uploaded a new change for review.
Change subject: hsm: Distinguish between iface and initiator when creating
iSCSI iface
..
hsm: Distinguish between iface and initiator when creating iSCSI iface
VDSM mistakely assumed that iface name and iface initiator name is the
same, so if admin configured specific initiator name in the host its
mistakenly overriten by ifaceName in the iface file. In such a case the
iSCSI connection is failed.
Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945
Signed-off-by: Sergey Gotliv
---
M vdsm/storage/hsm.py
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/25628/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 2e9dbe5..f7f9cdd 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -148,7 +148,7 @@
sd.GLUSTERFS_DOMAIN: 'glusterfs'}
-def _BCInitiatorNameResolve(ifaceName):
+def _resolveIscsiIface(ifaceName, initiatorName):
if not ifaceName:
return iscsi.IscsiInterface('default')
@@ -156,7 +156,7 @@
if iface.name == ifaceName:
return iface
-iface = iscsi.IscsiInterface(ifaceName, initiatorName=ifaceName)
+iface = iscsi.IscsiInterface(ifaceName, initiatorName=initiatorName)
iface.create()
return iface
@@ -230,7 +230,8 @@
target = iscsi.IscsiTarget(portal, tpgt, conDict.get('iqn', None))
-iface = _BCInitiatorNameResolve(conDict.get('initiatorName', None))
+iface = _resolveIscsiIface(conDict.get('ifaceName', None),
+ conDict.get('initiatorName', None))
cred = None
username = conDict.get('user', None)
--
To view, visit http://gerrit.ovirt.org/25628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
