Change in vdsm[master]: hsm.py: Deprecate getVGList
gerrit-hooks has posted comments on this change. Change subject: hsm.py: Deprecate getVGList .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/48998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm.py: Deprecate getVGList
Nir Soffer has submitted this change and it was merged. Change subject: hsm.py: Deprecate getVGList .. hsm.py: Deprecate getVGList oVirt Engine commit 4312bfd removed all the usages of getVGList from the engine's code. Since this verb is useless to us (the same functionality is covered by getVGInfo and getDeviceList), and since it's no longer called, this patch flags it as @deprecated, with the intent to remove it completely in the future. Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889 Signed-off-by: Allon Mureinik Reviewed-on: https://gerrit.ovirt.org/48998 Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI Reviewed-by: Adam Litke --- M vdsm/storage/hsm.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Adam Litke: Looks good to me, but someone else must approve Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/48998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm.py: Deprecate getVGList
Adam Litke has posted comments on this change. Change subject: hsm.py: Deprecate getVGList .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm.py: Deprecate getVGList
Nir Soffer has posted comments on this change. Change subject: hsm.py: Deprecate getVGList .. Patch Set 1: Code-Review+2 Waiting for Adam review -- To view, visit https://gerrit.ovirt.org/48998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm.py: Deprecate getVGList
gerrit-hooks has posted comments on this change. Change subject: hsm.py: Deprecate getVGList .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm.py: Deprecate getVGList
Allon Mureinik has posted comments on this change. Change subject: hsm.py: Deprecate getVGList .. Patch Set 1: Verified+1 Verification: code-only -- To view, visit https://gerrit.ovirt.org/48998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm.py: Deprecate getVGList
Allon Mureinik has uploaded a new change for review. Change subject: hsm.py: Deprecate getVGList .. hsm.py: Deprecate getVGList oVirt Engine commit 4312bfd removed all the usages of getVGList from the engine's code. Since this verb is useless to us (the same functionality is covered by getVGInfo and getDeviceList), and since it's no longer called, this patch flags it as @deprecated, with the intent to remove it completely in the future. Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889 Signed-off-by: Allon Mureinik --- M vdsm/storage/hsm.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/48998/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index a91ab28..68b90ea 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -2925,6 +2925,7 @@ info["GUID"] = str(pv.guid) return info +@deprecated @public def getVGList(self, storageType=None, options=None): """ -- To view, visit https://gerrit.ovirt.org/48998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
