Change in vdsm[master]: ifcfg: always print IPV6INIT=yes/no

2015-05-07 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: ifcfg: always print IPV6INIT=yes/no
..


ifcfg: always print IPV6INIT=yes/no

EL6's /etc/sysconfig/network-scripts/ifup-ipv6 had a condition:
  [ "$IPV6INIT" = "yes" ] || exit 0

which changed to an inverted one in EL7:
  [[ "$IPV6INIT" = [nN0]* ]] && exit 0

This makes IPV6INIT mandatory in ifcfg files.

Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18
Signed-off-by: Ondřej Svoboda 
Reviewed-on: https://gerrit.ovirt.org/40610
Reviewed-by: Dan Kenigsberg 
---
M vdsm/network/configurators/ifcfg.py
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Ondřej Svoboda: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/40610
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: always print IPV6INIT=yes/no

2015-05-07 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: ifcfg: always print IPV6INIT=yes/no
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/40610
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: always print IPV6INIT=yes/no

2015-05-07 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: ifcfg: always print IPV6INIT=yes/no
..


Patch Set 1: Code-Review+2

Understood. In a follow up patch, please call sysctl.{dis,en}able_ipv6() after 
the bridge device exists.

-- 
To view, visit https://gerrit.ovirt.org/40610
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: always print IPV6INIT=yes/no

2015-05-06 Thread osvoboda 
Ondřej Svoboda has posted comments on this change.

Change subject: ifcfg: always print IPV6INIT=yes/no
..


Patch Set 1: Verified+1

Even with IPV6INIT=no (which _was correctly added_ to an ifcfg file for a 
bridge) the bridge got a link-local IPv6 address.

This is due to initscripts not actually _disabling_ IPv6 on the bridge (via a 
sysctl option 'disable_ipv6') before creating it (at least grepping initscript 
sources for 'disable_ipv6' returns nothing). I think initscripts developers 
encountered some bugs when doing so.

The LL address is unproblematic and it's good to have it in case we want to 
enable DHCPv6 on the same bridge later.

-- 
To view, visit https://gerrit.ovirt.org/40610
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: always print IPV6INIT=yes/no

2015-05-06 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: ifcfg: always print IPV6INIT=yes/no
..


Patch Set 1: Code-Review-1

Please add a functional test, that verifies that bridges does not obtain an 
ipv6 address needlessly.

-- 
To view, visit https://gerrit.ovirt.org/40610
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: always print IPV6INIT=yes/no

2015-05-06 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: ifcfg: always print IPV6INIT=yes/no
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/40610
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: always print IPV6INIT=yes/no

2015-05-06 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: ifcfg: always print IPV6INIT=yes/no
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40610
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: always print IPV6INIT=yes/no

2015-05-06 Thread osvoboda 
Ondřej Svoboda has uploaded a new change for review.

Change subject: ifcfg: always print IPV6INIT=yes/no
..

ifcfg: always print IPV6INIT=yes/no

EL6's /etc/sysconfig/network-scripts/ifup-ipv6 had a condition:
  [ "$IPV6INIT" = "yes" ] || exit 0

which changed to an inverted one in EL7:
  [[ "$IPV6INIT" = [nN0]* ]] && exit 0

This makes IPV6INIT mandatory in ifcfg files.

Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18
Signed-off-by: Ondřej Svoboda 
---
M vdsm/network/configurators/ifcfg.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/40610/1

diff --git a/vdsm/network/configurators/ifcfg.py 
b/vdsm/network/configurators/ifcfg.py
index 6d35c0a..26efd6f 100644
--- a/vdsm/network/configurators/ifcfg.py
+++ b/vdsm/network/configurators/ifcfg.py
@@ -583,8 +583,9 @@
 if ipv4.defaultRoute is not None:
 cfg += 'DEFROUTE=%s\n' % _to_ifcfg_bool(ipv4.defaultRoute)
 cfg += 'NM_CONTROLLED=no\n'
-if ipv6.address or ipv6.ipv6autoconf or ipv6.dhcpv6:
-cfg += 'IPV6INIT=yes\n'
+enable_ipv6 = ipv6.address or ipv6.ipv6autoconf or ipv6.dhcpv6
+cfg += 'IPV6INIT=%s\n' % _to_ifcfg_bool(enable_ipv6)
+if enable_ipv6:
 if ipv6.address is not None:
 cfg += 'IPV6ADDR=%s\n' % pipes.quote(ipv6.address)
 if ipv6.gateway is not None:


-- 
To view, visit https://gerrit.ovirt.org/40610
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I364cfaebc79624c6ab1153cf26bd3ca2a2c4ef18
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches