Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
Itamar Heim has abandoned this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Abandoned no comment for 30 days post last ping. abandoning. please re-open if/when relevant and/or ping reviewers directly / promote discussion about the patch in the mailing list. -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
Itamar Heim has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 4: ping? -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 4: (1 inline comment) Commit Message Line 5: CommitDate: 2013-06-04 22:15:54 +0800 Line 6: Line 7: ifcfg: preserve 'NM_CONTROLLED=no' on removal Line 8: Line 9: Since the ifcfg based network configuration conflicts with It is because of the old-known problem of NM taking down an interface when it realizes that it is not one it should manage. This patch solves the issue because it makes non-vdsm controlled ifaces be non-managed, so when we take control of them NM will not take them down. Line 10: NetworkManager, we still need preserve configuration Line 11: 'NM_CONTROLLED=no' on removing nic. Line 12: Line 13: Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
Mark Wu has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment) Commit Message Line 5: CommitDate: 2013-06-04 22:15:54 +0800 Line 6: Line 7: ifcfg: preserve 'NM_CONTROLLED=no' on removal Line 8: Line 9: Since the ifcfg based network configuration conflicts with Good question! But I am sorry that I can't answer you. This problem was found when I tested other patches. The test failed because of the intervention by NetworkManager, and fixed by this patch. The bad thing is that I can't remember the exact case. I don't want to convince you by such vague memory. I think we can come back to this problem again when we hit the problem again. Line 10: NetworkManager, we still need preserve configuration Line 11: 'NM_CONTROLLED=no' on removing nic. Line 12: Line 13: Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment) Commit Message Line 5: CommitDate: 2013-06-04 22:15:54 +0800 Line 6: Line 7: ifcfg: preserve 'NM_CONTROLLED=no' on removal Line 8: Line 9: Since the ifcfg based network configuration conflicts with Sorry, I do not understand the new conflict with Network Manager. If we are not using the interface, why shouldn't NM play with it? Line 10: NetworkManager, we still need preserve configuration Line 11: 'NM_CONTROLLED=no' on removing nic. Line 12: Line 13: Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
Mark Wu has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
Giuseppe Vallarelli has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 4: Looks good to me, but someone else must approve Agreed. If the ifcfg is being used it should preclude NM to control those interfaces. -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2563/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1740/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2636/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2515/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1688/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2586/ : FAILURE -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2454/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1623/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2524/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
Mark Wu has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1623/ (3/3) -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2454/ (1/3) -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
Mark Wu has uploaded a new change for review.
Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal
..
ifcfg: preserve 'NM_CONTROLLED=no' on removal
Since the ifcfg based network configuration conflicts with
NetworkManager, we still need preserve configuration
'NM_CONTROLLED=no' on removing nic.
Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de
Signed-off-by: Mark Wu
---
M vdsm/netconf/ifcfg.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/15148/1
diff --git a/vdsm/netconf/ifcfg.py b/vdsm/netconf/ifcfg.py
index df172fb..09da70f 100644
--- a/vdsm/netconf/ifcfg.py
+++ b/vdsm/netconf/ifcfg.py
@@ -634,7 +634,8 @@
hwlines = [line for line in open(cf).readlines()
if line.startswith('HWADDR=')]
l = ['DEVICE=%s\n' % nic, 'ONBOOT=yes\n',
- 'MTU=%s\n' % netinfo.DEFAULT_MTU] + hwlines
+ 'MTU=%s\n' % netinfo.DEFAULT_MTU,
+ 'NM_CONTROLLED=no\n'] + hwlines
open(cf, 'w').writelines(l)
except IOError:
pass
--
To view, visit http://gerrit.ovirt.org/15148
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: preserve 'NM_CONTROLLED=no' on removal
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: preserve 'NM_CONTROLLED=no' on removal .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2524/ (2/3) -- To view, visit http://gerrit.ovirt.org/15148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iece96e419b1abc4d320aee33e57b471aab96f2de Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
