Change in vdsm[master]: janitorial: vm: switch to response.error()
automat...@ovirt.org has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
automat...@ovirt.org has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
automat...@ovirt.org has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
automat...@ovirt.org has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
automat...@ovirt.org has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
automat...@ovirt.org has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
Francesco Romani has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 6: rebased. No code changes (as gerrit itself confirms) so I don't know why score was lost. -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16318/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15518/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16488/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
Nir Soffer has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/38268/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-02-23 18:22:11 +0100 Line 4: Commit: Francesco Romani from...@redhat.com Line 5: CommitDate: 2015-03-06 09:39:58 +0100 Line 6: Line 7: janitorial: vm: switch to response.error() janitorial: - vm: Line 8: Line 9: response.error() offers a nicer and cleaner Line 10: way to report error responses instead of the bare Line 11: errCode['something'], even when we are fine with -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
Nir Soffer has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
Francesco Romani has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/38268/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1588 Line 1589 Line 1590 Line 1591 Line 1592 Is errCode used after this patch? Yes: - in _reportError (trivial, fixed in followup patch) - in an handful of places inside the virt package (will fix in followup patches) - in v2v.py (same as above) - in BindingXMLRPC.py (seems easy) - in a few places inside the network package (vdsm/network/), seems easy - in a bunch of places inside API.py and clientIF.py I will post followup patches to fix the rest of virt and v2v.py once these are merged. Then we will tackle the rest. -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
Nir Soffer has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 5: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/38268/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1588 Line 1589 Line 1590 Line 1591 Line 1592 Is errCode used after this patch? -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2635/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16283/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15483/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16453/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2640/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16292/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15492/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16462/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
Francesco Romani has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 2: rebased -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2604/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16244/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15444/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16414/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2608/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16248/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15448/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16418/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
Francesco Romani has uploaded a new change for review.
Change subject: janitorial: vm: switch to response.error()
..
janitorial: vm: switch to response.error()
response.error() offers a nicer and cleaner
way to report error responses instead of the bare
errCode['something'], even when we are fine with
the default generic message.
This patch makes use of response.error() all across
vm.py.
Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 62 insertions(+), 62 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/38268/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index e7fbcf2..cd392c7 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1589,7 +1589,7 @@
if self.lastStatus in (vmstatus.MIGRATION_SOURCE,
vmstatus.SAVING_STATE, vmstatus.DOWN):
self.log.error('cannot cont while %s', self.lastStatus)
-return errCode['unexpected']
+return response.error('unexpected')
self._underlyingCont()
self._setGuestCpuRunning(self._isDomainRunning(),
guestCpuLocked=True)
@@ -1638,7 +1638,7 @@
def shutdown(self, delay, message, reboot, timeout, force):
if self.lastStatus == vmstatus.DOWN:
-return errCode['noVM']
+return response.error('noVM')
delay = int(delay)
@@ -1913,13 +1913,13 @@
try:
if self.isMigrating():
self.log.warning('vm already migrating')
-return errCode['exist']
+return response.error('exist')
if self.hasTransientDisks():
-return errCode['transientErr']
+return response.error('transientErr')
# while we were blocking, another migrationSourceThread could have
# taken self Down
if self._lastStatus == vmstatus.DOWN:
-return errCode['noVM']
+return response.error('noVM')
self._migrationSourceThread = migration.SourceThread(
self, **params)
self._migrationSourceThread.start()
@@ -1940,11 +1940,11 @@
return self._migrationSourceThread.status
except libvirt.libvirtError as e:
if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID:
-return errCode['migCancelErr']
+return response.error('migCancelErr')
raise
except AttributeError:
if self._dom is None:
-return errCode['migCancelErr']
+return response.error('migCancelErr')
raise
finally:
self._guestCpuLock.release()
@@ -2317,7 +2317,7 @@
def hotplugNic(self, params):
if self.isMigrating():
-return errCode['migInProgress']
+return response.error('migInProgress')
nicParams = params['nic']
nic = vmdevices.network.Interface(self.conf, self.log, **nicParams)
@@ -2336,7 +2336,7 @@
nicXml = hooks.after_nic_hotplug_fail(
nicXml, self.conf, params=nic.custom)
if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
-return errCode['noVM']
+return response.error('noVM')
return response.error('hotplugNic', e.message)
else:
# FIXME! We may have a problem here if vdsm dies right after
@@ -2524,7 +2524,7 @@
response['vmList'] = self.status()
return response
else:
-return errCode['updateDevice']
+return response.error('updateDevice')
def updateDevice(self, params):
if params.get('deviceType') == hwclass.NIC:
@@ -2532,11 +2532,11 @@
elif params.get('deviceType') == hwclass.GRAPHICS:
return self._updateGraphicsDevice(params)
else:
-return errCode['noimpl']
+return response.error('noimpl')
def hotunplugNic(self, params):
if self.isMigrating():
-return errCode['migInProgress']
+return response.error('migInProgress')
nicParams = params['nic']
@@ -2583,7 +2583,7 @@
except libvirt.libvirtError as e:
self.log.exception(Hotunplug failed)
if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
-return errCode['noVM']
+return response.error('noVM')
# Restore NIC device in vm's conf and _devices
if nicDev:
with self._confLock:
@@ -2602,7 +2602,7 @@
def setNumberOfCpus(self, numberOfCpus):
if self.isMigrating():
-return errCode['migInProgress']
+return response.error('migInProgress')
Change in vdsm[master]: janitorial: vm: switch to response.error()
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2589/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16165/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15365/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16335/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1141/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
