Change in vdsm[master]: jsonrpc: raise JsonRpcError with meaningful message
Yeela Kaplan has posted comments on this change. Change subject: jsonrpc: raise JsonRpcError with meaningful message .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39781/1/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 33: def __init__(self, code, msg): Line 34: super(JsonRpcError, self).__init__(msg) Line 35: self.code = code Line 36: self.message = msg Line 37: super(RuntimeError, self).__init__( This should be removed, base constructor should not be invoked twice Done Line 38: [%d] %s % (self.code, self.message) Line 39: ) Line 40: Line 41: -- To view, visit https://gerrit.ovirt.org/39781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: raise JsonRpcError with meaningful message
Dima Kuznetsov has posted comments on this change. Change subject: jsonrpc: raise JsonRpcError with meaningful message .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/39781/1/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 33: def __init__(self, code, msg): Line 34: super(JsonRpcError, self).__init__(msg) Line 35: self.code = code Line 36: self.message = msg Line 37: super(RuntimeError, self).__init__( This should be removed, base constructor should not be invoked twice Line 38: [%d] %s % (self.code, self.message) Line 39: ) Line 40: Line 41: -- To view, visit https://gerrit.ovirt.org/39781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: raise JsonRpcError with meaningful message
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: raise JsonRpcError with meaningful message .. Patch Set 1: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17825/ -- To view, visit https://gerrit.ovirt.org/39781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: raise JsonRpcError with meaningful message
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: raise JsonRpcError with meaningful message .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17825/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17654/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: raise JsonRpcError with meaningful message
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: raise JsonRpcError with meaningful message .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: raise JsonRpcError with meaningful message
Yeela Kaplan has uploaded a new change for review. Change subject: jsonrpc: raise JsonRpcError with meaningful message .. jsonrpc: raise JsonRpcError with meaningful message Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Signed-off-by: Yeela Kaplan ykap...@redhat.com --- M lib/yajsonrpc/__init__.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/39781/1 diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py index 0137e16..c5a1b3b 100644 --- a/lib/yajsonrpc/__init__.py +++ b/lib/yajsonrpc/__init__.py @@ -31,6 +31,7 @@ class JsonRpcError(RuntimeError): def __init__(self, code, msg): +super(JsonRpcError, self).__init__(msg) self.code = code self.message = msg super(RuntimeError, self).__init__( -- To view, visit https://gerrit.ovirt.org/39781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: raise JsonRpcError with meaningful message
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: raise JsonRpcError with meaningful message .. Patch Set 1: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17654/ -- To view, visit https://gerrit.ovirt.org/39781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
