Change in vdsm[master]: jsonrpcvdscli: fix getVolumeInfo command result

2016-09-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: fix getVolumeInfo command result
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/63410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2befe845b1d9885638cc4254e60cebd66eb6f72
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix getVolumeInfo command result

2016-09-14 Thread igoihman 
Irit Goihman has abandoned this change.

Change subject: jsonrpcvdscli: fix getVolumeInfo command result
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/63410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id2befe845b1d9885638cc4254e60cebd66eb6f72
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix getVolumeInfo command result

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: fix getVolumeInfo command result
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2befe845b1d9885638cc4254e60cebd66eb6f72
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix getVolumeInfo command result

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: fix getVolumeInfo command result
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/63052
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I985db6344fa7e34d78d38d7c6fe96a6b91839604
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix getVolumeInfo command result

2016-09-06 Thread igoihman 
Irit Goihman has abandoned this change.

Change subject: jsonrpcvdscli: fix getVolumeInfo command result
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/63052
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I985db6344fa7e34d78d38d7c6fe96a6b91839604
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix getVolumeInfo command result

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: fix getVolumeInfo command result
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63052
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I985db6344fa7e34d78d38d7c6fe96a6b91839604
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix getVolumeInfo command result

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: fix getVolumeInfo command result
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2befe845b1d9885638cc4254e60cebd66eb6f72
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix getVolumeInfo command result

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: fix getVolumeInfo command result
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2befe845b1d9885638cc4254e60cebd66eb6f72
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix getVolumeInfo command result

2016-09-06 Thread igoihman 
Irit Goihman has uploaded a new change for review.

Change subject: jsonrpcvdscli: fix getVolumeInfo command result
..

jsonrpcvdscli: fix getVolumeInfo command result

getVolumeInfo command returns a dictionary with volume info stats.
The result should hold all the data in 'info' key but instead it
stores the inner dictionary as the main one and 'status' field of
the dictionary is overriden by JsonRpcResponse status

Change-Id: Id2befe845b1d9885638cc4254e60cebd66eb6f72
Signed-off-by: Irit Goihman 
---
M lib/vdsm/rpc/Bridge.py
1 file changed, 11 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/63410/1

diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index 62db38f..2c00dcf 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -102,7 +102,7 @@
 if member is None:
 return None
 try:
-return {member: response[member]}
+return response[member]
 except KeyError:
 raise VdsmError(5, "Response is missing '%s' member" % member)
 
@@ -315,6 +315,15 @@
 return {'params': ret['params'], 'migrationPort': ret['migrationPort']}
 
 
+def Volume_getInfo_Ret(ret):
+"""
+The returned dictionary doesn't separate the info from the status code
+so we need to rebuild the result.
+"""
+del ret['status']
+return ret
+
+
 def Volume_getsize_Ret(ret):
 """
 Merge the two sizes into a single dictionary result.
@@ -418,7 +427,7 @@
 'Volume_copy': {'ret': 'uuid'},
 'Volume_create': {'ret': 'uuid'},
 'Volume_delete': {'ret': 'uuid'},
-'Volume_getInfo': {'ret': 'info'},
+'Volume_getInfo': {'ret': Volume_getInfo_Ret},
 'Volume_getPath': {'ret': 'path'},
 'Volume_getSize': {'ret': Volume_getsize_Ret},
 'Volume_extendSize': {'ret': 'uuid'},


-- 
To view, visit https://gerrit.ovirt.org/63410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2befe845b1d9885638cc4254e60cebd66eb6f72
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org