Change in vdsm[master]: logging: Enable all storage loggers

2014-01-30 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: logging: Enable all storage loggers
..


Patch Set 1: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6132/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7025/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6919/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_localfs/88/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_nfs/26/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Tomáš Došek 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logging: Enable all storage loggers

2014-01-30 Thread nsoffer 
Nir Soffer has uploaded a new change for review.

Change subject: logging: Enable all storage loggers
..

logging: Enable all storage loggers

Only loggers mentioned in logger.conf, or their child loggers are used
by the logging system. This make debugging the code much harder.

This patch enable 23 storage loggers by making them child loggers of the
Storage logger.

If we want to disable some loggers, the proper place to do it is in
logger.conf.

Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Signed-off-by: Nir Soffer 
---
M vdsm/storage/blockSD.py
M vdsm/storage/clusterlock.py
M vdsm/storage/fileSD.py
M vdsm/storage/misc.py
M vdsm/storage/remoteFileHandler.py
M vdsm/storage/resourceManager.py
M vdsm/storage/storageServer.py
M vdsm/storage/task.py
M vdsm/storage/taskManager.py
M vdsm/storage/threadPool.py
10 files changed, 23 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/23924/1

diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index 55bd796..35c4f45 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -277,7 +277,7 @@
 
 
 class VGTagMetadataRW(object):
-log = logging.getLogger("storage.Metadata.VGTagMetadataRW")
+log = logging.getLogger("Storage.Metadata.VGTagMetadataRW")
 METADATA_TAG_PREFIX = "MDT_"
 METADATA_TAG_PREFIX_LEN = len(METADATA_TAG_PREFIX)
 
@@ -320,7 +320,7 @@
 """
 Block Storage Domain metadata implementation
 """
-log = logging.getLogger("storage.Metadata.LvMetadataRW")
+log = logging.getLogger("Storage.Metadata.LvMetadataRW")
 
 def __init__(self, vgName, lvName, offset, size):
 self._size = size
diff --git a/vdsm/storage/clusterlock.py b/vdsm/storage/clusterlock.py
index f7e7fb6..83b2b9f 100644
--- a/vdsm/storage/clusterlock.py
+++ b/vdsm/storage/clusterlock.py
@@ -47,7 +47,7 @@
 
 
 class SafeLease(object):
-log = logging.getLogger("SafeLease")
+log = logging.getLogger("Storage.SafeLease")
 
 lockUtilPath = config.get('irs', 'lock_util_path')
 lockCmd = config.get('irs', 'lock_cmd')
@@ -137,7 +137,7 @@
 self.log.debug("Cluster lock released successfully")
 
 
-initSANLockLog = logging.getLogger("initSANLock")
+initSANLockLog = logging.getLogger("Storage.initSANLock")
 
 
 def initSANLock(sdUUID, idsPath, leasesPath):
@@ -154,7 +154,7 @@
 
 
 class SANLock(object):
-log = logging.getLogger("SANLock")
+log = logging.getLogger("Storage.SANLock")
 
 _sanlock_fd = None
 _sanlock_lock = threading.Lock()
@@ -290,7 +290,7 @@
 
 
 class LocalLock(object):
-log = logging.getLogger("LocalLock")
+log = logging.getLogger("Storage.LocalLock")
 
 LVER = 0
 
diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index 180a43f..98bb909 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -616,7 +616,7 @@
 
 
 def scanDomains(pattern="*"):
-log = logging.getLogger("scanDomains")
+log = logging.getLogger("Storage.scanDomains")
 
 mntList = getMountsList(pattern)
 
diff --git a/vdsm/storage/misc.py b/vdsm/storage/misc.py
index 2c06af3..e464dcd 100644
--- a/vdsm/storage/misc.py
+++ b/vdsm/storage/misc.py
@@ -736,7 +736,7 @@
 Supporting parameters or exception passing to all functions would
 make the code much more complex for no reason.
 """
-_log = logging.getLogger("SamplingMethod")
+_log = logging.getLogger("Storage.SamplingMethod")
 
 def __init__(self, func):
 self.__func = func
@@ -866,7 +866,7 @@
 
 class Event(object):
 def __init__(self, name, sync=False):
-self._log = logging.getLogger("Event.%s" % name)
+self._log = logging.getLogger("Storage.Event.%s" % name)
 self.name = name
 self._syncRoot = threading.Lock()
 self._registrar = {}
@@ -910,7 +910,7 @@
 
 
 class OperationMutex(object):
-log = enableLogSkip(logging.getLogger("OperationMutex"),
+log = enableLogSkip(logging.getLogger("Storage.OperationMutex"),
 ignoreSourceFiles=[__file__, contextlib.__file__])
 
 def __init__(self):
diff --git a/vdsm/storage/remoteFileHandler.py 
b/vdsm/storage/remoteFileHandler.py
index cacafbf..d5a4ff7 100644
--- a/vdsm/storage/remoteFileHandler.py
+++ b/vdsm/storage/remoteFileHandler.py
@@ -217,7 +217,7 @@
 
 
 class PoolHandler(object):
-log = logging.getLogger("RepoFileHelper.PoolHandler")
+log = logging.getLogger("Storage.RepoFileHelper.PoolHandler")
 
 def __init__(self):
 myRead, hisWrite = os.pipe()
diff --git a/vdsm/storage/resourceManager.py b/vdsm/storage/resourceManager.py
index 1be1450..64a5e86 100644
--- a/vdsm/storage/resourceManager.py
+++ b/vdsm/storage/resourceManager.py
@@ -168,7 +168,7 @@
 """
 Internal request object, don't use directly
 """
-_log = logging.getLogger("ResourceManager.Request")
+_log = logging.getLogger("Storage.ResourceManager.Request")

Change in vdsm[master]: logging: Enable all storage loggers

2014-01-30 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: logging: Enable all storage loggers
..


Patch Set 1: Verified+1

Some loggers, like Storage.ResourceMananger and Storage.TaskManger are less 
useful as they are more utility then storage. Maybe to move them to util.xxx 
instead of storage, and add a disabled utils logger in logger.conf, to make it 
easy to enable all logging when you have a problem in the field or in qe.

-- 
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomáš Došek 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logging: Enable all storage loggers

2014-02-03 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: logging: Enable all storage loggers
..


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/23924/1//COMMIT_MSG
Commit Message:

Line 9: Only loggers mentioned in logger.conf, or their child loggers are used
Line 10: by the logging system. This make debugging the code much harder.
Line 11: 
Line 12: This patch enable 23 storage loggers by making them child loggers of 
the
Line 13: Storage logger.
Pardon my ignorance, but why don't these logger inherit handler definitions 
from the root logger?


 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1060510
Line 14: 
Line 15: If we want to disable some loggers, the proper place to do it is in
Line 16: logger.conf.
Line 17: 


-- 
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomáš Došek 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logging: Enable all storage loggers

2014-02-03 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: logging: Enable all storage loggers
..


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/23924/1//COMMIT_MSG
Commit Message:

Line 9: Only loggers mentioned in logger.conf, or their child loggers are used
Line 10: by the logging system. This make debugging the code much harder.
Line 11: 
Line 12: This patch enable 23 storage loggers by making them child loggers of 
the
Line 13: Storage logger.
> Pardon my ignorance, but why don't these logger inherit handler definitions
It would be nice it they did, but it seems that they do not.

I remember seeing some of these logs (e.g. sanlock) few month ago, but I cannot 
find any relevant change that can explain why they do not appear in the log any 
more.

Hopefully someone have a clue about this issue - I'm not very happy with those 
long names (e.g. Storage.ResourceManager.Blah) cluttering the logs.
Line 14: 
Line 15: If we want to disable some loggers, the proper place to do it is in
Line 16: logger.conf.
Line 17: 


-- 
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomáš Došek 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logging: Enable all storage loggers

2014-02-07 Thread Federico Simoncelli 
Federico Simoncelli has posted comments on this change.

Change subject: logging: Enable all storage loggers
..


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/23924/1//COMMIT_MSG
Commit Message:

Line 9: Only loggers mentioned in logger.conf, or their child loggers are used
Line 10: by the logging system. This make debugging the code much harder.
Line 11: 
Line 12: This patch enable 23 storage loggers by making them child loggers of 
the
Line 13: Storage logger.
> It would be nice it they did, but it seems that they do not.
That's weird, the default behavior should be indeed to inherit from root. I 
wonder if there's something that we do that breaks that system (maybe 
propagate=0 in the root logger?). I think we should test our logger.conf 
thoroughly.
Line 14: 
Line 15: If we want to disable some loggers, the proper place to do it is in
Line 16: logger.conf.
Line 17: 


-- 
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomáš Došek 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logging: Enable all storage loggers

2014-03-01 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: logging: Enable all storage loggers
..


Patch Set 1: Code-Review+1

i'd take this in addition to http://gerrit.ovirt.org/#/c/25185/

-- 
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomáš Došek 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logging: Enable all storage loggers

2014-03-02 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: logging: Enable all storage loggers
..


Patch Set 1:

This is fixed now by http://gerrit.ovirt.org/25185.

So what this patch gives us now is a way to configure all loggers under 
vdsm/storage/ by configuring the Storage logger in the logging configuration 
file.

-- 
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomáš Došek 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logging: Enable all storage loggers

2014-03-04 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: logging: Enable all storage loggers
..


Patch Set 1:

Is this still needed when http://gerrit.ovirt.org/#/c/25185/ is merged?

-- 
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomáš Došek 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logging: Enable all storage loggers

2014-03-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: logging: Enable all storage loggers
..


Patch Set 1:

This can help to configure the new loggers that were missing before.

For example, some logger may log to syslog while storage logger are configured 
to not log to syslog.

Or maybe you want to change the configuration for all storage loggers, now all 
sub loggers inherit the storage configuration.

However I think that some loggers, like ResourceMonitor are not related to 
storage and should sub loggeres of utils logger (which does not exists yet).

-- 
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomáš Došek 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logging: Enable all storage loggers

2014-03-05 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: logging: Enable all storage loggers
..


Patch Set 1:

it is required and important! using a logger that doesn't exist is a bug, even 
if now unknown logger will be caught by root handler. if one day we will want 
to split all logs from storage logs or change only storage related logs 
handling, we'll have the option. utils logger is redundant, use vds handler if 
its not related to storage.

-- 
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomáš Došek 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logging: Enable all storage loggers

2014-03-17 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: logging: Enable all storage loggers
..


Patch Set 1:

what about that ? I'd take it and backport it in this bug's scope.

-- 
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomáš Došek 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logging: Enable all storage loggers

2014-04-03 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: logging: Enable all storage loggers
..


Patch Set 1:

Take it :-)

-- 
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomáš Došek 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logging: Enable all storage loggers

2014-04-07 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: logging: Enable all storage loggers
..


Patch Set 1:

can you remove the "Draft" and retriger the jenkins job?

Dan, any comments about that?

-- 
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomáš Došek 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logging: Enable all storage loggers

2014-04-07 Thread nsoffer 
Nir Soffer has uploaded a new change for review.

Change subject: logging: Enable all storage loggers
..

logging: Enable all storage loggers

Only loggers mentioned in logger.conf, or their child loggers are used
by the logging system. This make debugging the code much harder.

This patch enable 23 storage loggers by making them child loggers of the
Storage logger.

If we want to disable some loggers, the proper place to do it is in
logger.conf.

Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Signed-off-by: Nir Soffer 
---
M vdsm/storage/blockSD.py
M vdsm/storage/clusterlock.py
M vdsm/storage/fileSD.py
M vdsm/storage/misc.py
M vdsm/storage/remoteFileHandler.py
M vdsm/storage/resourceManager.py
M vdsm/storage/storageServer.py
M vdsm/storage/task.py
M vdsm/storage/taskManager.py
M vdsm/storage/threadPool.py
10 files changed, 23 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/23924/1

diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index 55bd796..35c4f45 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -277,7 +277,7 @@
 
 
 class VGTagMetadataRW(object):
-log = logging.getLogger("storage.Metadata.VGTagMetadataRW")
+log = logging.getLogger("Storage.Metadata.VGTagMetadataRW")
 METADATA_TAG_PREFIX = "MDT_"
 METADATA_TAG_PREFIX_LEN = len(METADATA_TAG_PREFIX)
 
@@ -320,7 +320,7 @@
 """
 Block Storage Domain metadata implementation
 """
-log = logging.getLogger("storage.Metadata.LvMetadataRW")
+log = logging.getLogger("Storage.Metadata.LvMetadataRW")
 
 def __init__(self, vgName, lvName, offset, size):
 self._size = size
diff --git a/vdsm/storage/clusterlock.py b/vdsm/storage/clusterlock.py
index f7e7fb6..83b2b9f 100644
--- a/vdsm/storage/clusterlock.py
+++ b/vdsm/storage/clusterlock.py
@@ -47,7 +47,7 @@
 
 
 class SafeLease(object):
-log = logging.getLogger("SafeLease")
+log = logging.getLogger("Storage.SafeLease")
 
 lockUtilPath = config.get('irs', 'lock_util_path')
 lockCmd = config.get('irs', 'lock_cmd')
@@ -137,7 +137,7 @@
 self.log.debug("Cluster lock released successfully")
 
 
-initSANLockLog = logging.getLogger("initSANLock")
+initSANLockLog = logging.getLogger("Storage.initSANLock")
 
 
 def initSANLock(sdUUID, idsPath, leasesPath):
@@ -154,7 +154,7 @@
 
 
 class SANLock(object):
-log = logging.getLogger("SANLock")
+log = logging.getLogger("Storage.SANLock")
 
 _sanlock_fd = None
 _sanlock_lock = threading.Lock()
@@ -290,7 +290,7 @@
 
 
 class LocalLock(object):
-log = logging.getLogger("LocalLock")
+log = logging.getLogger("Storage.LocalLock")
 
 LVER = 0
 
diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index 180a43f..98bb909 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -616,7 +616,7 @@
 
 
 def scanDomains(pattern="*"):
-log = logging.getLogger("scanDomains")
+log = logging.getLogger("Storage.scanDomains")
 
 mntList = getMountsList(pattern)
 
diff --git a/vdsm/storage/misc.py b/vdsm/storage/misc.py
index 2c06af3..e464dcd 100644
--- a/vdsm/storage/misc.py
+++ b/vdsm/storage/misc.py
@@ -736,7 +736,7 @@
 Supporting parameters or exception passing to all functions would
 make the code much more complex for no reason.
 """
-_log = logging.getLogger("SamplingMethod")
+_log = logging.getLogger("Storage.SamplingMethod")
 
 def __init__(self, func):
 self.__func = func
@@ -866,7 +866,7 @@
 
 class Event(object):
 def __init__(self, name, sync=False):
-self._log = logging.getLogger("Event.%s" % name)
+self._log = logging.getLogger("Storage.Event.%s" % name)
 self.name = name
 self._syncRoot = threading.Lock()
 self._registrar = {}
@@ -910,7 +910,7 @@
 
 
 class OperationMutex(object):
-log = enableLogSkip(logging.getLogger("OperationMutex"),
+log = enableLogSkip(logging.getLogger("Storage.OperationMutex"),
 ignoreSourceFiles=[__file__, contextlib.__file__])
 
 def __init__(self):
diff --git a/vdsm/storage/remoteFileHandler.py 
b/vdsm/storage/remoteFileHandler.py
index cacafbf..d5a4ff7 100644
--- a/vdsm/storage/remoteFileHandler.py
+++ b/vdsm/storage/remoteFileHandler.py
@@ -217,7 +217,7 @@
 
 
 class PoolHandler(object):
-log = logging.getLogger("RepoFileHelper.PoolHandler")
+log = logging.getLogger("Storage.RepoFileHelper.PoolHandler")
 
 def __init__(self):
 myRead, hisWrite = os.pipe()
diff --git a/vdsm/storage/resourceManager.py b/vdsm/storage/resourceManager.py
index 1be1450..64a5e86 100644
--- a/vdsm/storage/resourceManager.py
+++ b/vdsm/storage/resourceManager.py
@@ -168,7 +168,7 @@
 """
 Internal request object, don't use directly
 """
-_log = logging.getLogger("ResourceManager.Request")
+_log = logging.getLogger("Storage.ResourceManager.Request")

Change in vdsm[master]: logging: Enable all storage loggers

2014-04-08 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: logging: Enable all storage loggers
..


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/23924/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-01-30 19:20:44 +0200
Line 6: 
Line 7: logging: Enable all storage loggers
Line 8: 
Line 9: Only loggers mentioned in logger.conf, or their child loggers are used
With http://gerrit.ovirt.org/#/c/25185/ merged, this commit message needs a 
little retouch (and I suspect a rebase, too, due to the passed time).
Line 10: by the logging system. This make debugging the code much harder.
Line 11: 
Line 12: This patch enable 23 storage loggers by making them child loggers of 
the
Line 13: Storage logger.


-- 
To view, visit http://gerrit.ovirt.org/23924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd8cd29377b12dc290f90b7c6bf314d5624a830
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tomáš Došek 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches